Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBI-35: edit assignment #70

Merged
merged 36 commits into from
May 16, 2022
Merged

PBI-35: edit assignment #70

merged 36 commits into from
May 16, 2022

Conversation

AldiNFitrah
Copy link

No description provided.

AldiNFitrah added 14 commits May 15, 2022 11:53
@AldiNFitrah
[RED] test access create assignment
55e21f1
@AldiNFitrah
[GREEN] create assignment routes and controller skeleton
f07c50f
@AldiNFitrah
[RED] test create assignment in unenrolled course
a3a7bcb
@AldiNFitrah
[GREEN] forbid unenrolled user to create assignment
d707aa9
@AldiNFitrah
[RED] test create assignment as a student
2fb4fb0
@AldiNFitrah
[GREEN] restrict to only teacher who can create assignment
f393eda
@AldiNFitrah
[RED] test create assignment with no title
c0df7cf
@AldiNFitrah
[GREEN] make title required when creating assignment
9dd72da
@AldiNFitrah
[RED] test create assignment with no due date
c2c3497
@AldiNFitrah
[GREEN] make due date field required with certain format
b3b4eae
@AldiNFitrah
[RED] test create assignment should insert to db
d43aa18
@AldiNFitrah
[GREEN] insert data to db on create assignment
fb01219
@AldiNFitrah
[RED] test create assignment should return data
e126a80
@AldiNFitrah
[GREEN] return created assignment on create assignment
6aacc30
@AldiNFitrah AldiNFitrah self-assigned this May 15, 2022
@AldiNFitrah AldiNFitrah force-pushed the PBI-34-view_assignment branch from da26f56 to 955efab Compare May 15, 2022 15:29
@AldiNFitrah AldiNFitrah force-pushed the PBI-35-edit_assignment branch from e2faa51 to 2406211 Compare May 15, 2022 15:30
nofamex
nofamex approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@nofamex nofamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Merge now cause i need this

@IlmaMannix IlmaMannix linked an issue May 16, 2022 that may be closed by this pull request
PBI-35: Teacher can edit assignment in class #74
Closed
Zsaschz
Zsaschz approved these changes May 16, 2022
View reviewed changes
Copy link

@Zsaschz Zsaschz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean commit, nice work!

kanziebub
kanziebub approved these changes May 16, 2022
View reviewed changes
Copy link

@kanziebub kanziebub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM uwu

@AldiNFitrah AldiNFitrah changed the base branch from PBI-34-view_assignment to staging May 16, 2022 13:39
@AldiNFitrah AldiNFitrah merged commit ccce6df into staging May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanziebub kanziebub kanziebub approved these changes

@nofamex nofamex nofamex approved these changes

@Zsaschz Zsaschz Zsaschz approved these changes

@FXDROS FXDROS Awaiting requested review from FXDROS

@darren-ngoh darren-ngoh Awaiting requested review from darren-ngoh

@IlmaMannix IlmaMannix Awaiting requested review from IlmaMannix

Assignees

@AldiNFitrah AldiNFitrah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PBI-35: Teacher can edit assignment in class
4 participants
@AldiNFitrah @Zsaschz @nofamex @kanziebub