Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "whitelist" to "allowlist" #31066

Merged
merged 14 commits into from
Jun 19, 2020
Merged

Change "whitelist" to "allowlist" #31066

merged 14 commits into from
Jun 19, 2020

Conversation

patrickhlauke
Copy link
Member

Closes #31064

note that this leaves intact the use of blacklist for stylelint

@patrickhlauke patrickhlauke requested a review from mdo June 17, 2020 08:46
@patrickhlauke patrickhlauke requested a review from a team as a code owner June 17, 2020 08:46
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge I want to have a closer look.

@XhmikosR
Copy link
Member

From a quick look, the change needs to be listed in the migration page in detail.

I will check later the branch.

@patrickhlauke
Copy link
Member Author

ah, was thinking about migration guide, but then thought that it's not really a user/developer facing object (unless somebody was hooking directly into the function for some reason).

@XhmikosR
Copy link
Member

ah, was thinking about migration guide, but then thought that it's not really a user/developer facing object (unless somebody was hooking directly into the function for some reason).

Yeah, it's a breaking change so it needs to be documented. :)

@XhmikosR
Copy link
Member

Pending the Migration addition, otherwise the changes look good.

@patrickhlauke
Copy link
Member Author

added migration guide entry ... too detailed or ok? @XhmikosR

@XhmikosR
Copy link
Member

XhmikosR commented Jun 17, 2020

I'd like @Johann-S opinion, not sure if all of the listed methods are public. We should only list public stuff.

AFAICT only allowList is public.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@patrickhlauke
Copy link
Member Author

@Johann-S thoughts on the migration guide question? does it look good or does it need to be expanded?

@Johann-S
Copy link
Member

LGTM on the migration guide, since it's a public option it's important to be added in our migration guide

@XhmikosR XhmikosR merged commit edbcc40 into main Jun 19, 2020
@XhmikosR XhmikosR deleted the v5-allowList branch June 19, 2020 08:31
@XhmikosR XhmikosR changed the title Change whitelist to allowlist Change "whitelist" to "allowlist" Jul 7, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: XhmikosR <[email protected]>
Co-authored-by: Mark Otto <[email protected]>
@lachlansimpson
Copy link

Note that stylelint removed *-blacklist https://github.com/stylelint/stylelint/releases/tag/13.7.0 - can this be revisited?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Remove blacklist and other oppressive terminology
6 participants