Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

words matter scan #9

Closed
PhilWakelin opened this issue Jan 29, 2021 · 3 comments
Closed

words matter scan #9

PhilWakelin opened this issue Jan 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@PhilWakelin
Copy link
Member

The following files in this repo contain the word "master"

cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\css\bootstrap.css line: 3 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 3 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 13 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 62 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 151 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 259 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 465 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 636 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 784 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 1029 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 1428 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 1539 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 1693 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.js line: 1819 contains: master
cics-nodejs-invoke\projects\cics-nodejs-invoke\public\assets\js\bootstrap.min.js line: 3 contains: master

@markcocker can you review and update It looks like most of these just need updating to the new main repo branch

@markcocker
Copy link
Member

markcocker commented Mar 31, 2021

The Bootstrap version 5.0.0-alpha2 addressed this in twbs/bootstrap#31066 on 19 Jun 2020. According to https://getbootstrap.com/docs/versions/ the only version of Boostrap for download that includes this pull request is still in beta (version 5 beta 3).

I suggest waiting until the next non-beta version is available before including it in this repo.

@markcocker markcocker added the enhancement New feature or request label Mar 31, 2021
@PhilWakelin
Copy link
Member Author

The Bootstrap version 5.0.0-alpha2 addressed this in twbs/bootstrap#31066 on 19 Jun 2020. According to https://getbootstrap.com/docs/versions/ the only version of Boostrap for download that includes this pull request is still in beta (version 5 beta 3).

I suggest waiting until the next non-beta version is available before including it in this repo.

The boostrap issue is re. whitelist and blacklist terms. However, the hits in this repo concern the term master in the license location comments i.e.
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
All of which have already been renamed to main in the latest version of bootstrap 4.6

@markcocker
Copy link
Member

Renamed master branch to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants