Change URL for license #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change URL to MIT to https://github.com/twbs/bootstrap/blob/main/LICENSE
|
I tried updating Bootstrap components to https://github.com/twbs/bootstrap/releases/tag/v4.6.0 but this caused the catalog to be displayed in the browser as a single column, the menu wasn't displayed correctly, and the pop-up to order an item was oversized. These are the Bootstrap 4.6 components I tried replacing: cp ~/Downloads/bootstrap-4.6.0-dist/css/bootstrap.css projects/cics-nodejs-invoke/public/assets/css
cp ~/Downloads/bootstrap-4.6.0-dist/js/bootstrap.js projects/cics-nodejs-invoke/public/assets/js
cp ~/Downloads/bootstrap-4.6.0-dist/js/bootstrap.min.js projects/cics-nodejs-invoke/public/assets/jsSo going from 3.1 to 4.6 is not a drop-in replacement and will need dev effort to fix. I don't have the front-end skills to do that so this PR is sticking with 3.1 and amending the URL to the MIT license. |
|
Changes look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change URL to MIT to https://github.com/twbs/bootstrap/blob/main/LICENSE
Resolves #9