Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto code and options use terms blacklist and whitelist #3741

Closed
4 tasks done
lachlansimpson opened this issue Dec 23, 2022 · 6 comments · Fixed by #8703
Closed
4 tasks done

Quarto code and options use terms blacklist and whitelist #3741

lachlansimpson opened this issue Dec 23, 2022 · 6 comments · Fixed by #8703
Labels
bug Something isn't working
Milestone

Comments

@lachlansimpson
Copy link

Bug description

Quarto uses the terms whitelist and blacklist.

this._url_whitelist = { 'http': 1, 'https': 1 };

// stylelint-disable property-blacklist, scss/dollar-variable-default

Checklist

  • Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
  • Please format your issue so it is easier for us to read the bug report.
  • Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
  • Please document the operating system you're running. If on Linux, please provide the specific distribution.
@lachlansimpson lachlansimpson added the bug Something isn't working label Dec 23, 2022
@cscheid
Copy link
Collaborator

cscheid commented Dec 23, 2022

Yes, these are very problematic terms. But they come from dependencies that we don't control, so we can't fix them.

@cscheid cscheid closed this as completed Dec 23, 2022
@lachlansimpson
Copy link
Author

For future reference, I see that the first two references are to whitelist in anso_up.js. An issue has been opened against their repo here: drudru/ansi_up#71

The reference to blacklist is in Bootstrap, and is upstream to them in stylelint:

@lachlansimpson
Copy link
Author

lachlansimpson commented Oct 16, 2023

Hi @cscheid I see that Bootstrap has updated to remove blacklist and that ansi_up removed whitelist in a commit on Aug 15.

Is it possible for these changes to be imported to Quarto now? Thanks!

@dragonstyle
Copy link
Collaborator

We have updated our bootstrap dependency in Quarto 1.4 and it incorporates this change. Leaving open as I believe that we still have the issue with anso_up.js.

@mcanouil mcanouil reopened this Oct 16, 2023
@lachlansimpson
Copy link
Author

@dragonstyle thank you - is that because more testing is needed before using the latest version of anso_up.js?

@dragonstyle
Copy link
Collaborator

No I'm just not that familiar with our use of ansi_up. I will take a closer look soon.

@dragonstyle dragonstyle added this to the v1.5 milestone Nov 28, 2023
cscheid added a commit that referenced this issue Feb 12, 2024
@cscheid cscheid reopened this Feb 12, 2024
cscheid added a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants