Ensure to pass 4.5:1 contrast ratio everywhere #30548
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like dependabot one, but isn't :)
Paving the way in #30468 — and to keep going with #29315 : my goal is to make this happen after tackling every obstacles.
To solve before the bump
Those should probably adressed separately, consider this as a roadmap to enlightment :D
.btn-success:hover
case mentionned in #30468 (comment);color-level()
,lighten()
anddarken()
seem misused: either on:hover
for buttons (always darken) or to definecolor
andbackground-color
with the same level, no matter what the base color is (eg..alert-light
seems wrong) — there's probably room to improvement by usingtint()
andshade()
here;*-bg-level
and*-border-level
variables #30487$dark
to$gray-900
#30550 →.text-info
,.text-black-50
and.text-white-50
can't make it to 4.5:1 — however, using$gray-900
instead of$gray-800
for$dark
would solve this (and several other dark-ish things with insufficient contrasts);.text-muted
or.disabled
things;.btn-outline-*
and.link-*
examples should be shown with dark background:Merging this would be a kind of consecration 🎉
Fixes #25126