Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review *-bg-level and *-border-level variables #30487

Closed
MartijnCuppens opened this issue Mar 31, 2020 · 5 comments
Closed

Review *-bg-level and *-border-level variables #30487

MartijnCuppens opened this issue Mar 31, 2020 · 5 comments
Labels
css v5

Comments

@MartijnCuppens
Copy link
Member

It seems there are some inconsistencies in the color levels of the tables/list-group-items/alerts (#30009 (comment)). We better equalize these variables and check their color contrast.
@ffoodd
Copy link
Member

ffoodd commented Mar 31, 2020

Indeed — I'm not familiar yet with color-level() but some issues I raised in #30468 are related to these (.alert-light and .table-dark for example).

@ffoodd ffoodd mentioned this issue Apr 10, 2020
Closed
5 tasks
@mdo
Copy link
Member

mdo commented Oct 29, 2020

Did we normalize anything here with the move to %s for our shade/tint functions @MartijnCuppens?

@MartijnCuppens
Copy link
Member Author

Yes we did 🙌

@MartijnCuppens
Copy link
Member Author

Ow, but the color contrasts are still an issue, I remembered 😥

@mdo
Copy link
Member

mdo commented Nov 9, 2020

Believe this was closed by #32085.

@mdo mdo closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdo @ffoodd @MartijnCuppens