-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info badge colour #31749
Comments
Thanks for the issue, but please don't grab random PR URLs 😛 The v5 docs are on https://v5.getbootstrap.com/ or the main branch on https://twbs-bootstrap.netlify.app |
Noted for future! :) I have checked on the main branch just to make sure and the issue exists on there too :) |
@calvinkarpenko For your information, this is already documented here: https://v5.getbootstrap.com/docs/5.0/getting-started/accessibility/#color-contrast There are probably related issues you should find and read first to understand the rationale behind this choice before proposing to change it 😊 |
@Mx-Glitter - Thanks for the reply - I'm aware of that and was just mentioning it because it wasn't AA compliant in the docs for Alpha 2 - and figured it may have been slightly overlooked. I'm under the impression that the aim is for the docs to be AA compliant as well :) |
We are working towards this, and v5 has already many improvements. I have a WIP PR we plan to land at some point, #29315 . |
I'm well aware and have been following with interest :) I just didn't know how else to notify you of this and was under the impression it may have been missed, that's all :) |
@ffoodd don't we have another issue/PR we track this stuff already? |
This is the first time I've reported something so I'm not sure if I'm doing it in the right place or not.
I note that the new info badge doesn't provide sufficient colour contrast per AA guidelines in the V5 Alpha 2.
https://v5.getbootstrap.com/docs/5.0/components/badge/
The contrast is 1.96 apparently when used with white text as seen in the docs. I use it with black text myself, which does provide the contrast required.
So the docs either need changing or the colour needs changing :)
The text was updated successfully, but these errors were encountered: