Fix th alignment for Safari
#30323
Merged
Fix th alignment for Safari
#30323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be backported? |
ysds
approved these changes
Mar 2, 2020
ashfahan
added a commit
to fluid-framework/Fluid
that referenced
this pull request
Apr 23, 2020
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
May 3, 2020
PR for joomla#28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this
infograf768
pushed a commit
to joomla/joomla-cms
that referenced
this pull request
May 4, 2020
* [4.0] th on safari PR for #28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this * Update _reboot.scss
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* [4.0] th on safari PR for joomla#28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this * Update _reboot.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30321.
Did some tests and it seemed only Safari had issues figuring out the default text alignment.