Fix pseudo paddings and height

[MartijnCuppens]

It turns out the height of date inputs (#18842) are increased by the padding on the pseudo elements and the fixed height of 1.5rem of the ::-webkit-inner-spin-button.

I've now reset these paddings and height instead of hacking with the line-height.

Codepen to play with: https://codepen.io/MartijnCuppens/pen/wvBLzvb?editors=1100

[mdo]

Holy shit, is this really the cause of all that pain? No requirement for fixed heights on form controls now? :D

[ysds]

On iOS (Chrome/Safari) there still seems to be a problem.

[MartijnCuppens]

@ysds, do you mean this: #30353?

[ysds]

@ysds, do you mean this: #30353?

yep :)

[MartijnCuppens]

FYI, this patch is unrelated to #30353.

Holy shit, is this really the cause of all that pain? No requirement for fixed heights on form controls now? :D

Not sure about that, we got to check that in #30353. We added min-height in the end to make sure textareas don't shrink too much when the native resizer is used (#29124). This patch just resets the right properties that cause the unequal heights for text & date inputs instead of the hack I used before which worked while I had no clue why it did 😛

[ysds]

BTW should add date input example on our docs like color if we support those.

Updated: Oops I intended to comment this on #30353.

[ysds]

LGTM