-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] All backend lists use center-aligned fields #28904
Comments
Must be a very recent change that caused this |
Nope, this is actually as old as the file in the repository is. The title column is rendered everywhere as a |
That would be incorrect for accessibility reasons and others because the title is the header for the row in a horizontal direction |
We are talking about the same thing. I am using the latest Joomla 4 development branch. |
Don't know what to say @nikosdion I dont see that on the latest branch as of 5 minutes ago |
I can tell you why. I am using Safari. You are using Chrome or Firefox. The Can we please not be the victims of browser monoculture? We've tried that 20 years ago, it sucked. |
I confirm this happens with Safari, not with Firefox (Macintosh) |
Can you tell me how the alignment is on this page |
when we have |
It seems that the problem is upstream in bootstrap with a recent change to their resets. They have acknowledged and fixed it. twbs/bootstrap#30323 |
The content on https://getbootstrap.com/docs/4.4/content/tables/ looks correct: As @infograf768 said, if we were to correctly use I guess we should really be adding scope to TH elements if they're outside a THEAD. A THEAD readily implies that its TH elements are scoped to the column but a TH in a TBODY row could be anything. If the reason for using TH instead of TD is accessibility we should be explicit and be sure instead of implicit and hope for the best. Right? This is a serious question; I am trying to improve accessibility on my own stuff as well. |
We are using th scope=col and th scope=col everywhere - or at least we should be as I added it. The only place I am aware of that I didnt already check was your webauthn plugin As I stated it is a bug in bootstrap which they have fixed on their site but the fix hasnt been released yet. @wilsonge do we need to manually apply that fix? |
@brianteeman I've never used a TH inside a TBODY by my own accord, so... 🤷 |
Took me a while to get my head around it as well - but it is definitely correct |
Yeah, I thought I knew how tables work but I read the MDN page only today. I now understand the use case – and why scope is important when the TH is not inside a THEAD. Definitely noted for future reference and use. |
PR for joomla#28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this
* [4.0] th on safari PR for #28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this * Update _reboot.scss
Fixed in PR #28921 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28904. |
* [4.0] th on safari PR for joomla#28904 This is a test PR for the TH alignment issue with safari. It is a bug in bootstrap that they have fixed and merged but not released yet. See twbs/bootstrap#30323 This PR adds a _temporary_ reboot.css override with the code direct from bootstrap. I can't see any other way to fix this beta blocker. I do not have access to Safari to test this. @nikosdion please can you test this * Update _reboot.scss
Steps to reproduce the issue
Open any backend list where it's critical that the user understands its nested structure such as Menus, User Groups or Categories
Expected result
The Title field is left aligned, giving an intuitive overview of the nested structure of the listed information.
Actual result
Everything is centre-aligned, making the structure not obvious to new users and a read headache for us experienced users.
System information (as much as possible)
Not relevant to this issue.
Additional comments
The Title field – the one and only field that's centre-aligned – is also the one that needs to be immediately scannable on a long list by the person using the site. Centre alignment makes it really hard to do that.
I tried to see if this is reported before but I could not find any open issue about this.
The text was updated successfully, but these errors were encountered: