Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from qunit to jasmine #28518

Merged
merged 17 commits into from
Jul 23, 2019
Merged

Switch from qunit to jasmine #28518

merged 17 commits into from
Jul 23, 2019

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Mar 17, 2019

Things to do:

@Johann-S Johann-S force-pushed the jo-jasmine branch 2 times, most recently from 689031d to 034e303 Compare March 18, 2019 20:49
@bershanskiy
Copy link
Contributor

@Johann-S Now I see what you meant by "Bootstrap file structure changing a lot" in #27542. I would like to help moving away from jQuery, if there is a task I could tackle.

@Johann-S
Copy link
Member Author

Johann-S commented Mar 19, 2019

Hi @bershanskiy, if you're willing to help us to move away from jQuery there is a list of tasks here: #28342

And if you want to help us to move away from QUnit you can simply rewrite the unit tests of one of our plugins.
To do that you have to create one describe by methods, with one or several it in, and your PR should target this branch: jo-jasmine

@Johann-S Johann-S force-pushed the jo-jasmine branch 13 times, most recently from 5f667c4 to 514ef59 Compare March 25, 2019 14:46
@Johann-S Johann-S force-pushed the jo-jasmine branch 3 times, most recently from f2e0f87 to a81f11a Compare March 27, 2019 20:30
@bershanskiy
Copy link
Contributor

@Johann-S
One minor thing: bootstrap/js/index.esm.js and bootstrap/js/index.umd.js still have

import Carousel from './src/carousel'

which might need to updating to

import Carousel from './src/carousel/carousel'

@Johann-S
Copy link
Member Author

Thanks @bershanskiy 👍 The rewrite of the carousel is still in progress

@Johann-S Johann-S force-pushed the jo-jasmine branch 6 times, most recently from 6d30072 to e233121 Compare April 4, 2019 13:02
@Johann-S Johann-S force-pushed the jo-jasmine branch 2 times, most recently from 2f334b3 to 44ff9f3 Compare April 5, 2019 19:36
@XhmikosR XhmikosR force-pushed the jo-jasmine branch 3 times, most recently from 39cf0cb to 4cd2b0b Compare July 23, 2019 10:28
@XhmikosR XhmikosR changed the title move from qunit to jasmine Switch from qunit to jasmine Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants