-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rewrite toast unit tests #28562
Conversation
Just few notes:
When you're done with that just /CC me 😉 I'll update my branch soon, so to keep up to date you can do:
|
f2e0f87
to
a81f11a
Compare
@Johann-S Thanks for your comments. I tried to fix all the issues and squashed all commits into one, I hope it's easier to review this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It lacks of DefaultType
and Default
describe
Hi @bershanskiy, I fixed some lint error on your commit. You have one method left to test: And I'll be happy to merge your PR 👍 |
642cb93
to
ec988c4
Compare
Hi @bershanskiy I cherry picked your commit in my branch, thanks for your work 👍 |
@Johann-S Here are Toast unit tests.