Move Manipulator test cases from QUnit to Jasmine #28543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bershanskiy
changed the title
Johann-S
reviewed
Mar 22, 2019
Johann-S
requested changes
Mar 22, 2019
|
About the support of |
Johann-S
force-pushed
the
jo-jasmine
branch
2 times, most recently
from
c68cec4 to
f54aaa1
Compare
Johann-S
approved these changes
Mar 24, 2019
|
Thank you very much @bershanskiy for your work 👍 much appreciate |
21 tasks
bershanskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Johann-S Here is a small commit that rewrites
Manipulatortest cases for Jasmine. This is not for merging but instead for getting feedback on my commit.A random question:
toggleClassusesclassList.remove,classList.add,classList.contains, which according to MDN have worse support thanclassList.toggle. Is MDN wrong or does compatibility table not tell the whole story?Edit: I resolved merge conflicts for simplicity of review.