-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4: Grid redux #19099
Merged
Merged
v4: Grid redux #19099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id classes with auto layout via flex: 1
This was referenced Feb 6, 2016
…s aren't supported in Sass
This was referenced Feb 6, 2016
This was referenced Feb 6, 2016
This was referenced Feb 6, 2016
Closed
mdo
added a commit
that referenced
this pull request
Feb 7, 2016
This was referenced Feb 7, 2016
This was referenced Feb 10, 2016
mdo
added a commit
that referenced
this pull request
Feb 17, 2016
…sed for in make-grid-columns mixin
torbjoernk
added a commit
to torbjoernk/jlesc.github.io
that referenced
this pull request
Feb 23, 2016
These are mainly: - [#17194](twbs/bootstrap#17194) - [#18772](twbs/bootstrap#18772) - [#18782](twbs/bootstrap#18782) - [#19099](twbs/bootstrap#19099) - [#19102](twbs/bootstrap#19102) - [#19103](twbs/bootstrap#19103) Signed-off-by: Torbjörn Klatt <[email protected]>
I don't think v4 documentation for modifier is updated |
mdo
added a commit
that referenced
this pull request
Jul 24, 2016
- Restores two-mixin approach to generating semantic grid columns (now with 'make-col-ready' and 'make-col') - Removes need for .col-xs-12 by restoring the mass list of all grid tier classes to set position, min-height, and padding - Adds an initial 'width: 100%' to flexbox grid column prep (later overridden by the column sizing in 'flex' shorthand or 'width') to prevent flexbox columns from collapsing in lower viewports
This was referenced Jul 24, 2016
mdo
added a commit
that referenced
this pull request
Jul 27, 2016
mdo
added a commit
that referenced
this pull request
Jul 27, 2016
- More details on columns and gutters - Break it into clear sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a handful of grid changes:
.col-{breakpoint
classes. For example, use.col-xs
to create as many grid columns as you'd like fromxs
and up.Adds a newChanges the responsive grid modifier naming scheme from.col
base class for grid columns and.col-{breakpoint}-{modifier}-{size}
to.{modifier}-{breakpoint}-{size}
for simpler grid classes. For example, instead of.col-md-3.col-md-push-9
it'scol-md-3.push-md-9
. Also updates all examples to new markup.make-col
andmake-col-span
into a singlemake-col
mixin, thereby ensuring mixins and predefined classes utilize the same float/flex behaviors.Todo: