Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Tweak predefined grid classes #17261

Closed
wants to merge 2 commits into from
Closed

v4: Tweak predefined grid classes #17261

wants to merge 2 commits into from

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 24, 2015

Changes the approach for the grid classes from this:

<div class="col-sm-9 col-push-sm-9"></div>

to something a bit more succinct:

<div class="col col-sm-9 push-sm-9"></div>

The motivation for this was primarily to shorten class names if we went with fractional classes (e.g., .col-sm-1-3) so we don't end up with something like .col-push-sm-1-3 and the like. Haven't leaned into the fractional stuff yet though to explore that.

/cc @twbs/sass

@cvrebert
Copy link
Collaborator

@mdo X-Ref: #17228

@mdo mdo mentioned this pull request Dec 8, 2015
17 tasks
@mdo mdo mentioned this pull request Feb 6, 2016
1 task
@mdo
Copy link
Member Author

mdo commented Feb 6, 2016

Coming in #19099.

@mdo mdo closed this Feb 6, 2016
@mdo mdo added this to the v4.0.0-alpha.3 milestone Feb 6, 2016
@mdo mdo deleted the v4-grid-classes branch June 15, 2017 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants