v4: Flex utilities instead of flex grid classes? #18785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps |
|
|
||
| // Flex column reordering | ||
|
|
||
| @each $breakpoint in map-keys($grid-breakpoints) { |
There was a problem hiding this comment.
Let's merge the three loops/includes into one, because it compiles to fewer media queries and is easier to read.
|
👍, these utility classes are definitely useful outside of the grid. |
|
Cherry-picked into #19099. Will add suggested changes and docs there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we make the grid-based flex alignment classes available for all flexbox implementations instead of limiting them to just the grid? Names aren't exact, but something like this feels like it'd be of more use to more folks outside just the grid.
Thoughts?