Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab plugin should use a class selector instead of a ul tag selector #17754

Closed
Invis1ble opened this issue Oct 1, 2015 · 4 comments
Closed

Tab plugin should use a class selector instead of a ul tag selector #17754

Invis1ble opened this issue Oct 1, 2015 · 4 comments
Labels
confirmed js v4

Comments

@Invis1ble
Copy link

Hello. I want to use <ol> instead of <ul>, but in the Tab plugin tag name is hardcoded.
https://github.com/twbs/bootstrap/blob/master/js/tab.js#L28

var $ul      = $this.closest('ul:not(.dropdown-menu)')
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 1, 2015

I want to use <ol> instead of <ul>

Why?

@cvrebert cvrebert changed the title Tag name hardcoded Tab plugin only works with <ul>, not <ol> Oct 1, 2015
@Invis1ble
Copy link
Author

Because I have an ordered list.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 1, 2015

Because I have an ordered list.

And you have an ordered list because...?

@cvrebert cvrebert changed the title Tab plugin only works with <ul>, not <ol> Tab plugin should use a class selector instead of a ul tag selector Oct 1, 2015
@Invis1ble
Copy link
Author

And you have an ordered list because...?

Because it is an ordered dataset from database and it should be displayed as an orderd list of tabs. It is semantic, isn't it?

daleparkerwinston added a commit to daleparkerwinston/bootstrap that referenced this issue Oct 15, 2015
@daleparkerwinston
Fixed issue twbs#17754
13940c7 
Updated js/tab.js to work with <ol> along with <ul>
daleparkerwinston added a commit to daleparkerwinston/bootstrap that referenced this issue Oct 15, 2015
@daleparkerwinston
Fixed issue twbs#17754
fc0ba27 
Updated js/tab.js to be able to work with <ol> as well as <ul>.
daleparkerwinston added a commit to daleparkerwinston/bootstrap that referenced this issue Oct 15, 2015
@daleparkerwinston
Fixed issue twbs#17754
e0416e4 
Updated tab.js to be able to work with <ol> as well as <ul>.
@daleparkerwinston daleparkerwinston mentioned this issue Oct 15, 2015
Closed
@cvrebert cvrebert mentioned this issue Mar 9, 2016
Closed
@nimmolo nimmolo mentioned this issue Mar 12, 2016
Closed
maxbeatty added a commit to maxbeatty/bootstrap that referenced this issue Aug 4, 2016
@maxbeatty
add support for ol in tab plugin. fixes twbs#17754
dc1b4e7
@maxbeatty maxbeatty mentioned this issue Aug 4, 2016
Merged
@mdo mdo closed this as completed Sep 5, 2016
@mdo mdo removed the v3 label Sep 5, 2016
@mdo mdo reopened this Sep 5, 2016
@mdo mdo mentioned this issue Oct 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdo @cvrebert @Invis1ble