-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with tabs plugin #18694
Comments
Please post a JS Bin or JS Fiddle that demonstrates the problem. |
As it said on the error console tab doesn't have To hide a tab you just have to show an other one |
Uncaught Error: No method named "hide"
Works fine when implemented according to the docs: |
@cvrebert You're right, tabs do work fine when implemented exactly according to docs but i'm still trying to understand why Bootstrap nav classes are necessary to the markup. Does tab.js need the Bootstrap nav classes? I can't see that it does when reading through the script. It seems the Bootstrap nav classes were all @AustinWinstanley was missing, and when I add them, his jsfiddle works. Why do the nav classes make it work? The question came up for me on a development site, I have tabs working without nav markup on two different pages, but on the third i'm running into the exact same behavior as his Dec. 26 jsfiddle. Without Bootstrap nav classes you can tab to Tab-2 but relatedTarget (i.e. the previous tab) is not hidden. You can't go back to Tab-1 from Tab-2, and Tab-1 is not itself hidden when you go to Tab-2. update: ah, there is another acknowledged and resolved issue involved in my development site, the selector has to be in an |
Certainly that's the only usage which we officially support; you're on your own otherwise. We'll be relying on the nav classes more once #17754 gets fixed. |
Thanks @cvrebert - The OP's issue is still a mystery to me as tab.js is only selecting for |
Hide doesn't exist and 'Active' class isn't removed from previous links.
Previous working (now broken) code:
Working Workaround code:
The text was updated successfully, but these errors were encountered: