add support for ol in tab plugin #20467
Conversation
| @@ -76,6 +76,22 @@ $(function () { | |||
| assert.strictEqual($('#qunit-fixture').find('.active').attr('id'), 'home') | |||
| }) | |||
|
|
|||
| QUnit.test('should activate element by tab id in ordered list', function (assert) { | |||
| assert.expect(2) | |||
| var pillsHTML = '<ol class="pills">' | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
|
Anyone have feedback on the Hound errors here? Would love to unblock this PR and get it merged. |
|
It seem's Hound prefer ES6 JavaScript and it's happened in others PR, I think we should allow ES5 in our JS Units in Hound |
|
@mdo, it's all green. Hound is just mad again. It's the issue we discussed today about the tests being es5. |
|
I tried to fix similar hound violations in #20174 and found that phantomjs needs to be updated before the unit tests can follow the styleguide |
|
@maxbetty, see, the tests need to be es5 because they need to run on non-es6 browsers, so we can either transpile them (more tooling and complexity) or leave them as es5. The linter just needs to be fixed, something that I'm working on. This PR is good to go. |
fixes #17754 by applying #17933 to v4