Exclude virtualenvs vers w/ regressions 20.0.[0-7] #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
reviewed
Mar 16, 2020
| @@ -43,7 +43,7 @@ install_requires = | |||
| pluggy >= 0.12.0, <1 | |||
| py >= 1.4.17, <2 | |||
| six >= 1.14.0, <2 # required when virtualenv>=20 | |||
| virtualenv >= 16.0.0 | |||
| virtualenv >= 16.0.0, !=20.0.0, !=20.0.1, !=20.0.2, !=20.0.3, !=20.0.4, !=20.0.5, !=20.0.6, !=20.0.7 | |||
There was a problem hiding this comment.
Why is this needed? Shouldn't install just pick the latest?
There was a problem hiding this comment.
additionally, though each of these have bugs they "work" for the 95-99% case and it's probably not helpful to exclude it for those already using those versions
There was a problem hiding this comment.
It'll only install latest if no existing virtualenv is present. So if you do pip install tox and there's virtualenv==20.0.2 there, it'll not upgrade it because it matches the requirement.
There was a problem hiding this comment.
I can't think of a better solution atm
6 tasks
gaborbernat
reviewed
Mar 21, 2020
|
released via https://pypi.org/project/tox/3.14.6/ |
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
* Exclude virtualenvs vers w/ regressions 20.0.[0-7] * Add a change fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenv 20 series has had a number of regressions. This PR explicitly excludes versions with known issues that are hard to debug.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)