Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude virtualenvs vers w/ regressions 20.0.[0-7] #1537

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Exclude virtualenvs vers w/ regressions 20.0.[0-7] #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa869d
Exclude virtualenvs vers w/ regressions 20.0.[0-7]
webknjaz Mar 16, 2020
24f18d9
Add a change fragment
webknjaz Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog/1537.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Exclude virtualenv depencency versions with known
regressions (20.0.[0-7]) - by :user:`webknjaz`.
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ install_requires =
pluggy >= 0.12.0, <1
py >= 1.4.17, <2
six >= 1.14.0, <2 # required when virtualenv>=20
virtualenv >= 16.0.0
virtualenv >= 16.0.0, !=20.0.0, !=20.0.1, !=20.0.2, !=20.0.3, !=20.0.4, !=20.0.5, !=20.0.6, !=20.0.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Shouldn't install just pick the latest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally, though each of these have bugs they "work" for the 95-99% case and it's probably not helpful to exclude it for those already using those versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll only install latest if no existing virtualenv is present. So if you do pip install tox and there's virtualenv==20.0.2 there, it'll not upgrade it because it matches the requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a better solution atm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 you're right

toml >=0.9.4
filelock >= 3.0.0, <4
colorama >= 0.4.1 ;platform_system=="Windows"
Expand Down