Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tox --help and tox --help-ini shows an error when run outside a directory with tox support files #1509 #1540 #1539

Merged
merged 5 commits into from
Mar 22, 2020
Merged

Fix tox --help and tox --help-ini shows an error when run outside a directory with tox support files #1509 #1540 #1539

merged 5 commits into from
Mar 22, 2020

Conversation

nkpro2000sr
Copy link

@nkpro2000sr nkpro2000sr commented Mar 20, 2020 •
edited
Loading

closes #1509, closes #1540

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

gaborbernat
gaborbernat requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tox -e fix_lint to fix the formatting issue; also add a test to validate the change.

@nkpro2000sr nkpro2000sr requested a review from gaborbernat March 20, 2020 14:27
gaborbernat
gaborbernat requested changes Mar 20, 2020
View reviewed changes
docs/changelog.rst Outdated Show resolved Hide resolved
src/tox/config/__init__.py Outdated Show resolved Hide resolved
@nkpro2000sr nkpro2000sr requested a review from gaborbernat March 20, 2020 17:21
gaborbernat
gaborbernat reviewed Mar 20, 2020
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly to merge this we need first to fix the CI on master; can you put in a PR that does that? Would imply finding out why the master is broken and putting in a separate PR that fixes it.

@nkpro2000sr
Copy link
Author

I have a doubt that my docs/changelog/1539.bugfix.rst is in correct format ?

@nkpro2000sr nkpro2000sr reopened this Mar 20, 2020
@nkpro2000sr
Copy link
Author

nkpro2000sr commented Mar 20, 2020 •
edited
Loading

I don't know why it failed in pypy linux. It also failed with same error

pypy linux - generate tox test environment
Bash exited with code '1'

alos in another PR #1537
but in both 0 test failed

😕 Error log

@nkpro2000sr nkpro2000sr requested a review from gaborbernat March 20, 2020 19:32
@nkpro2000sr nkpro2000sr changed the title Fix tox --help shows an error when run outside a directory with tox support files #1509 Fix tox --help and tox --help-ini #1540 shows an error when run outside a directory with tox support files #1509 #1540 Mar 21, 2020
@nkpro2000sr nkpro2000sr changed the title Fix tox --help and tox --help-ini #1540 shows an error when run outside a directory with tox support files #1509 #1540 Fix tox --help and tox --help-ini shows an error when run outside a directory with tox support files #1509 #1540 Mar 21, 2020
gaborbernat
gaborbernat reviewed Mar 21, 2020
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is on hold until we fix the master CI.

@nkpro2000sr
solved CI error
c84c006 
the problem is with psutil==5.7.0 in pypy .
@nkpro2000sr
solved lint problem 😖
69dd71a
@nkpro2000sr nkpro2000sr requested a review from gaborbernat March 21, 2020 18:28
nkpro2000sr
nkpro2000sr commented Mar 21, 2020
View reviewed changes
tox.ini Show resolved Hide resolved
@nkpro2000sr
Copy link
Author

This PR is on hold until we fix the master CI.

Finally, all test passed 😺

@gaborbernat gaborbernat merged commit 537f26c into tox-dev:master Mar 22, 2020
@gaborbernat
Copy link
Member

released via https://pypi.org/project/tox/3.14.6/

stratakis added a commit to stratakis/tox-venv that referenced this pull request May 13, 2020
@stratakis
Fix test_notoxini_help_still_works with tox v3.14.6
3854a7d 
Since tox version 3.14.6 test_notoxini_help_still_works
from test_z_cmdline.py fails due to tox-dev/tox#1539

Sync the tests from that tox version to fix the issue.
@stratakis stratakis mentioned this pull request May 13, 2020
Closed
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
@nkpro2000sr @nkengr @ssbarnea
Fix tox --help and tox --help-ini shows an error when run o… (tox…
7df3277 
…-dev#1539)

* solved tox-dev#1509 tox-dev#1540

* added test for fixed help command

* added changelog

* solved CI error

the problem is with psutil==5.7.0 in pypy .

* solved lint problem 😖

Co-authored-by: nkpro2000sr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
3 participants
@nkpro2000sr @gaborbernat @nkengr