Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1822CA checklist #9376

Closed
65 of 71 tasks
michaeljb opened this issue Aug 11, 2023 · 8 comments · Fixed by #10106
Closed
65 of 71 tasks

1822CA checklist #9376

michaeljb opened this issue Aug 11, 2023 · 8 comments · Fixed by #10106
Assignees
Labels
1822CA new games Issues relating to games that are not yet alpha test level

Comments

@michaeljb
Copy link
Collaborator

michaeljb commented Aug 11, 2023

Alpha blockers (last updated November 30)

  • GNWR and NTR destn hexes are explicit city slots. GNWR is the north edge slot, NTR is the SE
  • [game 13, WRS] autopass was pressed in SR3 for a player during the auction, but the auction came back around and the player as not autopassed. A Major was started, so this is actually WAI
  • [game 16, ERS] trying to lay tile Q1 in Quebec in OR3.1. getting an "undefined method. exchange token for nil" error. it was finicky. had to place the QMOO home token in the same location reserved for M5, and then was able to place the Q1 tile
    • if QMOO's home is different from M5's, maybe it needs to become a pending token again when a yellow tile is laid instead of it automatically going to one of the new cities
  • [game 17, WRS] SR6 - $0 bids on privates disappearing
  • [game 17, WRS] OR 7.1 - GNWR incorrectly prompted about choosing home (related to 18's home being different in WRS than in full game)
  • [game 18, full game] OR 8.2 - ICR upgrades Montreal to gray (but only when paying for it instead of using P16) and then appears to have no available_hexes for running routes (ie all hexes are dimmed and not selectable)
  • [game 19, full game] P21 3-Tile Grant "The National Dream" should be able to lay tiles on Y cities
  • [game 21, ERS] infinite recursion error while computing sawmill bonus

I skimmed the 1822CA rulebook and made this checklist mainly from the rules differences section highlighted in red. It looks like just the basic scaffolding/setup is implemented so far.

Terms defined differently in 1822CA rulebook vs 18xx.games code, such as "city", will use the 18xx.games code definition here.

I'm thinking I'll start by getting the Eastern Regional Scenario playable first, then the Western scenario, and then the full game.

Any changes that are checked here but aren't merged in are pushed to a branch at https://github.com/michaeljb/18xx.games/branches.

Rules Differences (red text in rulebook)

New/Changed Private Companies

Other privates equivalent to privates implemented for 1822, some work may still be needed to "wire" them up correctly.

ERS

  • P5-P6 Pullman (train becomes N+2N instead of N+inf)
  • P11 Tax Haven (can buy shares; should also add this as optional rule to 1822)
  • P13 Sawmill Bonus
  • P14-P18 Free Upgrades
  • P25 Small Mail Contract

WRS

  • P19-P20 Yellowhead/Crowsnest Pass
  • P26-P27 Grain Trains

Full Game Only

  • P10 Winnipeg Station - teleport, add one slot to one city
  • P21 3-Tile Grant

Toronto and M13

  • M13 must pay $20 to place its home station; this counts as its track laying step; it adds a slot to the city it chooses
  • after M13 is acquired, if the token is not used by the Major, the slot opens up for other Majors to use
  • acquiring M13 from the bid box costs an additional $20 for the token

Operating Rounds

Tokens

  • may have a token on each different city on the same hex, but if the cities merge when upgraded, one returns to "available" section on the charter

Destination Tokens

  • GNW and NTR must reach specific city, not just the hex, to destinate
  • ICR does not need to reach a specific city in Quebec to destinate, but when it does, it must place its destination token in a city it does reach

Routes

  • no hitting different cities on one hex with a train, but may trace the route that way for connectivity
  • Duluth-Detroit is closed until phase 3 (full game only)
  • pullman/grain/port bonuses (WRS + full game)

Acquisitions

  • when a Major acquires a Minor, it gets a bonus yellow tile lay or upgrade; still may not lay on the same hex twice in one turn; cannot use a private company ability here

Game End

  • if the bank breaks during an OR, finish the set and play an additional OR. Finish these ORs even if the game end value on the stock market is reached

Eastern and Western Regional Scenarios

  • different private/minor/major selections for each scenario
    • WRS: new homes for M16-M19
    • WRS: no fixed first minor
  • special hexes for T10-T16
  • no Duluth-Detroit link
  • Game End conditions:
    • stock market end during OR => end of OR
    • stock market end from sold out during SR => end of OR X.1
    • bank breaks during SR => end of OR X.1
    • bank breaks during OR => end of OR X.2 (no extra OR); finish these even if stock market end is reached
  • 2p rules at https://boardgamegeek.com/thread/2591186/1822ca-2-player-scenarios
    • different private companies
    • price drops only on director sales

Display Issues

  • stock market movement shown on Market tab
    • selling shares should reflect the code value of SELL_MOVEMENT = :left_per_10_if_pres_else_left_one instead of saying down for every share
    • sold out should be right instead of up

Tile Rendering

  • Duluth (P18) - name/revenue strip clash
  • Ottawa (AE15) - name clashing with upgrade cost
  • Vancouver (C15) - destinations and port icon are obscured by revenue strip
  • Winnipeg (N16) - destination clashing with home reservation

Other

  • P29/30 Remove Town privates should not be able to remove the P13 Sawmill town
  • combo_entities for private abilities which can be used together
  • Probable Sawmill bugs
    • only one train per turn should get bonus
    • bonus should be doubled by destination and E-trains
  • QMOO's home should be initially tied to the hex, not a specific city
  • Advanced Tile Lay is not working right now
  • abilities that require full tile action are still visible after doing some normal tile lays
  • Windsor-Detroit connection (2 lanes to 1) is not working properly
  • If a destination token and regular token are on the same hex and join up, ensure the regular token is the one sent back to the charter

feedback from Bob

  • no currency symbol for upgrades on map
  • show revenue icon for all cities on "big city" tiles
  • fix labels overlapping with other tile parts, especially on W

playtest feedback

game 12 - ERS

  • should probably have a note on the INFO page to describe the cost of the L upgrade
  • trying to place M12's home station into the GT location, game throws an error message "undefined method for neighbors for nil". same for M12's home location. (even if toronto tile is upgraded first, it still throws the error)

game 13 - WRS

  • M18 only lists the starting city as R16, needs name, also M19 M16

  • Prince Albert is M23's home, not Regina. (it has the 23 off to the side in the Regina hex)

  • NTR and M19 in play. NTR goes to play a tile and it throws an error. "undefined method include for Nil"

  • P26 text has the phrase "route route"

game 16 - ERS

  • M19 is permitted to upgrade Montreal to brown. it should not be permitted
  • GWR trying to use bonus tile upgrade on Hamilton to grey. merged in minor 16. it was not allowed
  • Privates that upgrade the major cities MOQTW still show the ability as active even when the associated tile is already maxed out at grey. in this case Quebec

game 18

  • OR9.1 - CNoR wanted to put the sawmill bonus into Kamloops. but when it did it was prevented from running a route through to Vancouver. removing the token and the route was valid. having the token it was not. i tried a few combinations, but anytime that token was on kamloops i was unable to select that city to include in a route, not even as a terminus
@michaeljb michaeljb added the new games Issues relating to games that are not yet alpha test level label Aug 11, 2023
@michaeljb michaeljb self-assigned this Aug 11, 2023
@scottredracecar
Copy link
Collaborator

scottredracecar commented Aug 11, 2023 via email

@JEBrosius
Copy link

The grain elevator locations also have effects when run by non-grain trains. See the table in Rule 5.11.27 and in particular the column for Normal Trains.

@scottredracecar
Copy link
Collaborator

For this one, I believe 1822MX had to solve this already.
may have a token on each different city on the same hex, but if the cities merge when upgraded, one returns to "available" section on the charter

@michaeljb
Copy link
Collaborator Author

For this one, I believe 1822MX had to solve this already.

may have a token on each different city on the same hex, but if the cities merge when upgraded, one returns to "available" section on the charter

Sadly no... #9494

@ollybh ollybh added the 1822CA label Sep 30, 2023
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Oct 14, 2023
Fixes issue in 1822CA with the "major city upgrade" privates being usable by
minors to upgrade Montreal/etc. to brown and gray. tobymao#9376

Now includes actual validation, so pins will be needed.
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
1822CA introduces destination tokens that are specific to cities and slots,
rather than just the hexes, as seen in other 1822 games.

This will make it clear which city needs to be hit for the destination to be
complete. Icons in city slots also count as reservations, meaning other
corporations may not token there.

[tobymao#9376]
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
1822CA introduces destination tokens that are specific to cities and slots,
rather than just the hexes, as seen in other 1822 games.

This will make it clear which city needs to be hit for the destination to be
complete. Icons in city slots also count as reservations, meaning other
corporations may not token there.

[tobymao#9376]
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
1822CA introduces destination tokens that are specific to cities and slots,
rather than just the hexes, as seen in other 1822 games.

This will make it clear which city needs to be hit for the destination to be
complete. Icons in city slots also count as reservations, meaning other
corporations may not token there.

[tobymao#9376]
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
1822CA introduces destination tokens that are specific to cities and slots,
rather than just the hexes, as seen in other 1822 games.

This will make it clear which city needs to be hit for the destination to be
complete. Icons in city slots also count as reservations, meaning other
corporations may not token there.

[tobymao#9376]
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Dec 30, 2023
…per train

Fixes issue where a company could have one train but collect bonuses from both
the small and large mail contracts. tobymao#9376
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Jan 6, 2024
…oncessions

Move `init_companies` from `g_1822_ca_wrs/game.rb` into `g_1822_ca/scenario.rb`
so ERS can use it as well, so the corporations with a different home/dest in the
scenarios can have their concession description updated as well.

Closes tobymao#9376
michaeljb added a commit to michaeljb/18xx.games that referenced this issue Jan 6, 2024
…oncessions

Move `init_companies` from `g_1822_ca_wrs/game.rb` into `g_1822_ca/scenario.rb`
so ERS can use it as well, so the corporations with a different home/dest in the
scenarios can have their concession description updated as well.

Closes tobymao#9376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1822CA new games Issues relating to games that are not yet alpha test level
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants