[1822Africa] Fix share movement on issue

[vandamm]

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

When issuing shares stock price only moved left one step regardless of the number of shares issues.
Correct behavior is to move one step per share issues.

This change may break existing games if they had share issuing

[scottredracecar]

@michaeljb this is how it works in 1822CA too in case you have not modified this from base 22. It's correctly done in 1822MX already.
#9376

Rule from MX is (should be same as CA):
A major company may either issue or redeem its own stock, but not both in one turn. Issued stock is transferred from the company
treasury to the bank pool. Issuing stock causes the company’s price to move one step left per 10% share issued. The company
receives from the bank the final resting price, after dropping the price for each 10% share sold. Issuing stock must not cause more
than 50% of the stock to be in the bank pool. If the token moves to a space on the stock market which is already occupied, it is placed
at the bottom of the pile; if the token was already on the left-most space of the stock market, it keeps its relative position in a pile.

[michaeljb]

Thanks for the tip @scottredracecar! Fixed for CA in #9472.

[michaeljb]

Now 1822CA, 1822MX, 1822PNW, and 1822Africa can all have this same class duplicated...this is certainly one area making a strong case for me to pursue my idea of creating a new abstract game class, G1822Base, which all the 1822 games could inherit from so that the derivative games could stop overriding things that are specific to 1822 Great Britain.

Actually that abstract game class pattern would be good to apply to 1846 as well, would likely help smooth some things over when it comes time to do 1833NE.

[scottredracecar]

That is a great idea. For my 1852 Missouri game, I needed to override a bunch of special rules from 1846 (steamboat symbols on setup, etc). I followed the model of 18LA to help figure out what I needed to override and duplicate those overrides. A generic G1846Base would be a better way to do that.

…

On Fri, Aug 25, 2023 at 10:13 PM Michael Brandt ***@***.***> wrote: Now 1822CA, 1822MX, 1822PNW, and 1822Africa can all have this same class duplicated...this is certainly one area making a strong case for me to pursue my idea of creating a new abstract game class, G1822Base, which all the 1822 games could inherit from so that the derivative games could stop overriding things that are specific to 1822 Great Britain. Actually that abstract game class pattern would be good to apply to 1846 as well, would likely help smooth some things over when it comes time to do 1833NE. — Reply to this email directly, view it on GitHub <#9468 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG6CEXHSVTAW3AQUMWFPNRDXXGAV5ANCNFSM6AAAAAA37ASHD4> . You are receiving this because you were mentioned.Message ID: ***@***.***>