[1822 family] don't break rendering on bidding due to player debt #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of bid-related rendering depends on `bid` appearing as one of the step's current actions, e.g., https://github.com/tobymao/18xx/blob/0bad615d8eda50db7bb2885ebdb9f94da2863fea/assets/app/view/game/round/stock.rb#L356 This causes a bug where if one player has debt (and therefore does not have the `bid` action available), previous bids and bid tokens can fail to render. This change makes `bid` always included in the possible actions, and raises a `GameError` to prevent indebted players from actually making bids.
michaeljb
added a commit
to michaeljb/18xx.games
that referenced
this pull request
Nov 27, 2023
…ering" This reverts commit 788f62c, reversing changes made to 21263d8. This probably fixes tobymao#9946 and tobymao#9947
michaeljb
added a commit
that referenced
this pull request
Nov 27, 2023
Revert "Merge pull request #9938 from michaeljb/1822-debt-rendering"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of bid-related rendering depends on
bidappearing as one of the step's current actions, e.g.,18xx/assets/app/view/game/round/stock.rb
Line 356 in 0bad615
This causes a bug where if one player has debt (and therefore does not have the
bidaction available), previous bids and bid tokens can fail to render.Screenshot 1 - JFParadis has made bids on 3 privates, no bid is visible on P6 (Pullman) -- the other privates are rendered below the screen:
Screenshot 2 - no bids shown on the other two privates, bid token count is not listed for any of the players; note that jonathan has a loan
This change makes
bidalways included in the possible actions, and raises aGameErrorto prevent indebted players from actually making bids.#9376