Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

[upstream] Get us back to upstream master(f93c96c) #136

Merged
merged 536 commits into from
Aug 5, 2019

Conversation

brirams
Copy link

@brirams brirams commented Jul 31, 2019

Overview

We'd like to get back to tracking upstream master but also have a commit that we care about that is already included in tinyspeck so this does the following:

$ git checkout slack-vitess-2019-04-02.r0
$ git checkout -b slack-vitess-2019-07-31.r0
$ git push origin head
$ git checkout -b bramos_force_upstream_f93c96c
$ git merge f93c96c738d7d5bbbcdc03c828f8bf0a5ba16250

The list of commits generated yesterday is still relevant:

git log bf603d53ce1593b46d6a93fc756ed1d682b39eb0...f93c96c738d7d5bbbcdc03c828f8bf0a5ba16250 --name-only > commits.txt

I pored through these commits to grab the most relevant ones, ignoring changes to:

  • docs
  • examples
  • helm/docker configs
  • tests and test data
  • tracer plugins

There are a lot left over(286 commits) but I think it's much easier to eyeball this way.

Testing

https://jenkins.tinyspeck.com/job/slack-vitess/346/

demmer and others added 30 commits May 30, 2019 20:15
Add a flag -querylog-filter-tag to only emit query logging
for queries that contain the specified string.

Signed-off-by: Michael Demmer <[email protected]>
Fix how we set passwords in integ tests to work for different versions
of mysql

Signed-off-by: deepthi <[email protected]>
add optional tag-based filtering for query logging
The DbName function for the local cluster was returning an
incorrect name previously. It was the keyspace name, which would
not match the db names in mysql. The previous fix stopped using
DbName for setting the mysql parameters, which broke some tests.

The new behavior fixes DbName to return a value only if it was
in OnlyMySQL mode.

Signed-off-by: Sugu Sougoumarane <[email protected]>
xtrabackup in percona image + mysql56 integration test fixes
Don't return an error for CONN_ATTR (just log)
Add `-keep_logs_by_mtime` flag for purging old log files by mtime instead of ctime + bugfix
If the table has authoritative column list, use it to auto-expand
insert columns if they were not supplied.

Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
* change topo_implementation default value

Signed-off-by: Win-Man <[email protected]>

* change the default value of topo_implementation to empty
The lag value can lie. Also we're guaranteed to hit the snapshot
position eventually as long as replication is making progress. If our
goal is a lag value, we may never catch up if replication is slower than
the rate of new transactions on the master.

Signed-off-by: Anthony Yeh <[email protected]>
fix bug in vttablet startup script when '--enable-grpc-static-auth' f…
Signed-off-by: Sugu Sougoumarane <[email protected]>
ethan and others added 21 commits July 26, 2019 13:41
correct message for easy understanding.

Signed-off-by: ethan <[email protected]>
* Do not deprecate old metrics.
* Improve name of route Table -> TableName
* Improve name of Primitive TableName -> GetTableName
* Do not join keyspace names in join primitive if it's the same name

Signed-off-by: Rafael Chacon <[email protected]>
…keyspace

 Adds table and keyspace name to v3 processed queries
…k2_for_vagrant

[vagrant-scripts] Set TOPO environment variable to use zookeeper
cleanup: error message word correction
cleanup: correct word mis-spell in error msg
 Keep the lowest cost vindex for each column if there are multiple ones
…uilder-colname

Fix table_plan_builder to correctly use formatted column names that escape keywords
…ws-processed

Fix off-by-1 error for row_differ counting rows processed, not counting empty iteration.
…ePool-typo

fixed typo in pools.NewResourcePool docs comments
vtgate: warning threshold for in-memory rows
Makefile: expose VT_EXTRA_BUILD_FLAGS for use of external build systems
Signed-off-by: Alex Charis <[email protected]>
…ding-workflow-consistent-snapshot

Enable vitess horizontal resharding workflow to use consistent snapsh…
@brirams brirams changed the base branch from slack-vitess-2019-04-02.r0 to slack-vitess-2019-07-31.r0 July 31, 2019 19:56
@brirams brirams force-pushed the bramos_force_upstream_f93c96c branch from 76ad1c6 to 36d71ca Compare July 31, 2019 23:32
@brirams brirams changed the title [upstream] Get us back to upstream master(f93c96c) plus a cherry pick [upstream] Get us back to upstream master(f93c96c) Jul 31, 2019
@rafael
Copy link

rafael commented Aug 1, 2019

These ones I think we should keep an eye:

Copy link

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brirams
Copy link
Author

brirams commented Aug 5, 2019

Going to do the following so we can force a new master:

git checkout tinyspeck/master
git tag slack-vitess-2019.08.04
git reset --hard slack-vitess-2019-07-31.r0
git push -f origin HEAD:master

@brirams brirams merged commit e983049 into slack-vitess-2019-07-31.r0 Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.