add basedir when starting mysqld #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#4992 Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
sougou
approved these changes
Jul 15, 2019
frew
reviewed
Jul 27, 2019
| arg := []string{ | ||
| "--defaults-file=" + cnf.path} | ||
| "--defaults-file=" + cnf.path, | ||
| "--basedir" + mysqlBaseDir, |
There was a problem hiding this comment.
Thanks! It will be fixed in #5027
morgo
added a commit
to planetscale/vitess
that referenced
this pull request
Jul 27, 2019
Signed-off-by: Morgan Tocker <[email protected]>
deepthi
added a commit
that referenced
this pull request
Jul 27, 2019
Fix regression introduced by #4993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mysqlctldoes not always specify the basedir when launching mysqld (it does when launching to initialize a datadir, but not for launching mysqld afterward).This can lead to cases where the plugindir cannot be discovered, and plugins cannot be loaded.
Fixes #4992
Signed-off-by: Morgan Tocker [email protected]