commit c6bd9932746fdd985813fff8a7c9aa0a96d43cac Author: Alex Charis Date: Mon Jul 29 23:33:40 2019 -0400 fix readVariableInt; add test Signed-off-by: Alex Charis go/mysql/binlog_event_json.go go/mysql/binlog_event_json_test.go commit 70737a1666a3ac37ef99d5cadfda6116ee530390 Author: Morgan Tocker Date: Fri Jul 26 18:22:12 2019 -0700 Fix regression introduced by #4993 Signed-off-by: Morgan Tocker go/vt/mysqlctl/mysqld.go commit e6f206465d89f595d9b022a568ad14139460a1cd Author: Mingjian Liu Date: Thu Jul 25 15:16:38 2019 -0700 Keep the lowest cost vindex for each column if there are multiple ones Signed-off-by: Mingjian Liu go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/planbuilder/testdata/vindex_func_cases.txt commit 35abf59f6afe0fb215e2b7ccfb5631fdd3f89284 Author: Rafael Chacon Date: Fri Jul 26 10:03:13 2019 -0700 Improvements per code review * Do not deprecate old metrics. * Improve name of route Table -> TableName * Improve name of Primitive TableName -> GetTableName * Do not join keyspace names in join primitive if it's the same name Signed-off-by: Rafael Chacon go/vt/vtgate/engine/delete.go go/vt/vtgate/engine/fake_primitive_test.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/join.go go/vt/vtgate/engine/limit.go go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/engine/pullout_subquery.go go/vt/vtgate/engine/route.go go/vt/vtgate/engine/subquery.go go/vt/vtgate/engine/update.go go/vt/vtgate/engine/vindex_func.go go/vt/vtgate/executor.go go/vt/vtgate/planbuilder/from.go commit 8b5ef8e0259c46bae288413e1926bf93a1cfda95 Author: ethan Date: Fri Jul 26 14:01:55 2019 +0800 cleanup: error message word correction correct message for easy understanding. Signed-off-by: ethan go/vt/vttablet/tabletmanager/vreplication/vcopier.go commit 3a7d536447571affc08d6756d6cc5d47f4945e87 Author: ethan Date: Fri Jul 26 13:41:24 2019 +0800 cleanup: correct word mis-spell in error msg Signed-off-by: ethan go/vt/vtgate/planbuilder/select.go commit 3e877e45d15a530c0012718add1c933edeacdd9a Author: Rafael Chacon Date: Thu Jul 25 17:20:11 2019 -0700 Refactor approach to have simpler primitives * Have one method for keyspace and for table. * Do not maintain an array. Instead, concatenate strings when there are multiple keyspace/tables in a plan. Signed-off-by: Rafael Chacon go/vt/vtgate/engine/delete.go go/vt/vtgate/engine/fake_primitive_test.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/join.go go/vt/vtgate/engine/limit.go go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/engine/pullout_subquery.go go/vt/vtgate/engine/route.go go/vt/vtgate/engine/subquery.go go/vt/vtgate/engine/update.go go/vt/vtgate/engine/vindex_func.go go/vt/vtgate/executor.go commit 81aa68615fb96c38341c240956ea398403464dcf Author: Rafael Chacon Date: Thu Jul 25 15:39:45 2019 -0700 Update tests due to changes in upstream Signed-off-by: Rafael Chacon go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/testdata/memory_sort_cases.txt commit d0400ff19bbc62b554451726bfb6e818b0f25d8d Author: Alex Charis Date: Thu Jul 25 17:45:21 2019 -0400 Makefile: expose VT_EXTRA_BUILD_FLAGS for use of external build systems Signed-off-by: Alex Charis Makefile commit aa0e4631e76312fb060679626b9642fb2812dfde Author: Sugu Sougoumarane Date: Thu Jul 25 14:42:16 2019 -0700 vreplication: tests for handling keyword names A few more fixes were needed, and I've now added more tests. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go commit 345c9f5ddd04058f50b0114230d387396645167f Author: Toliver Jue Date: Fri Jul 26 00:08:29 2019 +0700 Fix table_plan_builder to correctly use formatted column names that escape keywords Signed-off-by: Toliver Jue go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go commit e077a7e5ec2bc4da2d5232c49340226fb955263e Author: Toliver Jue Date: Wed Jul 24 16:43:25 2019 +0700 Fix off-by-1 error for row_differ counting rows processed Signed-off-by: Toliver Jue go/vt/worker/row_differ.go commit 879b190e57519520a8c6a81f4d54f8fbe4f52c7d Author: Enrique Bris Date: Mon Jul 22 15:24:41 2019 -0400 fixed typo in pools.NewResourcePool docs comments Signed-off-by: Enrique Bris go/pools/resource_pool.go commit dc09b7b94c13652a25892c9c8f2a93fa4a09e063 Author: Sugu Sougoumarane Date: Sat Jul 20 17:09:34 2019 -0700 vcopier: use ticker instead of timer The vcopier was using a timer instead of a ticker in its wait loop which caused it to wait forever even if the replication had caught up. The change includes a new test that tests the full copy cycle and ensures that multiple iterations succeed. A similar incorrect usage was found in logutil. That's also been fixed. Signed-off-by: Sugu Sougoumarane go/vt/logutil/purge.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer_test.go go/vt/vttablet/tabletserver/vstreamer/vstreamer.go go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go commit 9cf76649b7374d8774809897827b6fd76686faff Author: Sugu Sougoumarane Date: Fri Jul 19 18:18:32 2019 -0700 vreplication: handle copy for wildcards The catchup code path was ignoring lastpk for wildcard expressions in the filter. This is now fixed. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go commit 79d26b1f6df9814a7b47c2027863232ccc500d61 Author: Dan Kozlowski Date: Fri Jul 19 19:48:42 2019 -0700 Move EnsureVSchema to topo and Added to GetOrCreateShard CreateKeyspace can be called from vtctl or automatically from GetOrCreateShard. This change refactors the ensure vschema logic to its own function and calls it in both places Signed-off-by: Dan Kozlowski go/vt/topo/shard.go go/vt/topo/vschema.go go/vt/vtctl/vtctl.go commit 906f0613224a2ebbc9178f2b2d7861eea1e69253 Merge: 2fe5d9f97 baecb8453 Author: Daniel Kozlowski Date: Sat Jul 20 04:33:32 2019 +0200 Merge pull request #4961 from planetscale/dk-update-orchestrator Updating Orchestrator config to make it more reliable commit 2fe5d9f978732febb353d84627277511742183b7 Merge: fd262fe98 44f3a76f2 Author: Daniel Kozlowski Date: Sat Jul 20 04:32:36 2019 +0200 Merge pull request #4951 from jawabuu/local-docker-development Local docker development commit 0d0edea8bf47f8db102422485851f81d656d57e9 Author: Karel Alfonso Sague Date: Wed Jul 17 21:00:04 2019 +1000 Enable vitess horizontal resharding workflow to use consistent snapshots. Signed-off-by: Karel Alfonso Sague go/vt/workflow/resharding/tasks.go go/vt/workflow/resharding/workflow.go go/vt/workflow/resharding/workflow_test.go commit 0e100c417c8e6420785b98edf56cde7ff3bc41a7 Author: Morgan Tocker Date: Tue Jul 16 09:14:42 2019 -0700 Changes the default TOPO to etcd2 Fixes #4983 Signed-off-by: Morgan Tocker examples/local/101_initial_cluster.sh examples/local/401_teardown.sh examples/local/env.sh test/local_example.sh commit ca0c3938873b2ba343a5f6665f3825382006a30d Author: Morgan Tocker Date: Mon Jul 15 12:12:25 2019 -0700 Improve my.cnf files Partially addresses #4990 Signed-off-by: Morgan Tocker config/mycnf/default-fast.cnf config/mycnf/default.cnf commit 80f6c47703f2ce3c8ef0428baef85717f82c721f Author: Morgan Tocker Date: Sun Jul 14 18:35:37 2019 -0700 fix small error porting patch Signed-off-by: Morgan Tocker go/vt/mysqlctl/mysqld.go commit 3d40fff3f47510af2b3b4b0f6de6367f12d2225f Author: Morgan Tocker Date: Sun Jul 14 18:07:33 2019 -0700 add basedir when starting mysqld Fixes #4992 Signed-off-by: Morgan Tocker go/vt/mysqlctl/mysqld.go commit f24ab633c47b8e3cbf75da71788b088fc3e9fd2a Author: Paul Hemberger Date: Fri Jul 12 13:42:56 2019 -0400 adds vstream to java grpc client Signed-off-by: Paul Hemberger restore formatting go/cmd/vtgateclienttest/services/echo.go go/vt/proto/vtgate/vtgate.pb.go java/client/src/main/java/io/vitess/client/RpcClient.java java/client/src/test/java/io/vitess/client/RpcClientTest.java java/grpc-client/src/main/java/io/vitess/client/grpc/GrpcClient.java commit 30434e2343bb260259864005d6193cd2b830a00f Author: Morgan Tocker Date: Tue Jul 9 15:55:26 2019 -0700 fix mysql_install_db Fixes #4975 Signed-off-by: Morgan Tocker go/vt/mysqlctl/mysqld.go commit 61b9ba3617801d1d195f6930f8ea53573b913a33 Author: Anthony Yeh Date: Sat Jun 29 21:22:18 2019 -0700 Fix RemoveShardCell to only remove the shard from serving in the specified cell. It was removing the shard from the serving set in all cells instead of just one. Signed-off-by: Anthony Yeh go/vt/wrangler/shard.go test/keyspace_test.py commit bffe40a28622442db3efbfd2cfafe0df1fbf64c2 Author: Anthony Yeh Date: Sat Jun 29 21:18:13 2019 -0700 Fix RemoveShardCell for non-range-based shards. KeyRange is `nil` for all non-range-based shards, so this was removing all non-range-based shards from serving, instead of just the one shard. Signed-off-by: Anthony Yeh go/vt/topo/srv_keyspace.go test/keyspace_test.py commit 92647598cf8da6d32949c10d8fea2c437e94a364 Author: Dan Kozlowski Date: Fri Jun 28 20:09:12 2019 -0700 Implementing feedback from PR Signed-off-by: Dan Kozlowski go/cmd/vtbackup/vtbackup.go test/backup.py test/backup_only.py commit 32866800ac1f287c757e19c295ed9e35ff820633 Author: Dan Kozlowski Date: Fri Jun 28 17:25:55 2019 -0700 Updating backup logic Signed-off-by: Dan Kozlowski go/vt/mysqlctl/backup.go test/backup.py commit 0b58b99c49d5dbfd88af434b2ec77b462cf9d1b5 Author: Anthony Yeh Date: Fri Jun 28 10:28:03 2019 -0700 Allow backup to proceed even if nothing changed on master. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 33b3035e5464c63a82631decd5d1859ffdc80c02 Author: Anthony Yeh Date: Thu Jun 27 23:53:17 2019 -0700 Still take a new backup even if nothing changed. We need to create a backup with the new timestamp so we know that our backups are fresh. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 20ea00d7735a090f95eda2e6717c952b9c77b7c4 Author: Dan Kozlowski Date: Thu Jun 27 19:25:43 2019 -0700 Modifying the Backup error reporting logic again. This block of code doesn't make any sense the way its written and I feel something has been lost in translation. I have modified it so at least I can explain it. If you have no backups you will return ErrNoBackup. If you fail to reset replication you will log that message If you fail to Populate the Metadata tables we will return that error Signed-off-by: Dan Kozlowski go/vt/mysqlctl/backup.go commit 44e1dfffed94bd7b3cd33f8a178d12e2676ca50d Merge: 4e1e9bcf2 84a36ab84 Author: Dan Kozlowski Date: Thu Jun 27 19:22:51 2019 -0700 Merge branch 'master' of github.com:planetscale/vitess into dk-backup-only Signed-off-by: Dan Kozlowski commit 8c01085e68562b4c562a656bddd9218ce5188a3d Merge: 1f320d98b 8e2f781e1 Author: jawabuu <49921621+jawabuu@users.noreply.github.com> Date: Fri Jun 28 04:39:03 2019 +0300 Merge branch 'master' into local-docker-development commit 1f320d98b198b735233f7fd0136cde11292ec0e6 Author: jawabuu <49921621+jawabuu@users.noreply.github.com> Date: Fri Jun 28 04:37:11 2019 +0300 update copyright text to Vitess Authors Signed-off-by: jawabuu <49921621+jawabuu@users.noreply.github.com> examples/compose/client.sh examples/compose/lfixrepl.sh examples/compose/lmysql.sh examples/compose/lvtctl.sh commit 5f0c502de65479ee9d1a1e8e4c483499e86d3d7b Author: xichengliudui Date: Wed Jun 5 04:49:49 2019 -0400 This is a combination of 2 commits. Add comments in import() Signed-off-by: xichengliudui fix pr go/cmd/vtbench/vtbench.go commit baecb8453c90a2ee299541b4b2b1c35283888023 Author: Dan Kozlowski Date: Thu Jun 27 17:59:01 2019 -0700 Updating Docker config file for Orchestrator Porting updated config file to the Docker build Signed-off-by: Dan Kozlowski docker/orchestrator/orchestrator.conf.json helm/vitess/templates/_orchestrator-conf.tpl commit 5e097f5b7f2765237fd700eb7c7573866992db43 Author: Dan Kozlowski Date: Thu Jun 27 16:19:58 2019 -0700 Updates based on @msolters working config Signed-off-by: Dan Kozlowski helm/vitess/templates/_orchestrator-conf.tpl commit a7f5814c636a7bc8e9682f43bd6672bd759cbfed Author: Sugu Sougoumarane Date: Sun Jun 16 21:57:28 2019 -0700 vtgate sql: integration test and found a bug Signed-off-by: Sugu Sougoumarane go/vt/vtgate/endtoend/aggr_test.go go/vt/vtgate/endtoend/main_test.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt commit b54cc6270756b9bb6309d0a5b7fbee040d902914 Author: Sugu Sougoumarane Date: Sun Jun 16 21:13:56 2019 -0700 vtgate sql: more composable primitives Remove some tight coupling that existed between various primitives. In particular, orderedAggregate now points at builder instead of a route. Also, mergeSort takes on some of the work that route previously used to do. Boilerplate code has been moved to builderCommon and resultsBuilder. Introduced SupplyWeightString as a required function for all primitives. This is now used by all primitives that need to order by a text column. The end result: memorySort can now sort by text columns, and it can be on top of any primitive, like a join, subquery, etc. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/memory_sort_test.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/route.go go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/memory_sort.go go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/testdata/memory_sort_cases.txt go/vt/vtgate/planbuilder/vindex_func.go commit d034fc4e01ff8972c87be3cb39d2a3ba774510f5 Author: Sugu Sougoumarane Date: Sun Jun 16 13:51:47 2019 -0700 vtgate sql: standardize builderCommon Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/memory_sort.go go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/subquery.go commit 5ce693597dae11761b060728f62fd1300e66271a Author: Sugu Sougoumarane Date: Sun Jun 16 11:46:38 2019 -0700 vtgate sql: get rid of most panics Eventhough many of those places are unreachable, it's better to return an error instead. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/expr.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/union.go commit 86ac31907ecde7e04cf28ea8bd334256959cc3b4 Author: Sugu Sougoumarane Date: Sun Jun 16 10:08:46 2019 -0700 vtgate sql: colnum -> colNumber colnum and column looked too similar and confusing. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/memory_sort.go go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/vindex_func.go commit e1acadea40d743adc912e82b41db81f93e1406bd Author: Sugu Sougoumarane Date: Sun Jun 16 00:04:39 2019 -0700 vtgate sql: memory sort for more primitives memory sort is now added for join, subquery and vindexFunc. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/testdata/memory_sort_cases.txt go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt go/vt/vtgate/planbuilder/vindex_func.go commit 611b4d436b49deeb49dc7b04ea43600cf7ae1f2f Author: Sugu Sougoumarane Date: Sat Jun 15 20:29:38 2019 -0700 vtgate sql: consolidate common code Some boiler-plate behaviors were accumulating in each builder. They've now been consolidated under builderCommon. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/memory_sort.go go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/subquery.go commit 3aa9e5213e8efc54a11de3fb95e09edf3b54e955 Author: Saif Alharthi Date: Thu Jun 20 16:31:56 2019 -0700 Add simple wildcard support for deleting from multiple tables in unsharded keyspaces Signed-off-by: Saif Alharthi go/vt/sqlparser/parse_test.go go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y go/vt/vtgate/endtoend/deletetest/delete_test.go commit 8e2f781e1e3b6d94a50b123660bc4cfa4dd3efc4 Merge: f62cc59a1 a05f8dc10 Author: Deepthi Sigireddi Date: Thu Jun 27 09:48:14 2019 -0700 Merge pull request #4933 from planetscale/ss-memory-sort vtgate sql: in-memory sorting commit a05f8dc10d6daabd03048373a47c8047a61823ea Author: Sugu Sougoumarane Date: Wed Jun 26 23:15:19 2019 -0700 vtgate sql: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/merge_sort.go commit f62cc59a18aabf13b939c873170290dcf921b50c Merge: e6dd0920a 440aa522b Author: Sugu Sougoumarane Date: Wed Jun 26 23:04:44 2019 -0700 Merge pull request #4964 from zwcn/fix-encoding-error-when-generating-java-protobuf use English quotes in the comment of vtgate.proto commit e6dd0920a1be080e092f98a748c7e1660602f28b Merge: 84a36ab84 3daf82c69 Author: Sugu Sougoumarane Date: Wed Jun 26 23:01:10 2019 -0700 Merge pull request #4965 from planetscale/ss-alt-vindex-sort vindexes: alt approach for lookup sorted inserts commit 3daf82c694890693258b68f2444445abf07aa01f Author: Sugu Sougoumarane Date: Wed Jun 26 21:24:14 2019 -0700 vindexes: alt approach for lookup sorted inserts Looks like too many callers are affected if the passed in values are sorted by the `Create` function. Instead of changing all the call sites, it's better that `Create` sorts a copy of the values and leave the external behavior unchanged. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/endtoend/lookup_test.go go/vt/vtgate/endtoend/main_test.go go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/lookup.go go/vt/vtgate/vindexes/lookup_hash.go go/vt/vtgate/vindexes/lookup_internal.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash.go commit 440aa522bc1a4e4ef68fa7fad2646d405764f026 Author: zwcn Date: Wed Jun 26 19:05:59 2019 -0400 use english quotes instead Signed-off-by: zwcn proto/vtgate.proto commit 367911de223df8b5068a6e797b7a720d98235626 Author: Andres Taylor Date: Wed Jun 26 14:02:11 2019 +0200 Use Vitess log instead of glog Signed-off-by: Andres Taylor go/vt/vttablet/tabletmanager/rpc_lock_tables.go commit 7aeff8c5a57488dc5c906814552aef81d853abe0 Author: Sugu Sougoumarane Date: Mon Jun 24 17:38:48 2019 -0700 vtgate sql: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/memory_sort_test.go go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt commit 239c589bee970c6f51377129a63a493db89c9808 Author: Sugu Sougoumarane Date: Mon Jun 24 16:57:08 2019 -0700 vreplication: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/vdbclient.go commit e71506b6db1d71b220514d3dfb1b3a2168a7dbea Author: Isaac Anastasoff Date: Mon Jun 24 16:51:39 2019 -0700 Increased memorytopo generation pool size to 1 << 60 Signed-off-by: Isaac Anastasoff go/vt/topo/memorytopo/memorytopo.go commit ee9b992763e4cc8162248902c0b354ad4f8aab0b Author: avaidyanatha Date: Mon Jun 24 11:45:53 2019 -0700 Fix etcd watcher leak Signed-off-by: avaidyanatha go/vt/topo/etcd2topo/watch.go commit 9ad7630fd4e4fbdaa165fa461b1bf328b46b2434 Author: Sugu Sougoumarane Date: Fri Jun 21 10:18:40 2019 -0700 vreplication: more cleanup Push down the retriable exec into vdbClient so vcopier can also use it. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vdbclient.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit 71dd16d4b5fd942ccd4e9c1922b239d14c4fef8d Author: Sugu Sougoumarane Date: Thu Jun 20 23:13:54 2019 -0700 vreplication: code improvement Returning queries to execute is a bad pattern, and bloats code. This new pattern delegates the generation and execution to a single function. Much cleaner code. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go commit d7d2adc1b124c9a6de94b3fdf00387f23ff7ade6 Author: Dan Kozlowski Date: Wed Jun 19 17:15:50 2019 -0700 Fixed permissions and Compile Errors Signed-off-by: Dan Kozlowski go/vt/topo/keyspace.go go/vt/topo/topotests/srv_vschema_test.go go/vt/wrangler/keyspace.go test/vschema.py commit a83e3fd359e939af27cf818bba76178f1e79eb9d Author: Dan Kozlowski Date: Wed Jun 19 16:09:14 2019 -0700 Adding test to list of all tests Also modifying how we explicitly delete vschema. There is now an explicit delete. Signed-off-by: Dan Kozlowski go/vt/topo/vschema.go go/vt/wrangler/keyspace.go test/config.json commit c325bc49d0cdb5a61b96a669030bf9cecc7098ee Author: deepthi Date: Wed Jun 19 14:44:52 2019 -0700 restore: carry over change from #4929 into refactored function Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go commit 8970c944fd753fba5b5fa3c61051a50c5b0b4e02 Author: deepthi Date: Wed Jun 19 12:07:09 2019 -0700 restore: only delete progress file at the of mysqlctl.Restore Signed-off-by: deepthi go/vt/mysqlctl/backup.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go commit 712ad3ff53811a2f1ca9d781c53d1bc807f447ff Author: deepthi Date: Wed Jun 19 09:43:43 2019 -0700 restore: fix comments Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go commit 7c2b83f20d2be9b78b7640d1677e0b416fac5c88 Author: Dan Kozlowski Date: Fri May 31 11:29:30 2019 -0700 Removing the lengh check for removal of a vschema Also adding tests for new schema mode Signed-off-by: Dan Kozlowski go/vt/topo/vschema.go go/vt/vtctl/vtctl.go test/vschema.py commit 9cb4ab787e3af66f26a6bcc6547ee48131689fde Author: Dan Kozlowski Date: Sat May 18 14:27:06 2019 -0700 Modifying implementation as per feedback Signed-off-by: Dan Kozlowski go/vt/topo/keyspace.go go/vt/topo/srv_vschema.go go/vt/topo/topotests/srv_vschema_test.go go/vt/topotools/rebuild_vschema.go go/vt/vtcombo/tablet_map.go go/vt/vtctl/vtctl.go go/vt/vtgate/vindexes/vschema_test.go go/vt/vttablet/tabletmanager/initial_rebuild.go go/vt/vttablet/tabletserver/vstreamer/testenv/testenv.go commit df0942529bb7249f91764614929a5053398fb045 Author: Dan Kozlowski Date: Fri May 17 21:55:11 2019 -0700 Add blank VSchema for new keyspaces This change adds a blank VSchema for a newly created keyspace. As keyspaces can't be used until they have a vschema this allows an unsharded keyspace to be used without requireing an explicit vschema to be loaded for it Signed-off-by: Dan Kozlowski go/vt/topo/keyspace.go go/vt/topo/srv_vschema.go go/vt/topotools/rebuild_vschema.go go/vt/vtctl/vtctl.go commit f756576616ffaf7bc4a2e2d4ad5ad7ef03d4bc5b Author: Dan Kozlowski Date: Tue Jun 18 14:01:44 2019 -0700 Modifying tests to support refactor of vtbackup. Also adding in support for non initial_backup backup being taken with vtbackup Signed-off-by: Dan Kozlowski go/cmd/vtbackup/vtbackup.go go/vt/mysqlctl/backup.go go/vt/servenv/grpc_server.go test/backup_only.py test/vtbackup.py commit 1c323c3f055fd99a3db361bee85acc808b36c263 Author: Anthony Yeh Date: Tue Jun 18 19:01:31 2019 -0500 Add flag to wait for backup instead of starting up empty. (#4929) Signed-off-by: Anthony Yeh doc/BackupAndRestore.md go/vt/mysqlctl/backup.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go go/vt/vttablet/tabletmanager/action_agent.go go/vt/vttablet/tabletmanager/restore.go go/vt/vttablet/tabletmanager/rpc_backup.go go/vt/wrangler/testlib/backup_test.go test/backup.py commit e85b8aa5c53256acde71e2685faaac74990da3f8 Author: Sugu Sougoumarane Date: Tue Jun 18 15:11:52 2019 -0700 vtgate: warning threshold for in-memory rows Signed-off-by: Sugu Sougoumarane go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go go/vt/vtgate/vtgate.go commit 72bf2c1226e73f88fbc298565d8ee1c9aa56cf8b Author: deepthi Date: Tue Jun 18 14:56:18 2019 -0700 restore: change file name, create it before stopping mysqld and deleting files Signed-off-by: deepthi go/vt/mysqlctl/backup.go go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go test/backup.py commit ed239161b6be62e9b31b68ce1dd779a60ef20d94 Author: deepthi Date: Tue Jun 18 13:16:16 2019 -0700 Restore: no need to use background context. Fix tests and xtrabackup to allow multiple restores of same vttablet Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/xtrabackupengine.go test/backup.py test/config.json test/xtrabackup_xtra.py commit ae4b458077b9a51c7bdc03825e22c14e14504aa7 Author: Anthony Yeh Date: Mon Jun 17 19:07:44 2019 -0500 Add /debug/liveness handler for liveness checks. (#4935) This is a handler typically used for server liveness checks. If the server can't execute this simple handler, it probably isn't able to do useful work for other incoming requests that actually ask the server to do something. In that case, the watchdog usually assumes the server process is stuck (deadlocked or livelocked) and restarts it. Signed-off-by: Anthony Yeh go/vt/servenv/liveness.go go/vt/servenv/liveness_test.go commit 411aca1d65dab237b51726fa1c97055a66ed4606 Author: Sugu Sougoumarane Date: Sat Jun 15 12:58:41 2019 -0700 vtgate sql: memory sort engine unit tests Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/memory_sort_test.go go/vt/vtgate/planbuilder/ordered_aggregate.go commit db0c37e1150f1a1a67f486c0463e63bcc5300092 Author: Sugu Sougoumarane Date: Sat Jun 15 09:52:04 2019 -0700 vtgate sql: in-memory sorting, initial cut The planbuilder and tests for it are ready. Still need tests for the engine primitive. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/memory_sort.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/memory_sort.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/plan_test.go go/vt/vtgate/planbuilder/testdata/memory_sort_cases.txt go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt commit 71eaa6f1d883a2332a65322437d19a5780ccda1a Author: Anthony Yeh Date: Fri Jun 14 15:33:53 2019 -0700 vtbackup: Also create the main database in initial backup. This makes it better match the state that you'd have if you used InitShardMaster instead. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit a9c2a4e98fe868ec5e046c285fe29c3305e3a374 Author: Anthony Yeh Date: Fri Jun 14 15:32:05 2019 -0700 vtbackup: Allow initial backup as long as no tablets are serving. Requiring that no tablets are running at all was too strict. It prevented using the new -wait_for_backup_interval flag to start up tablets concurrently while the initial backup is going. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 14e79eccf28be0180052c663a36cd66a4145873b Author: Sugu Sougoumarane Date: Thu Jun 13 22:13:07 2019 -0700 vtgate sql: enforce a max row count limit I've been claiming that vtgate had a max row count limit. It turns out that I never actually implemented it. So, here's the implementation. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/join.go go/vt/vtgate/engine/join_test.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/scatter_conn.go go/vt/vtgate/scatter_conn_test.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vtgate.go commit d238fc213fab3323edd31213bf0d6bbd7e02d760 Author: Sugu Sougoumarane Date: Thu Jun 13 08:53:36 2019 -0700 vstream: remove heartbeat events Heartbeat events can OOM vtgate because they accumulate if there are no real events. Removing it for now because the info is currently not usable by the subscriber. We need to think of a good model for this. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/resolver.go go/vt/vtgate/resolver_test.go commit d135722cacb04cadf28cbe0d9094b2e7b25c5c6c Author: deepthi Date: Wed Jun 12 18:48:07 2019 -0700 restore: refactor, rename, cleanup based on review comments. fix testcase to actually test interrupted restore Signed-off-by: deepthi go/cmd/mysqlctld/mysqlctld.go go/vt/mysqlctl/backup.go go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go test/backup.py commit e212bbde682ac8d9ce13e524f88ab6e370f5982b Author: Jon Tirsen Date: Wed Jun 12 11:04:32 2019 +1000 Don't ignore grpc start up error Signed-off-by: Jon Tirsen go/vt/servenv/grpc_server.go commit 7cac07fd8de9812387016b554a3ffd0d994656bd Author: deepthi Date: Wed Jun 5 15:07:01 2019 -0700 restore: allow retry of interrupted restores to start from beginning even if some data exists Signed-off-by: deepthi go/cmd/mysqlctld/mysqlctld.go go/vt/mysqlctl/backup.go go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go commit 8f522d1e2a1949feb89880969cf6aeec54770076 Author: Michael Pawliszyn Date: Mon Jun 10 11:36:58 2019 -0400 Reorder keyspace ids when reordering bulk lookup table inserts. Otherwise bulk `insert ignore` queries will fail as the validate assumes the values and ids are still in the same order. Signed-off-by: Michael Pawliszyn go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/lookup.go go/vt/vtgate/vindexes/lookup_hash.go go/vt/vtgate/vindexes/lookup_internal.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash.go commit a4aa8424012cd8f3b7fdf05e3c2c3d1183752c81 Author: Sugu Sougoumarane Date: Sun Jun 9 21:56:48 2019 -0700 vtgate sql: distinct aggregates tests push down distinct by unique vindex cases. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/vindex_func.go commit 9677d67db67d7804b25b7c2d1ebec6a5776052e2 Author: Sugu Sougoumarane Date: Sun Jun 9 18:22:09 2019 -0700 vtgate sql: distinct aggregates tests engine tests Signed-off-by: Sugu Sougoumarane go/sqltypes/arithmetic.go go/sqltypes/arithmetic_test.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go commit fa28e0c1647efc3a543d333bea503b6a66da0ba7 Author: Sugu Sougoumarane Date: Sun Jun 9 14:15:09 2019 -0700 vtgate: distinct aggregates initial cut VTGate engine was ignoring DISTINCT clauses inside aggregate functions. This would have led to incorrect results for scatter queries. This change adds the ability to handle them correctly. Signed-off-by: Sugu Sougoumarane go/sqltypes/arithmetic.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/ordered_aggregate_test.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/postprocess.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/testdata/onecase.txt go/vt/vtgate/planbuilder/vindex_func.go commit 7e9e3ba3eb5194439630f5c8e95a8924bef03ff4 Author: Anthony Yeh Date: Fri Jun 7 12:41:27 2019 -0700 vtbackup: Make -initial_backup mode idempotent. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 4e80ef467bbd69feb0ea4576447e073c12b3c6ce Author: Sugu Sougoumarane Date: Wed Jun 5 22:41:32 2019 -0700 vstream: address review comments Signed-off-by: Sugu Sougoumarane go/cmd/vtgateclienttest/services/fallback.go go/cmd/vtgateclienttest/services/terminal.go go/vt/proto/binlogdata/binlogdata.pb.go go/vt/proto/vtgate/vtgate.pb.go go/vt/vitessdriver/fakeserver_test.go go/vt/vtgate/endtoend/vstream_test.go go/vt/vtgate/fakerpcvtgateconn/conn.go go/vt/vtgate/grpcvtgateconn/conn.go go/vt/vtgate/grpcvtgateservice/server.go go/vt/vtgate/resolver.go go/vt/vtgate/resolver_test.go go/vt/vtgate/shard_positions.go go/vt/vtgate/shard_positions_test.go go/vt/vtgate/vtgate.go go/vt/vtgate/vtgateconn/vtgateconn.go go/vt/vtgate/vtgateconntest/client.go go/vt/vtgate/vtgateservice/interface.go proto/binlogdata.proto proto/vtgate.proto py/vtproto/binlogdata_pb2.py py/vtproto/vtgate_pb2.py commit cbd7d257d92fdc89899d195f59aedeb0912caada Author: Sugu Sougoumarane Date: Thu Jun 6 14:42:45 2019 -0700 vreplication: allow multi-value functions (#4914) The previous code (from old behavior) was still disallowing functions with more than one parameter. That check has been moved to 'sum' which is the only place where it should be enforced. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go commit 5bd6397e13a240db57315ea9a7ef7206f57719fd Author: LiuDui Date: Fri Jun 7 03:51:25 2019 +0800 update cacheservice Using var block (#4906) Signed-off-by: xichengliudui go/cacheservice/cacheservice.go commit 89b30fe32ca12bf4db141a457dc45543b0097f29 Author: teejae Date: Fri Jun 7 04:48:18 2019 +0900 Add error handling for parsing StringMapValues instead of panicking (#4912) Signed-off-by: Toliver Jue go/flagutil/flagutil.go go/flagutil/flagutil_test.go commit 867dfff134be1aed0d16da825e36e741814fa2a3 Author: teejae Date: Thu Jun 6 23:45:56 2019 +0900 Fix vtctl commandline help for StringMapValues, including mentioning InitTablet tags (#4911) Signed-off-by: Toliver Jue go/vt/vtctl/vtctl.go commit 61655c05c6b039952d3aa85f195f9ec3a0d0c222 Author: Sugu Sougoumarane Date: Wed Jun 5 23:29:11 2019 -0700 pools: address more review comments Signed-off-by: Sugu Sougoumarane go/pools/resource_pool.go go/pools/resource_pool_test.go commit ea85d299927c32cfb0145cb8cf4a46da1a947886 Author: Sugu Sougoumarane Date: Wed Jun 5 21:23:56 2019 -0700 vtgate: export routing_rules in /debug/vschema (#4899) Signed-off-by: Sugu Sougoumarane go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go commit beb841567de273757987de3f0c16f5fe169bf4b9 Author: deepthi Date: Wed Jun 5 14:15:21 2019 -0700 restore: refactor common code, add functions Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go commit 22bccdd3d02a2912b71ad54c11ec7c8fde14fb98 Author: Anthony Yeh Date: Wed Jun 5 09:53:53 2019 -0700 vtbackup: Add backup interval and pruning with retention policy. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit e10c6246d8543eeda0d42a8a3ec8cd3ceab8e080 Author: Anthony Yeh Date: Tue Jun 4 21:21:51 2019 -0700 vtbackup: Add -initial_backup flag for seeding an empty backup. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit b42cfb25bbaffb4133892cb1624978a54c6a92bb Author: Anthony Yeh Date: Tue Jun 4 19:37:21 2019 -0700 vtbackup: Use a snapshot position as the goal instead of a lag value. The lag value can lie. Also we're guaranteed to hit the snapshot position eventually as long as replication is making progress. If our goal is a lag value, we may never catch up if replication is slower than the rate of new transactions on the master. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 9a43d1074b34d8ccc8bb31ba1d835bc541c01f6b Author: Anthony Yeh Date: Tue Jun 4 17:12:34 2019 -0700 vtbackup: Incorporate mysqlctld behavior so that's not needed. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit af81ebc10703ed69096bc09c5bca37be4a4344b1 Author: Anthony Yeh Date: Tue Jun 4 16:14:50 2019 -0700 vtbackup: Document and clean up. Signed-off-by: Anthony Yeh go/cmd/vtbackup/vtbackup.go commit 12bfde34629c5f13d247f8086e70161607c78e65 Author: Win-Man <825895587@qq.com> Date: Mon Jun 3 01:10:40 2019 +0800 change topo_implementation default value (#4869) * change topo_implementation default value Signed-off-by: Win-Man <825895587@qq.com> * change the default value of topo_implementation to empty go/vt/topo/server.go commit 94a33b4e6a1d747c03f04d9394808c28e96e622f Author: Sugu Sougoumarane Date: Sun Jun 2 10:07:43 2019 -0700 pools: address review comments Signed-off-by: Sugu Sougoumarane go/pools/resource_pool_test.go go/vt/vttablet/tabletserver/connpool/pool.go commit 0c56618bd2c242c18b59491ed2031953ca82d98d Author: Sugu Sougoumarane Date: Tue May 28 09:30:21 2019 -0700 vtgate plan: auto-expand insert column list If the table has authoritative column list, use it to auto-expand insert columns if they were not supplied. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/testdata/dml_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json commit 43acd7b29b530f7cda756954e19a15223632761b Author: kuba-- Date: Sat Jun 1 00:16:27 2019 +0200 Don't return an error for CONN_ATTR (just log) Signed-off-by: kuba-- go/mysql/server.go commit 1bfa92dc9547b944375ff62ef5643f35feaa2439 Author: Michael Demmer Date: Fri May 31 12:22:28 2019 -0700 rename FilterTag to QueryLogFilterTag for consistency and clarity Signed-off-by: Michael Demmer go/streamlog/streamlog.go go/vt/vtgate/logstats_test.go go/vt/vtgate/querylogz_test.go go/vt/vttablet/tabletserver/querylogz_test.go go/vt/vttablet/tabletserver/tabletenv/logstats_test.go commit a0f2d1fdfff3919aecb33039aa507e863cd74b07 Author: Michael Demmer Date: Fri May 31 12:17:17 2019 -0700 ensure querylogz still shows queries when filter tag is enabled Signed-off-by: Michael Demmer go/vt/vtgate/querylogz_test.go go/vt/vttablet/tabletserver/querylogz_test.go commit f79549b78e7a93b2f3b23c9356d1548951c4a352 Author: Michael Demmer Date: Fri May 31 12:10:32 2019 -0700 add optional tag-based filtering for query logging Add a flag -querylog-filter-tag to only emit query logging for queries that contain the specified string. Signed-off-by: Michael Demmer go/streamlog/streamlog.go go/vt/vtgate/logstats.go go/vt/vtgate/logstats_test.go go/vt/vttablet/tabletserver/tabletenv/logstats.go go/vt/vttablet/tabletserver/tabletenv/logstats_test.go commit 84484a0ec2835dfb7a6c5c3bbfc15f14514ba15a Author: deepthi Date: Thu May 30 18:55:21 2019 -0700 rename flag per naming convention Signed-off-by: deepthi go/vt/vterrors/vterrors.go commit f8c41d436356b60ecf92eb19fef69c6e5a36d9b6 Author: Adam Saponara Date: Thu May 30 15:14:36 2019 -0400 Add `-keep_logs_by_mtime` flag for purging old log files by mtime instead of ctime. (Alternative solution for 7864985.) Signed-off-by: Adam Saponara go/vt/logutil/logutil_test.go go/vt/logutil/purge.go commit 85482af13a9a38442c1565de01ec921b182e08f5 Author: dleibovic Date: Wed May 29 12:21:28 2019 -0400 Add log line indicating when WaitForReparentJournal fails Signed-off-by: dleibovic go/vt/mysqlctl/reparent.go commit 44772fd8ad0819e5ddfde8a8fbdf7347319aa835 Author: Rafael Chacon Date: Sun May 26 08:43:26 2019 -0700 Adds table and keyspace name to v3 processed queries * Before this change, vtgate don't attach information about keyspace/table when emitting metrics. This change addresses this issue. * In order to do this, the Primitive interface have been extended to contain a data structure with the keyspace and table names that the primitive operates on. * At the moment, metrics are only emitted for the first table in this data structure. Per discussion with Sugu, we will add this in a future change. Signed-off-by: Rafael Chacon go/vt/vtgate/engine/delete.go go/vt/vtgate/engine/fake_primitive_test.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/join.go go/vt/vtgate/engine/limit.go go/vt/vtgate/engine/ordered_aggregate.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/engine/pullout_subquery.go go/vt/vtgate/engine/route.go go/vt/vtgate/engine/subquery.go go/vt/vtgate/engine/update.go go/vt/vtgate/engine/vindex_func.go go/vt/vtgate/executor.go go/vt/vtgate/planbuilder/from.go commit a734b763ef8613bccf9544e665075b3674144e88 Author: Sugu Sougoumarane Date: Sat May 25 12:46:34 2019 -0700 vstream: fix data race Signed-off-by: Sugu Sougoumarane go/vt/vtgate/resolver.go commit a7c07ab05c9936e03ff7a9e4baad811623b466ae Author: Sugu Sougoumarane Date: Sat May 25 11:00:47 2019 -0700 routing rules: fix TODO Tables with authoritative columns are now handled correctly. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/symtab_test.go commit 89fe07b25fcc1f6417bf69320c2dbc2c2fc70f9f Author: eleven Date: Sat May 25 23:45:52 2019 +0800 need a space before = Signed-off-by: eleven web/vtctld2/src/app/shared/dialog/dialog-settings.ts web/vtctld2/src/app/workflows/node.ts commit 046d9e141c105ab9f2d7837a8be9d7789b2e9aa4 Author: eleven Date: Sat May 25 23:38:30 2019 +0800 should use ' to take place of " Signed-off-by: eleven web/vtctld2/src/app/workflows/workflow-list.component.ts commit 9cebb4079b7beee9f327a6a470d310a03ed9538d Author: Sugu Sougoumarane Date: Sat May 25 07:14:47 2019 -0700 pools: unify constructor to NewResourcePool Signed-off-by: Sugu Sougoumarane go/pools/resource_pool.go go/pools/resource_pool_test.go go/vt/dbconnpool/connection_pool.go go/vt/vttablet/tabletserver/connpool/pool.go commit 1bbe3cce0f2918399b827c7610ba71fcde5358ba Author: Sugu Sougoumarane Date: Fri May 24 09:34:50 2019 -0700 pools: tabletserver prefill cmd line options Signed-off-by: Sugu Sougoumarane go/vt/vttablet/heartbeat/reader.go go/vt/vttablet/heartbeat/writer.go go/vt/vttablet/tabletserver/connpool/pool.go go/vt/vttablet/tabletserver/connpool/pool_test.go go/vt/vttablet/tabletserver/messager/engine.go go/vt/vttablet/tabletserver/messager/message_manager_test.go go/vt/vttablet/tabletserver/query_engine.go go/vt/vttablet/tabletserver/schema/engine.go go/vt/vttablet/tabletserver/schema/load_table_test.go go/vt/vttablet/tabletserver/tabletenv/config.go go/vt/vttablet/tabletserver/tx_engine.go go/vt/vttablet/tabletserver/tx_engine_test.go go/vt/vttablet/tabletserver/tx_pool.go go/vt/vttablet/tabletserver/tx_pool_test.go commit ba54ddcf0dbf04d5bee13d0f9a3d069d77bc0f43 Author: Sugu Sougoumarane Date: Fri May 24 08:42:27 2019 -0700 pools: solidfy prefill code and add tests Signed-off-by: Sugu Sougoumarane go/pools/resource_pool.go go/pools/resource_pool_test.go commit ec490355e21034c7de699b2455a3f8aeb3a3e014 Author: Sugu Sougoumarane Date: Sun Mar 31 09:29:36 2019 -0700 pools: option to prefill Background: this change allows one to create prefilled resource pools. This is useful when traffics suddenly shift while the pool is still empty. This causes a thundering herd of Open requests that can cause outage. There is a proposal to rewrite this pool to natively accommodate this feature. This change is a stand-in until that effort is completed. Signed-off-by: Sugu Sougoumarane go/pools/resource_pool.go commit 2fa46ba9f5f6dc520c1e8f24d8e485eeb469b19d Author: Sugu Sougoumarane Date: Thu May 23 20:08:57 2019 -0700 dbconfigs: remove default utf8 from charset Followup fix to #4870: The db charset had a default value of utf8, which makes it hard to check if the value was actually specified in the command line signaling an override. Changing this to blank allows us to disambiguate this situation. Moreover, I believe MySQL wants to deprecate utf8 in favor of utf8mb4. So, it's better to not have such a default, or any default until this matter is settled in the MySQL community. Signed-off-by: Sugu Sougoumarane go/vt/dbconfigs/dbconfigs.go commit 3d8954329f6f271368895beca2fd0a73fe476895 Author: Jon Tirsen Date: Wed May 8 11:23:04 2019 +1000 Sort inserts to lookup tables to avoid deadlocks Signed-off-by: Jon Tirsen go/vt/vtgate/vindexes/lookup_internal.go commit 65138f200afdf5d427e415dde9e22be5d5340f7d Author: Sugu Sougoumarane Date: Wed May 22 18:17:34 2019 -0700 dbconfigs: fix regression PR #4814 introduced a regression where the base config would override charset and flags even if the base config values for those were not specified. This change checks for those values before overriding them. Signed-off-by: Sugu Sougoumarane go/vt/dbconfigs/dbconfigs.go go/vt/dbconfigs/dbconfigs_test.go commit eff5f4772fe15e887edd068e387d68c271bda485 Author: kuba-- Date: Fri May 17 11:45:38 2019 +0200 Support nested substring calls Signed-off-by: kuba-- go/vt/sqlparser/parse_test.go go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y commit 0b59741632288683952e3cbeb2d4477dd631608b Author: Sugu Sougoumarane Date: Mon May 13 20:30:35 2019 -0700 vstream: RPC scaffolding Signed-off-by: Sugu Sougoumarane go/cmd/vtgateclienttest/services/fallback.go go/cmd/vtgateclienttest/services/services.go go/cmd/vtgateclienttest/services/terminal.go go/vt/proto/vtgate/vtgate.pb.go go/vt/proto/vtgateservice/vtgateservice.pb.go go/vt/vitessdriver/fakeserver_test.go go/vt/vtgate/fakerpcvtgateconn/conn.go go/vt/vtgate/grpcvtgateconn/conn.go go/vt/vtgate/grpcvtgateservice/server.go go/vt/vtgate/resolver.go go/vt/vtgate/resolver_test.go go/vt/vtgate/vtgate.go go/vt/vtgate/vtgateconn/vtgateconn.go go/vt/vtgate/vtgateconntest/client.go go/vt/vtgate/vtgateservice/interface.go proto/vtgate.proto proto/vtgateservice.proto py/vtproto/vtgate_pb2.py py/vtproto/vtgateservice_pb2.py py/vtproto/vtgateservice_pb2_grpc.py commit 64f1df796d4da12f798555bed85215fed22c3379 Author: Sugu Sougoumarane Date: Mon May 13 19:15:40 2019 -0700 vstream: uni tests done Signed-off-by: Sugu Sougoumarane go/vt/topo/topoproto/shard.go go/vt/topo/topoproto/shard_test.go go/vt/vtgate/resolver.go go/vt/vtgate/resolver_test.go go/vt/vtgate/shard_positions.go go/vt/vtgate/shard_positions_test.go go/vt/vtgate/vtgate.go go/vt/vttablet/sandboxconn/sandboxconn.go commit b440bc39bf56c4a83a691d8a18ed9f393fb1fe78 Author: Sugu Sougoumarane Date: Mon May 13 09:01:12 2019 -0700 vstream: code improvements Signed-off-by: Sugu Sougoumarane go/vt/vtgate/resolver.go go/vt/vtgate/vtgate.go commit cdfc3f4eb038e898667d9b19db52763305ba9093 Author: Sugu Sougoumarane Date: Mon May 13 05:10:59 2019 -0700 vstream: initial cut Signed-off-by: Sugu Sougoumarane go/vt/vtgate/resolver.go go/vt/vtgate/vtgate.go commit 70a2509b5e4085d32b6aa9298b49501121f70741 Author: Dan Kozlowski Date: Fri May 10 18:19:29 2019 -0700 Remove backup from vttablet and create a backup only job This removes the backup_only from vttablet and creates a new binary only for backups. This binary does not register itsself with the topo server, but it does still require a valid tablet alias to facilitate replication. This can also be though of as Just Enough Vitess for Backup Signed-off-by: Dan Kozlowski go/cmd/vtbackup/plugin_cephbackupstorage.go go/cmd/vtbackup/plugin_consultopo.go go/cmd/vtbackup/plugin_etcd2topo.go go/cmd/vtbackup/plugin_filebackupstorage.go go/cmd/vtbackup/plugin_gcsbackupstorage.go go/cmd/vtbackup/plugin_s3backupstorage.go go/cmd/vtbackup/plugin_zk2topo.go go/cmd/vtbackup/vtbackup.go go/cmd/vttablet/vttablet.go test/backup_only.py test/vtbackup.py commit 21b6ea075ac9ef17e9bbfeabfb4d068d4c2261dc Author: Sugu Sougoumarane Date: Thu May 9 21:23:17 2019 -0700 consistent lookup: address more review comments Signed-off-by: Sugu Sougoumarane go/vt/vtgate/executor.go go/vt/vtgate/safe_session.go commit b4379fa07865ac734889bc8d79757fddc0f53045 Author: Sugu Sougoumarane Date: Thu May 9 20:59:29 2019 -0700 consistent lookup: address review comments The VCursor API is impressively simpler no. Signed-off-by: Sugu Sougoumarane go/vt/proto/vtgate/vtgate.pb.go go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/safe_session.go go/vt/vtgate/tx_conn_test.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/consistent_lookup_test.go go/vt/vtgate/vindexes/lookup.go go/vt/vtgate/vindexes/lookup_hash.go go/vt/vtgate/vindexes/lookup_internal.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash.go go/vt/vtgate/vindexes/vindex.go proto/vtgate.proto py/vtproto/vtgate_pb2.py commit fdaa16e7ff4a35fd1a703f2ffa322589e5166485 Author: Dan Kozlowski Date: Thu May 9 14:44:05 2019 -0700 Moving backup job to its own file, and changing condition for restart of tablet Signed-off-by: Dan Kozlowski go/cmd/vttablet/vttablet.go test/backup.py test/config.json commit d775954c8f664665784d222c40ade073974ad564 Author: Sugu Sougoumarane Date: Wed May 8 20:29:16 2019 -0700 consistent lookup: revert to normal commit order Some people may still rely on the sequential commit order of the normal transactions. So, it's better not to parallelize that part. Signed-off-by: Sugu Sougoumarane go/vt/vtexplain/testdata/multi-output/deletesharded-output.txt go/vt/vtexplain/testdata/multi-output/insertsharded-output.txt go/vt/vtexplain/testdata/multi-output/options-output.txt go/vt/vtexplain/testdata/multi-output/updatesharded-output.txt go/vt/vtgate/tx_conn.go commit f04d40552ca13c6ce1d70712e65c46baa385b480 Author: Sugu Sougoumarane Date: Wed May 8 20:04:07 2019 -0700 consistent lookup: fix stray tests Signed-off-by: Sugu Sougoumarane go/cmd/vtclient/vtclient_test.go go/vt/vtgate/engine/insert_test.go go/vt/vtgate/vcursor_impl.go commit d2799b60d765b8574aa176eb7cd816e7946d236c Author: Sugu Sougoumarane Date: Wed May 8 17:59:42 2019 -0700 consistent lookup: endtoend tests Signed-off-by: Sugu Sougoumarane go/vt/vtgate/endtoend/lookup_test.go go/vt/vtgate/endtoend/main_test.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/consistent_lookup_test.go go/vt/vttest/local_cluster.go commit 1af4c40c637cef8496f9f4e6b5a2b22b20459768 Author: Sugu Sougoumarane Date: Tue May 7 14:34:49 2019 -0700 consistent lookup: vindexes unit test Signed-off-by: Sugu Sougoumarane go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/consistent_lookup_test.go commit 68b83a912f679db51adef4786359b80c99725002 Author: Dan Kozlowski Date: Tue May 7 14:33:25 2019 -0700 Addressing feeback from PR Removing whitespace and renaming flag Signed-off-by: Dan Kozlowski go/cmd/vttablet/vttablet.go test/backup.py commit cae96e083a1f55e8ed9fba033a92f76aaa2fb64e Author: Dan Kozlowski Date: Mon May 6 22:58:18 2019 -0700 Adding a new option to vttablet to enable it to take a backup and exit Signed-off-by: Dan Kozlowski go/cmd/vttablet/vttablet.go go/vt/vttablet/tabletmanager/action_agent.go test/backup.py commit db5cd428e063ceb89bd2099954aba042f976f92d Author: Sugu Sougoumarane Date: Tue May 7 11:09:51 2019 -0700 consistent lookup: testing phase 1 Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/lookup.go go/vt/vtgate/vindexes/lookup_hash.go go/vt/vtgate/vindexes/lookup_internal.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash.go go/vt/vtgate/vindexes/vindex.go commit 9199612539cb77d21c9e6c4eadc67a2f62f87590 Author: Sugu Sougoumarane Date: Mon May 6 17:31:38 2019 -0700 consistent lookup: skeletal implementation Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/consistent_lookup.go go/vt/vtgate/vindexes/lookup_internal.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/vindex.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 6ea59b51b65674e3afe440b1b54524aecd0f8b31 Author: Sugu Sougoumarane Date: Mon May 6 09:33:17 2019 -0700 consistent lookup: Pre and Post in vcursor Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/vindex.go commit 790e8fab44476cc2960b16ebe2f966d77ebb52ef Author: dleibovic Date: Tue Apr 30 16:53:16 2019 -0400 Remove unnecessary usage of FLUSH TABLES WITH READ LOCK During PlannedReparentShard, the steps vitess takes to get replication position are basically (on the old master): 1. set @@global.read_only=true 2. FLUSH TABLES WITH READ LOCK 3. UNLOCK TABLES 4. SELECT @@GLOBAL.gtid_executed Steps 2 and 3 should not be necessary. After setting read_only=true, we should be able to get a consistent gtid_executed position. And FTWRL needs to wait for long running SELECTs to finish, so it seems unnecessarily expensive. By eliminating steps 2 and 3 we could reduce the amount of time that vitess is unable to serve queries. Signed-off-by: dleibovic go/vt/mysqlctl/fakemysqldaemon/fakemysqldaemon.go go/vt/mysqlctl/mysql_daemon.go go/vt/mysqlctl/reparent.go go/vt/vttablet/tabletmanager/rpc_replication.go go/vt/wrangler/testlib/planned_reparent_shard_test.go commit 2431ba11164af8582e4be5c5c05bed3a415bfb69 Author: Sugu Sougoumarane Date: Sun May 5 20:58:32 2019 -0700 consistent lookup: extend vindex API Add the ability to request the owner column names, which will be used to check for presence of owner row by the vindex. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/vindexes/vindex.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 91ea12e8e5748af3f569cac3f554539bd4046f0b Author: Sugu Sougoumarane Date: Sun May 5 19:36:42 2019 -0700 consistent lookup: commit order in Session Added two new shard sessions for commit ordering: pre and post. Added API to set the commit order and changed tx conn to honor it. Signed-off-by: Sugu Sougoumarane go/vt/proto/vschema/vschema.pb.go go/vt/proto/vtgate/vtgate.pb.go go/vt/proto/vtgateservice/vtgateservice.pb.go go/vt/vtexplain/testdata/multi-output/deletesharded-output.txt go/vt/vtexplain/testdata/multi-output/insertsharded-output.txt go/vt/vtexplain/testdata/multi-output/options-output.txt go/vt/vtexplain/testdata/multi-output/updatesharded-output.txt go/vt/vtgate/safe_session.go go/vt/vtgate/tx_conn.go go/vt/vtgate/tx_conn_test.go proto/vtgate.proto py/vtproto/vtgate_pb2.py commit f8115aae2852abfca34db6197e5c69aaf7412542 Author: Sugu Sougoumarane Date: Sun May 5 12:04:52 2019 -0700 consistent lookup: cleanup Session SafeSession and underlying session always non-nil. Append makes session not autocommitable. Remove legacy mode. Signed-off-by: Sugu Sougoumarane go/vt/vtexplain/vtexplain_vtgate.go go/vt/vtgate/executor.go go/vt/vtgate/executor_framework_test.go go/vt/vtgate/executor_select_test.go go/vt/vtgate/executor_stream_test.go go/vt/vtgate/executor_test.go go/vt/vtgate/safe_session.go go/vt/vtgate/scatter_conn.go go/vt/vtgate/scatter_conn_test.go go/vt/vtgate/tx_conn_test.go go/vt/vtgate/vtgate.go commit bf53e329e98336143be3e806fa2a74d9b6b58bb8 Author: Sugu Sougoumarane Date: Fri May 3 21:39:17 2019 -0700 v3: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/subquery.go commit 058e6b4139782a6e3d42dd2f0617d45b55a2d37a Author: Sugu Sougoumarane Date: Thu May 2 11:46:34 2019 -0700 v3: merge sort is not a route Fixes #4851 A route that performs a merge-sort should not be treated as a traditional route because many constructs cannot be pushed down into it. This change creates a pseudo-primitive to prevent this confusion. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/merge_sort.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt commit ee951f78e71dff26ce2761a95987523fdc90e9ad Author: Sugu Sougoumarane Date: Wed May 1 23:00:50 2019 -0700 v3: make all primitives implement ordering Just like the work done for grouping. All primitives have been changed to handle ORDER BY. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/postprocess.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/testdata/postprocess_cases.txt go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt go/vt/vtgate/planbuilder/testdata/vindex_func_cases.txt go/vt/vtgate/planbuilder/vindex_func.go commit 277e6b3f515f4355ff4b5641d1c647c9fbe67f7a Author: Sugu Sougoumarane Date: Wed May 1 17:43:03 2019 -0700 v3: make all primitives implement grouping The previous implementation separated out primitives that could handle grouping from those who couldn't. This new approach allows each primitive to make its own decision about whethere it can handle grouping or not. We still continue to perform the high level checks before pushing group by functions. This new approach will work better as our ability to handle more constructs evolve, because every primitive will have to find a way to make grouping work. Additionally, the order of primitives is now being maintained more accurately. This makes the code more future-proof. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/limit.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/postprocess.go go/vt/vtgate/planbuilder/pullout_subquery.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/subquery.go go/vt/vtgate/planbuilder/vindex_func.go commit 063625b3495a422bbf0b6679b42a767630eac2a3 Author: David Weitzman Date: Wed May 1 13:59:27 2019 -0700 vcopier: tweak "insert ... select" statements to support mysql56 The code previous generated statements like this: "insert into t1(c1,c2) select 1, 'foo' where ..." percona56 does not allow the implicit "from dual" in the above query. This PR changes these statements to explicitly select from dual: "insert into t1(c1,c2) select 1, 'foo' from dual where ..." Fixes #4852 Signed-off-by: David Weitzman go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go commit baa15c2571257ed2bd00cc9f38f0d748eeeaa6d2 Author: dleibovic Date: Tue Apr 30 20:35:37 2019 -0400 During PlannedReparentShard, use timeouts specified by -wait_slave_timeout for PromoteSlaveWhenCaughtUp Signed-off-by: dleibovic go/vt/vtctl/reparent.go go/vt/wrangler/reparent.go commit 62c77499636f9ac5852935a165f5c6aff2bedc02 Author: Dan Kozlowski Date: Mon Apr 29 10:40:03 2019 -0700 Renaming flag for IP to more logical name Signed-off-by: Dan Kozlowski go/vt/dbconnpool/connection_pool.go commit 771649eee39d8535fdf6c9e3f17ebbb5dcf672e8 Author: Sugu Sougoumarane Date: Thu Apr 25 21:17:47 2019 -0700 vreplication: check error for FindTablesOrVindexes Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/testdata/from_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/vindexes/vschema.go commit 1dc064eda4a553a98f9d7f31b879d619336370c6 Author: Creed Haymond Date: Thu Apr 25 21:20:37 2019 -0600 bind_variables: bool to INT8 Signed-off-by: Creed Haymond go/sqltypes/bind_variables.go go/sqltypes/bind_variables_test.go go/sqltypes/value.go commit 3c69044dffcb82cebcb516c171c52a616f86174e Author: Dan Kozlowski Date: Thu Apr 25 14:45:17 2019 -0700 Implementing changes from PR feedback This changes the name of the setting to `pool_hostname_resolve_interval` and adds in a waitgroup to make sure the gofunc finishes before we close the pool Signed-off-by: Dan Kozlowski go/vt/dbconnpool/connection_pool.go go/vt/mysqlctl/mysqld.go commit 372b60609c67b020266b42d11e0ea4aedb8b9aea Author: Sugu Sougoumarane Date: Sat Apr 20 22:12:20 2019 -0700 vreplication: tablet type support for routing The routing rules allow any table name to be suffixed with tablet type, like 'ks.t@master'. If so, ks.t will match the rule only if the tablet type is the master. The tablet more general rule is matched only if the tablet type specicic rule does not match. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go go/vt/vtgate/planbuilder/plan_test.go go/vt/vtgate/planbuilder/testdata/from_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/queryz_test.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 9e982ea3af5542d533c1d5eeb444097cfc1eb8c9 Author: Mark Solters Date: Thu Apr 25 16:17:23 2019 -0400 Fix Percona 8.0 docker build process Signed-off-by: Mark Solters Makefile commit 1f0718d02676931afcf8ac38f2f0fd80de433f04 Author: Mark Solters Date: Thu Apr 25 14:03:33 2019 -0400 Fix docker build issues for MySQL 8 Signed-off-by: Mark Solters Makefile docker/k8s/Dockerfile commit 90e765e65f51158d206fda32a5b5db6d4faf3e1f Author: Sugu Sougoumarane Date: Sat Apr 20 12:49:32 2019 -0700 vreplication: planbuilder for reference tables Signed-off-by: Sugu Sougoumarane go/vt/topotools/rebuild_vschema_test.go go/vt/vtgate/engine/route_test.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/plan_test.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/route_option.go go/vt/vtgate/planbuilder/route_option_test.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/testdata/from_cases.txt go/vt/vtgate/planbuilder/testdata/postprocess_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/planbuilder/testdata/select_cases.txt go/vt/vtgate/vindexes/vschema.go commit 0291531ccd7af9b96aa86d0daa3f9edf3d95a66c Author: Sugu Sougoumarane Date: Sat Apr 20 10:45:54 2019 -0700 vreplication: prep code for SelectReference Also make SelectNext more type safe Signed-off-by: Sugu Sougoumarane go/vt/vtgate/engine/route.go go/vt/vtgate/engine/route_test.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/testdata/select_cases.txt go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 848afdcf3ba75ef6f4d243579e46e2bdf208f83e Author: Sugu Sougoumarane Date: Fri Apr 19 21:55:09 2019 -0700 vreplication: add reference type to vschema Signed-off-by: Sugu Sougoumarane go/vt/vtgate/vindexes/unicodeloosemd5.go go/vt/vtgate/vindexes/unicodeloosemd5_test.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 98d0428d51ae6e9191d45f6646ac929a839382ea Author: Andres Taylor Date: Thu Apr 25 15:13:27 2019 +0200 Clean up of tracing * Extracted the opentracing wrapper to it's own file * Commented all the public methods * gofmt/goimports * Made sure the two interceptor builders are similar Signed-off-by: Andres Taylor go/cmd/vtclient/plugin_opentracing.go go/cmd/vtcombo/plugin_opentracing.go go/cmd/vtctld/plugin_opentracing.go go/cmd/vtgate/plugin_opentracing.go go/cmd/vtqueryserver/plugin_opentracing.go go/cmd/vttablet/plugin_opentracing.go go/cmd/vtworker/plugin_opentracing.go go/trace/fake.go go/trace/jaeger.go go/trace/opentracing.go go/trace/trace.go go/trace/trace_test.go go/trace/utils.go go/vt/grpcclient/client.go go/vt/servenv/grpc_server.go go/vt/servenv/grpc_server_test.go commit 60b4643725017fa809e11c0d00a81e5cc5498586 Author: Andres Taylor Date: Wed Apr 24 15:09:10 2019 +0200 Fix problems with start of tracing Before this change, the GRPC server could get started before tracing had been initiated, which meant that the GRPC interceptors were not hooked up properly. Signed-off-by: Andres Taylor go/cmd/vtctl/plugin_opentracing.go go/cmd/vtctl/vtctl.go go/cmd/vtctlclient/main.go go/cmd/vtctlclient/plugin_opentracing.go go/cmd/vtctld/plugin_opentracing.go go/cmd/vtgate/plugin_opentracing.go go/cmd/vttablet/plugin_opentracing.go go/cmd/vtworker/plugin_opentracing.go go/trace/fake.go go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go go/vt/grpcclient/client.go go/vt/servenv/flushlogs.go go/vt/servenv/grpc_server.go go/vt/servenv/grpc_server_test.go go/vt/servenv/pid_file.go go/vt/servenv/pprof.go go/vt/servenv/purgelogs.go go/vt/servenv/servenv.go go/vt/servenv/service_map.go go/vt/vtgate/plugin_mysql_server.go commit 7fc566274511ed450744dcea2fab845ffb213f4f Author: Sugu Sougoumarane Date: Wed Apr 24 20:26:18 2019 -0700 vreplication: address review comments Signed-off-by: Sugu Sougoumarane go/vt/topo/helpers/compare_test.go go/vt/vtctl/vtctl.go go/vt/vtgate/planbuilder/builder.go commit b50f57c707ef1d976fa82c6e29ed48af497ba00d Author: SataQiu Date: Wed Apr 24 18:21:07 2019 +0800 fix some spelling mistakes Signed-off-by: SataQiu doc/VitessApi.md examples/helm/kmysql.sh go/cmd/automation_client/automation_client.go go/cmd/mysqlctl/mysqlctl.go go/cmd/vtctld/schema.go go/cmd/vtexplain/vtexplain.go commit c4c5712479d383680f84c27d0f6129bbee2a7287 Author: David Weitzman Date: Mon Apr 22 15:44:50 2019 -0700 tabletmanager: only report healthy if a health check has succeeded recently This logic already existed in go/cmd/vttablet/healthz.go for /healthz, but did not exist for broadcastHealth() and did not exist for deciding whether to return a cached health value to a newly-connected streaming health client. Signed-off-by: David Weitzman go/vt/vtctld/tablet_data_test.go go/vt/vttablet/endtoend/misc_test.go go/vt/vttablet/tabletmanager/state_change.go go/vt/vttablet/tabletserver/controller.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/vttablet/tabletservermock/controller.go commit 9ca18d53909c42e0158fb4623dcf2a17c1c3dff5 Author: Saif Alharthi Date: Wed Apr 24 10:30:30 2019 -0700 close goroutine Signed-off-by: Saif Alharthi go/mysql/auth_server_static.go commit f04b78589104bfef0b14458e986e56f5c074146e Author: Sugu Sougoumarane Date: Wed Apr 24 08:33:59 2019 -0700 vstreamer: bug fix on mysql connection The row streamer needed to refresh credentials before connecting to mysql. Also fixed some flaky tests. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go commit 11ed1a1e236d0e5f715531bba4604e240e9f5b3b Author: Sugu Sougoumarane Date: Fri Apr 19 15:44:09 2019 -0700 query routing: tests Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/delete.go go/vt/vtgate/planbuilder/expr.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/route_option.go go/vt/vtgate/planbuilder/route_option_test.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/symtab_test.go go/vt/vtgate/planbuilder/testdata/aggr_cases.txt go/vt/vtgate/planbuilder/testdata/dml_cases.txt go/vt/vtgate/planbuilder/testdata/filter_cases.txt go/vt/vtgate/planbuilder/testdata/from_cases.txt go/vt/vtgate/planbuilder/testdata/postprocess_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/planbuilder/testdata/select_cases.txt go/vt/vtgate/planbuilder/update.go commit 3c45413151c558e98601383d258fc857b2fb1205 Author: Sugu Sougoumarane Date: Wed Apr 17 22:30:03 2019 -0700 query routing: vschema and DML tests Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/delete.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/testdata/dml_cases.txt go/vt/vtgate/planbuilder/testdata/schema_test.json go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt go/vt/vtgate/planbuilder/update.go go/vt/vtgate/vindexes/vschema_test.go commit 80bd0c2d6d6ccceb924d4ff5bd92cd65bfa3a8a8 Author: Sugu Sougoumarane Date: Tue Apr 16 17:46:10 2019 -0700 query routing: add table substitutions The code has also been refactored and cleaned up for improved readability. Signed-off-by: Sugu Sougoumarane go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/delete.go go/vt/vtgate/planbuilder/expr.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/route_option.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/update.go commit e0f79ce5cfa112088e1e081f54f60e902de98fc9 Author: Sugu Sougoumarane Date: Mon Apr 15 19:11:12 2019 -0700 query routing: multi-table plan options In this change the query routing takes the possibility that there could be multiple target options for a given table. The design for this is explained in #4790. At a high level: * VSchema.FindTableOrVindex function can return a list of tables instead of a single one. * The route planbuilder creates multiple routeOptions, one for each table returned. * All actions that affected the plan of a route are changed to update all routeOptions. * If a particular routeOption cannot accommodate a pushed down construct, it's removed from the list. Previously, this was an error case. But if no options are left, then we return an error. * If two routeOptions qualify for a merge of routes, then all other combinations that don't qualify are discarded. This is the case for joins, subqueries and unions. More details: vindexTable was renamed to the more appropriate vschemaTable. In order to achieve this, a new routeOption data type was introduced, and route was changed to contain a list of routeOptions. In symtab, tables used to point at the vschema table that was used to build them. Since a table can now represent multiple target tables, this field has been moved into routeOption. In symtab, columns used to contain a vindex member. Since this can change depending on the target table, the routeOption now contains a map of column to vindexes instead. The routeOption also contains the vschemaTable. DMLs use this information. Since DMLs have to be more deterministic about the table they write to, they always choose the first option. At the beginning of the Wireup phase, we evaluate all existing options and decide on the best available. To be done: When a table has multiple targets, the targets can have different names than the original table. If so, the queries have to be rewritten to address the new target tables. In order to do this, each routeOption will contain a list of substitutions that will be made during the Wireup phase. Tests have to be written for the new flows. Signed-off-by: Sugu Sougoumarane go/vt/sqlparser/ast.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/limit_test.go go/vt/vtgate/engine/route.go go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/planbuilder/delete.go go/vt/vtgate/planbuilder/expr.go go/vt/vtgate/planbuilder/from.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/join.go go/vt/vtgate/planbuilder/ordered_aggregate.go go/vt/vtgate/planbuilder/plan_test.go go/vt/vtgate/planbuilder/postprocess.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/route_option.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/symtab.go go/vt/vtgate/planbuilder/symtab_test.go go/vt/vtgate/planbuilder/testdata/from_cases.txt go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt go/vt/vtgate/planbuilder/union.go go/vt/vtgate/planbuilder/update.go go/vt/vtgate/vcursor_impl.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go commit 3f8848a945e5d07e4198ca441afa3eac0c6cc4f8 Author: Sugu Sougoumarane Date: Wed Apr 10 15:33:17 2019 -0700 vschema: routing rules in vindexes.VSchema Signed-off-by: Sugu Sougoumarane go/vt/topo/server.go go/vt/vtgate/executor_test.go go/vt/vtgate/vindexes/binary.go go/vt/vtgate/vindexes/binary_test.go go/vt/vtgate/vindexes/binarymd5.go go/vt/vtgate/vindexes/hash.go go/vt/vtgate/vindexes/lookup_hash_test.go go/vt/vtgate/vindexes/lookup_hash_unique_test.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash_test.go go/vt/vtgate/vindexes/lookup_unique_test.go go/vt/vtgate/vindexes/null.go go/vt/vtgate/vindexes/numeric.go go/vt/vtgate/vindexes/numeric_static_map.go go/vt/vtgate/vindexes/reverse_bits.go go/vt/vtgate/vindexes/unicodeloosemd5.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go go/vt/vtgate/vtgate.go go/vt/vtgate/vtgate_test.go commit 08791180dc082a6d2c45d1bcd74217b67e436322 Author: Sugu Sougoumarane Date: Mon Apr 8 23:24:12 2019 -0700 vschema: routing rules proto changes This is the first part of the changes to implement #4790. This part implements all the management functionality for routing rules. Signed-off-by: Sugu Sougoumarane go/cmd/topo2topo/topo2topo.go go/vt/proto/vschema/vschema.pb.go go/vt/topo/helpers/compare.go go/vt/topo/helpers/compare_test.go go/vt/topo/helpers/copy.go go/vt/topo/helpers/copy_test.go go/vt/topo/locks.go go/vt/topo/server.go go/vt/topo/srv_keyspace.go go/vt/topo/test/file.go go/vt/topo/test/lock.go go/vt/topo/test/testing.go go/vt/topo/test/vschema.go go/vt/topo/test/watch.go go/vt/topo/vschema.go go/vt/topotools/rebuild_vschema.go go/vt/topotools/rebuild_vschema_test.go go/vt/vtctl/topo.go go/vt/vtctl/vtctl.go proto/vschema.proto py/vtproto/vschema_pb2.py commit 93b1e462bad23e2365b7201ed7d4988836e6e11d Author: Saif Alharthi Date: Mon Apr 22 16:19:06 2019 -0700 Modified test to stop ticker Signed-off-by: Saif Alharthi go/mysql/auth_server_static.go go/mysql/auth_server_static_test.go commit c36e3595d135ed5a476f1a3d9e55cff335ec539b Author: deepthi Date: Fri Apr 19 16:33:05 2019 -0700 staticcheck fixes Signed-off-by: deepthi go/cmd/vtgateclienttest/services/services.go go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/binlogplayer/fake_dbclient.go go/vt/binlog/binlogplayer/mock_dbclient.go go/vt/binlog/binlogplayertest/player.go go/vt/mysqlctl/cephbackupstorage/ceph.go go/vt/mysqlctl/grpcmysqlctlclient/client.go go/vt/mysqlctl/replication.go go/vt/mysqlctl/s3backupstorage/s3.go go/vt/mysqlctl/xtrabackupengine.go go/vt/schemamanager/schemaswap/schema_swap.go go/vt/topo/etcd2topo/election.go go/vt/topo/etcd2topo/server_test.go go/vt/topo/helpers/copy_test.go go/vt/topo/memorytopo/election.go go/vt/topo/memorytopo/file.go go/vt/topo/srv_keyspace.go go/vt/topo/test/file.go go/vt/topo/test/vschema.go go/vt/topo/test/watch.go go/vt/topo/topoproto/shard.go go/vt/topo/topotests/srv_keyspace_test.go go/vt/topo/zk2topo/file.go go/vt/vtaclcheck/vtaclcheck.go go/vt/vtctl/fakevtctlclient/fake_loggerevent_streamingclient.go go/vt/vtctl/vtctlclient/wrapper.go go/vt/vtctl/vtctlclienttest/client.go go/vt/vtexplain/vtexplain.go go/vt/vtgate/buffer/flags_test.go go/vt/vtgate/buffer/timeout_thread.go go/vt/vtgate/buffer/variables.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/limit_test.go go/vt/vtgate/engine/route.go go/vt/vtgate/executor_test.go go/vt/vtgate/fakerpcvtgateconn/conn.go go/vt/vtgate/grpcvtgateconn/conn_rpc_test.go go/vt/vtgate/grpcvtgateservice/server.go go/vt/vtgate/vindexes/binary.go go/vt/vtgate/vindexes/binary_test.go go/vt/vtgate/vindexes/binarymd5.go go/vt/vtgate/vindexes/hash.go go/vt/vtgate/vindexes/lookup_hash_test.go go/vt/vtgate/vindexes/lookup_hash_unique_test.go go/vt/vtgate/vindexes/lookup_test.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash_test.go go/vt/vtgate/vindexes/lookup_unique_test.go go/vt/vtgate/vindexes/null.go go/vt/vtgate/vindexes/numeric.go go/vt/vtgate/vindexes/numeric_static_map.go go/vt/vtgate/vindexes/reverse_bits.go go/vt/vtgate/vindexes/unicodeloosemd5.go go/vt/vtgate/vindexes/unicodeloosemd5_test.go go/vt/vtgate/vindexes/vschema.go go/vt/vtgate/vindexes/vschema_test.go go/vt/vtgate/vtgateconn/vtgateconn_test.go go/vt/vtgate/vtgateconntest/client.go go/vt/vttablet/sandboxconn/sandboxconn.go go/vt/vttablet/tabletmanager/init_tablet.go go/vt/vttablet/tabletserver/connpool/dbconn.go go/vt/vttablet/tabletserver/connpool/dbconn_test.go go/vt/vttablet/tabletserver/messager/message_manager_test.go go/vt/vttablet/tabletserver/planbuilder/plan.go go/vt/vttablet/tabletserver/rules/rules.go go/vt/vttablet/tabletserver/rules/rules_test.go go/vt/vttablet/tabletserver/schema/engine.go go/vt/vttablet/tabletserver/schema/load_table.go go/vt/vttablet/tabletserver/splitquery/split_params.go go/vt/vttablet/tabletserver/splitquery/splitter_test.go go/vt/vttablet/tabletserver/tabletenv/logstats.go go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go go/vt/worker/vtworkerclienttest/client_testsuite.go go/vt/workflow/resharding/workflow.go go/vt/workflow/reshardingworkflowgen/workflow.go go/vt/wrangler/testlib/fake_tablet.go go/vt/wrangler/testlib/reparent_external_test.go commit b827ab19d30d93169ce363d92aa833da74d28e38 Author: deepthi Date: Mon Apr 22 14:40:36 2019 -0700 default value for db_name to allow rolling deployment of multi-schema changes Signed-off-by: deepthi go/vt/mysqlctl/metadata_tables.go commit 78058b8c33b40b3d75e69739e31e228468a30279 Author: Sugu Sougoumarane Date: Mon Apr 22 14:35:27 2019 -0700 vreplication: refresh masters at end of splitclone Signed-off-by: Sugu Sougoumarane go/vt/wrangler/keyspace.go commit f0a9bc71a0e9e96d602ebc9b4888bf12827bab63 Author: xichengliudui Date: Thu Apr 11 03:03:51 2019 -0400 Using const() defines constants together Signed-off-by: xichengliudui update pull request Signed-off-by: xichengliudui update pull request Signed-off-by: xichengliudui go/vt/vttablet/tabletconntest/fakequeryservice.go go/vt/vttablet/tabletserver/rules/map_test.go go/vt/workflow/resharding/workflow.go go/vt/wrangler/cleaner.go test.go commit cf1e37d4c694eeff6e6078420e201e45b3d80813 Author: xichengliudui Date: Thu Apr 11 04:54:02 2019 -0400 Using const() defines constants together (part:2) Signed-off-by: xichengliudui update pull request Signed-off-by: xichengliudui update pull request Signed-off-by: xichengliudui go/vt/discovery/healthcheck.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/query.go go/vt/vtctl/throttler.go go/vt/vtctld/tablet_stats_cache.go go/vt/vtexplain/vtexplain.go go/vt/vtgate/engine/primitive.go go/vt/vtgate/executor_framework_test.go commit 1ab972b2298b6e3cb5a583b47175add66fad1390 Author: Sugu Sougoumarane Date: Thu Apr 4 21:13:33 2019 -0700 vreplication: SplitClone & VerticalSplitClone This is an alternate and experimental version where we replace the vtworker SplitClone and VerticalSplitClone with a vreplication based approach. I want to get this submitted so people can try this and provide feedback. If the performance is acceptable, then we can solidify this with more checks and tests. Signed-off-by: Sugu Sougoumarane examples/local/vttablet-up.sh go/vt/key/key.go go/vt/topo/keyspace.go go/vt/vtctl/vtctl.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/wrangler/keyspace.go commit 8e63c8143c56518e0452e6b645befe0824f55dec Author: Sugu Sougoumarane Date: Fri Apr 19 16:08:44 2019 -0700 vreplication: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/controller.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go commit 575395cdf5c1ff429e82aef7794e05a97b965c20 Author: Michael Demmer Date: Fri Apr 19 14:04:49 2019 -0700 remove misleading BEGIN / COMMIT QueryStats entries as well Signed-off-by: Michael Demmer go/vt/vttablet/tabletserver/tabletserver.go commit 547293004087f9aa74ee4611b66395643a0c90e9 Author: Michael Demmer Date: Fri Apr 19 13:58:03 2019 -0700 fix tests to handle the opt-in stack logging behavior Signed-off-by: Michael Demmer go/vt/vterrors/errors_test.go go/vt/vterrors/vterrors.go commit 6576d18eceb744851ebb566dbaf2ca81bb2f16c2 Author: Michael Demmer Date: Fri Apr 19 10:30:21 2019 -0700 properly suppress begin...commit in autocommit logs The previous (untested) implementation turned out to be in the wrong place in the TabletServer execution tier and did not properly log the actual statements being executed. Implement this the right way by returning the statements that were really executed out from the TxPool, then using those to determine whether or not to log the statement. Signed-off-by: Michael Demmer go/vt/vttablet/tabletserver/query_executor.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/vttablet/tabletserver/tx_engine.go go/vt/vttablet/tabletserver/tx_engine_test.go go/vt/vttablet/tabletserver/tx_executor.go go/vt/vttablet/tabletserver/tx_pool.go go/vt/vttablet/tabletserver/tx_pool_test.go commit 07f7fab5356ee33c11aeba40c48bef8aae220df1 Author: Michael Demmer Date: Fri Apr 19 10:00:14 2019 -0700 make the logging of stacks in errors an opt-in behavior Signed-off-by: Michael Demmer go/vt/vterrors/vterrors.go commit fffea26be3ea7cfb19ee6c2bee35304cce6e81a1 Author: Rafael Chacon Date: Thu Apr 18 16:21:44 2019 -0700 Adds timeouts for all kinds of statements. Power to the clients! Signed-off-by: Rafael Chacon go/vt/vtgate/engine/delete.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/update.go go/vt/vtgate/planbuilder/delete.go go/vt/vtgate/planbuilder/insert.go go/vt/vtgate/planbuilder/route.go go/vt/vtgate/planbuilder/select.go go/vt/vtgate/planbuilder/testdata/dml_cases.txt go/vt/vtgate/planbuilder/update.go commit e9917406ec8faf9ec3af74a39155940828b8ad1b Author: Alex Charis Date: Thu Apr 18 14:16:11 2019 -0400 normalizer: do not normalize in group by Signed-off-by: Alex Charis go/vt/sqlparser/normalizer.go commit 224b905c30c9ffd3e4e14bc46645547ec3d7daff Author: Andres Taylor Date: Thu Apr 18 12:03:13 2019 +0200 Start tracing after flags are parsed Signed-off-by: Andres Taylor go/cmd/vtclient/plugin_opentracing.go go/cmd/vtcombo/plugin_opentracing.go go/cmd/vtctl/plugin_opentracing.go go/cmd/vtctlclient/plugin_opentracing.go go/cmd/vtctld/plugin_opentracing.go go/cmd/vtgate/plugin_opentracing.go go/cmd/vtqueryserver/plugin_opentracing.go go/cmd/vttablet/plugin_opentracing.go go/cmd/vtworker/plugin_opentracing.go commit 1a62d2ce616eb009a64a7e09b484c4cfbdfb4f00 Author: Alex Charis Date: Wed Apr 17 22:59:26 2019 -0400 normalizer: do not normalize in order by Signed-off-by: Alex Charis go/vt/sqlparser/normalizer.go go/vt/sqlparser/normalizer_test.go commit 788434ff5fea90a7e65059f3f529ef960ed7bbec Author: Máximo Cuadros Date: Thu Apr 18 01:24:54 2019 +0200 sqlparser: support for SHOW SCHEMAS Signed-off-by: Máximo Cuadros go/vt/sqlparser/parse_test.go go/vt/sqlparser/sql.go go/vt/sqlparser/sql.y go/vt/sqlparser/token.go go/vt/vtgate/executor.go go/vt/vtgate/executor_test.go commit 1fba59e6ddca981b622b19023710915a943431bd Author: Sugu Sougoumarane Date: Wed Apr 17 10:47:00 2019 -0700 vreplication: address more review comments Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/vcopier.go commit 1b8c5962bd06dff40e3aa9f25a774ea9812cbbf1 Author: Sugu Sougoumarane Date: Tue Apr 9 17:10:35 2019 -0700 vreplication: address review comments Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/vttablet/grpcqueryservice/server.go go/vt/vttablet/grpctabletconn/conn.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go commit 11a8b306d983838495f03b7ce813af82d11625bf Author: Sugu Sougoumarane Date: Wed Mar 27 21:38:45 2019 -0700 vcopier: more tests and a few tweaks Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer_test.go go/vt/vttablet/tabletserver/vstreamer/vstreamer.go commit e7e2b5fc07c3cf4c606cf913374861202081d453 Author: Sugu Sougoumarane Date: Sun Mar 24 09:53:22 2019 -0700 vplayer: test copy and fix bugs Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go commit 9c15bbeafd433acc8088133705e167f0a489e8c1 Author: Sugu Sougoumarane Date: Sun Mar 17 21:55:01 2019 -0700 vplayer: copier player dance Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/binlogplayer/binlog_player_test.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit 9b4969991cf7e41817235f93ea44f6d757439fbf Author: Sugu Sougoumarane Date: Sun Mar 17 21:26:44 2019 -0700 vplayer: more robust position tracking Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go commit 856a196bc6b245541eb28b331460164ac85ef4e4 Author: Sugu Sougoumarane Date: Sun Mar 17 20:43:45 2019 -0700 vstreamer: rowstreamer locks the table Signed-off-by: Sugu Sougoumarane go/vt/proto/binlogdata/binlogdata.pb.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer_test.go go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go proto/binlogdata.proto py/vtproto/binlogdata_pb2.py commit 91bdf9355e09dedef0989f92a31fbea995f18f6a Author: Sugu Sougoumarane Date: Sun Mar 17 19:45:13 2019 -0700 vplayer: prep for integrating vcopier and vplayer Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/binlogplayer/binlog_player_test.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit 231c7defdc81682dd99cb18f47dfd2418575094d Author: Sugu Sougoumarane Date: Sun Mar 17 12:16:50 2019 -0700 vplayer: don't blindly update state to 'Running' Also, Error state is obsolete. So, we're not using it any more. Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit ec253457ce0dc1fff984ae54eaa44770144c848c Author: Sugu Sougoumarane Date: Sun Mar 17 10:54:50 2019 -0700 vplayer: handle lastpk based replication Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit 9692bf977c10588347b7a767e717756ab2fa33df Author: Sugu Sougoumarane Date: Sat Mar 16 13:02:32 2019 -0700 vplayer: improve naming of some types & vars Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/controller.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan.go go/vt/vttablet/tabletmanager/vreplication/replicator_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_copy_test.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go commit bfddb58a4f1db2dde619954d100ce394c89ae423 Author: Sugu Sougoumarane Date: Thu Mar 14 21:15:10 2019 -0700 vplayer: split: vreplicator, vplayer, vcopier Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/controller.go go/vt/vttablet/tabletmanager/vreplication/vcopier.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vreplicator.go go/vt/vttablet/tabletserver/tabletserver.go commit de5a2e33b146eea818c53852b134f6815e44eb20 Author: Sugu Sougoumarane Date: Sun Mar 10 22:44:31 2019 -0700 vplayer: copyTables: basic functionality working Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_copy_test.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/vttablet/tabletserver/vstreamer/engine.go commit c096533521fceaa6a90bdc418d7f034d7fa225d1 Author: Sugu Sougoumarane Date: Sun Mar 10 19:32:15 2019 -0700 vplayer: copyTables initial cut Signed-off-by: Sugu Sougoumarane go/vt/proto/binlogdata/binlogdata.pb.go go/vt/vtcombo/tablet_map.go go/vt/vttablet/grpctabletconn/conn.go go/vt/vttablet/queryservice/queryservice.go go/vt/vttablet/queryservice/wrapped.go go/vt/vttablet/sandboxconn/sandboxconn.go go/vt/vttablet/tabletconntest/fakequeryservice.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletserver/tabletserver.go proto/binlogdata.proto py/vtproto/binlogdata_pb2.py commit b74907881e124e37d3d102b5a43bc90c134dcb80 Author: Sugu Sougoumarane Date: Sun Mar 10 10:24:38 2019 -0700 vplayer: refactor query generation This refactor changes the insert format into the traditional 'values' syntax, which is reusable for bulk inserts during copying. We also generate a broken-up version of the insert to allow for those sub-parts to be composed into a bulk-insert statement. Signed-off-by: Sugu Sougoumarane go/vt/sqlparser/parsed_query.go go/vt/vttablet/tabletmanager/vreplication/player_plan.go go/vt/vttablet/tabletmanager/vreplication/player_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go commit d3d870daff6d07bfc58611f5692cd05a2b33bcc2 Author: Sugu Sougoumarane Date: Sat Mar 9 17:05:43 2019 -0800 vplayer: minor tweaks Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go commit 3d305589c4b167abb9253699c8cfa9923345be19 Author: Sugu Sougoumarane Date: Sun Mar 3 21:30:11 2019 -0800 vstreamer: rowStreamer for source tablet Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletserver/vstreamer/engine.go go/vt/vttablet/tabletserver/vstreamer/planbuilder.go go/vt/vttablet/tabletserver/vstreamer/planbuilder_test.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer.go go/vt/vttablet/tabletserver/vstreamer/rowstreamer_test.go go/vt/vttablet/tabletserver/vstreamer/vstreamer.go go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go commit 1d2d111be9daf452972aa04c6a4d9816f5ede62d Author: Sugu Sougoumarane Date: Sat Mar 2 22:28:02 2019 -0800 vstreamer: VStreamRows rpc method Signed-off-by: Sugu Sougoumarane go/vt/proto/binlogdata/binlogdata.pb.go go/vt/proto/queryservice/queryservice.pb.go go/vt/vtcombo/tablet_map.go go/vt/vttablet/grpcqueryservice/server.go go/vt/vttablet/grpctabletconn/conn.go go/vt/vttablet/queryservice/queryservice.go go/vt/vttablet/queryservice/wrapped.go go/vt/vttablet/sandboxconn/sandboxconn.go go/vt/vttablet/tabletconntest/fakequeryservice.go go/vt/vttablet/tabletserver/tabletserver.go proto/binlogdata.proto proto/queryservice.proto py/vtproto/binlogdata_pb2.py py/vtproto/queryservice_pb2.py py/vtproto/queryservice_pb2_grpc.py commit e7e8aea8eb40a2c8d357fca52b5cc1dfc1d96803 Author: Saif Alharthi Date: Wed Apr 17 10:23:58 2019 -0700 Fixed format and restore global value Signed-off-by: Saif Alharthi go/mysql/auth_server_static_test.go commit f23777db959c7bb6be128d091e81f47e04bbc2a8 Author: dleibovic Date: Wed Apr 17 11:30:49 2019 -0400 fix bug discovered by tests Signed-off-by: dleibovic go/vt/dbconfigs/dbconfigs.go commit 7329452df3b39a780ff62a1fa2431e327bbbdce4 Author: teejae Date: Wed Apr 17 14:12:37 2019 +0900 Add strong warning against production use to example init_db.sql file (#4815) * Add strong warning against production use to example init_db.sql file Signed-off-by: Toliver Jue config/init_db.sql commit 05c3c0a2687bf2fc5ace8670ca498d84e4062393 Author: Michael Demmer Date: Tue Apr 16 21:19:43 2019 -0700 omit misleading begin/commit logs in autocommit transactions Signed-off-by: Michael Demmer go/vt/vttablet/tabletserver/query_executor.go commit 139b49e351f0870319a5475350e1eaaf256a35eb Author: SataQiu Date: Wed Apr 17 11:57:25 2019 +0800 fix spelling mistake: conjonction -> conjunction Signed-off-by: SataQiu doc/VitessApi.md go/vt/proto/vtgateservice/vtgateservice.pb.go proto/vtgateservice.proto py/vtproto/vtgateservice_pb2_grpc.py commit 22715759405eb804a6feb0632195ed4b14bf0c96 Author: Dan Kozlowski Date: Tue Apr 16 16:02:01 2019 -0700 Implementing changes from feedback Adding locking around accessing host name and putting back connection to prevent leak Signed-off-by: Dan Kozlowski go/vt/dbconnpool/connection_pool.go commit 6f2e405bbb48b155a1796a753613e9dc788bf89d Author: Dan Kozlowski Date: Mon Apr 8 17:38:45 2019 -0700 Add in option to re-resolve DNS names This adds in the ability to re-resolve DNS names used in a connection of an external database. The default is to do nothing new. A new command line options `pool_hostname_update_rate` has been added that will resolve the hostnames used in each pool at the given rate and will force a reconnect if they have changed Signed-off-by: Dan Kozlowski go/mysql/client.go go/vt/dbconnpool/connection_pool.go go/vt/mysqlctl/fakemysqldaemon/fakemysqldaemon.go go/vt/mysqlctl/mysqld.go go/vt/vttablet/tabletserver/connpool/pool.go commit 068c5f8051343bb80834e99ee51f7301ed6ff2de Author: dleibovic Date: Tue Apr 16 17:40:41 2019 -0400 Apply vttablet command line flags regardless of whether the tablet is running in managed or non-managed mode. Addresses https://github.com/vitessio/vitess/issues/4654 Signed-off-by: dleibovic go/vt/dbconfigs/dbconfigs.go commit def7952d6bceafe7c021e8c76deb55ecc4ceb3b1 Author: Saif Alharthi Date: Tue Apr 9 11:22:55 2019 -0700 Added the ability to reload credentials for vtgate. Signed-off-by: Saif Alharthi go/mysql/auth_server_static.go go/mysql/auth_server_static_test.go commit 6235187379f522469125d8e87aa30500556be353 Author: Miriam Lauter Date: Tue Apr 9 15:50:51 2019 -0400 Add vttablet option to set super_read_only during planned reparent Signed-off-by: Miriam Lauter go/vt/mysqlctl/fakemysqldaemon/fakemysqldaemon.go go/vt/mysqlctl/mysql_daemon.go go/vt/mysqlctl/replication.go go/vt/vttablet/tabletmanager/rpc_replication.go commit a1d44b1b99a3843707e2b5575867c2a85837de5f Author: deepthi Date: Fri Apr 12 16:35:38 2019 -0700 use background context to restart mysqld after backup. fix and add logging Signed-off-by: deepthi go/vt/mysqlctl/builtinbackupengine.go go/vt/vttablet/tabletmanager/rpc_backup.go commit bdd7ab7d69a10e96028978a9fb95aa812fc69296 Author: dleibovic Date: Mon Apr 15 12:48:41 2019 -0400 Add support for json output in vtctl TopoCat command, updates from review Signed-off-by: dleibovic go/vt/vtctl/topo.go commit dddfc6f7b8bc90bc2f1d22fe367e1b2a90c753bd Author: SataQiu Date: Mon Apr 15 22:33:27 2019 +0800 fix some grammar issues Signed-off-by: SataQiu go/cacheservice/cacheservice.go go/memcache/memcache.go commit 3afcbbe34c7a1a18d70ee411a7030304124f0434 Author: Andres Taylor Date: Sun Apr 14 10:10:20 2019 +0200 Update copyright holders Signed-off-by: Andres Taylor go/cmd/vtclient/plugin_opentracing.go go/cmd/vtcombo/plugin_opentracing.go go/cmd/vtctl/plugin_opentracing.go go/cmd/vtctlclient/plugin_opentracing.go go/cmd/vtctld/plugin_opentracing.go go/cmd/vtctld/plugin_prometheusbackend.go go/cmd/vtgate/plugin_opentracing.go go/cmd/vtgate/plugin_prometheusbackend.go go/cmd/vtqueryserver/plugin_opentracing.go go/cmd/vttablet/plugin_opentracing.go go/cmd/vttablet/plugin_prometheusbackend.go go/cmd/vtworker/plugin_opentracing.go go/cmd/vtworker/plugin_prometheusbackend.go go/stats/safe_label.go go/vt/vtgate/engine/delete.go go/vt/vtgate/engine/delete_test.go go/vt/vtgate/engine/fake_vcursor_test.go go/vt/vtgate/engine/insert.go go/vt/vtgate/engine/insert_test.go go/vt/vtgate/engine/join_test.go go/vt/vtgate/engine/route_test.go go/vt/vtgate/engine/subquery_test.go go/vt/vtgate/engine/update.go go/vt/vtgate/engine/update_test.go go/vt/vtgate/vschemaacl/vschemaacl.go go/vt/vtgate/vschemaacl/vschemaacl_test.go go/vt/vttablet/tabletserver/planbuilder/permission.go go/vt/vttablet/tabletserver/planbuilder/permission_test.go commit d7c7feb95d944fee6601fe4d4ceb0bd58d7afde1 Merge: f3bfe8b41 738f988cb Author: Deepthi Sigireddi Date: Fri Apr 12 11:35:16 2019 -0700 Merge pull request #4800 from SataQiu/fix-20190410 Fix some spell problems of doc/ServerConfiguration.md doc/TopologyService.md commit d507fef7b9f8a6992f4056ff8b51b50402719e29 Author: Andres Taylor Date: Fri Apr 12 17:23:45 2019 +0200 Removing trace.NewClientSpan Since we are not really following the OT conventions for span annotation, I'm removing this method. Signed-off-by: Andres Taylor go/trace/trace.go go/vt/vtgate/executor.go go/vt/vttablet/tabletserver/connpool/dbconn.go commit 459756c74d21575ec37925fc7213c757448f5a33 Author: Andres Taylor Date: Fri Apr 12 11:04:53 2019 +0200 Fixups after peer review Signed-off-by: Andres Taylor go/trace/trace.go go/trace/trace_test.go go/vt/worker/instance.go commit b3345fd2c3ad1385e950fc38c3d1a96a105b133b Merge: 6dcdcb460 f3bfe8b41 Author: Andres Taylor Date: Fri Apr 12 10:57:57 2019 +0200 Merge remote-tracking branch 'upstream/master' into tracing * upstream/master: (58 commits) add support for explicit transactions add support to set -queryserver-passthrough-dmls and other tablet params fix typo of doc/VTTabletModes.md Update lite images to retry pulling GPG keys add mysql80 flavor to vttest add auth config, add MySQL80 flavor handling in mysqld MySQL 8.0 should be started with mysqlx=0 use xtrabackup exit status to determine success/failure, address other review comments detect MySQL_FLAVOR from a db connection instead of env variable testcase to verify that GTIDSet is handled correctly by xtrabackup backup and restore better option documentation, make xtrabackupUser a required param for using xtrabackup, loop through existing backups to find the most recent good backup handle gtid correctly during restore, add logging for testing pass --target-dir to xtrabackup make MySQL56 default flavor for parsing replication position while restoring xtrabackup add xtrabackup_user command line option, use vterrors, fix staticcheck warnings fix scoping bug that causes backup to hang fix failing test by putting it in a separate suite add position and cmd line params to manifest add xtrabackup to docker containers create MANIFEST, use vterrors ... commit 4c355fcf3f758a3901761a5f9cac0d80fb76b92d Author: deepthi Date: Thu Apr 11 19:10:35 2019 -0700 fix migration Signed-off-by: deepthi go/vt/binlog/binlogplayer/binlog_player.go go/vt/mysqlctl/metadata_tables.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go commit f3bfe8b414dfe3aede461bc4f80af9a09cb25cfd Merge: 56e818697 1cd2ad129 Author: Deepthi Sigireddi Date: Thu Apr 11 10:27:42 2019 -0700 Merge pull request #4695 from planetscale/ds-xtrabackup xtrabackup implementation with testcases commit 666e492097139c04c777a3b7f60027db9751a93f Author: xichengliudui Date: Thu Apr 11 00:56:34 2019 -0400 Small bug: Comments and function names do not match Signed-off-by: xichengliudui go/vt/vtgate/planbuilder/builder.go go/vt/vtgate/vindexes/lookup_unicodeloosemd5_hash_test.go go/vt/vtgate/vtgateconntest/client.go commit 56e818697595d0566aba2a15aafa629fc1b0d039 Merge: eea2ebe89 3fed76017 Author: Michael Demmer Date: Wed Apr 10 16:40:46 2019 -0700 Merge pull request #4796 from tinyspeck/vtexplain-improvements vtexplain improvements commit 864727675f6be6f6937002a0da7b52618dcec5a3 Author: xichengliudui Date: Wed Apr 10 17:01:11 2019 -0400 Using const() defines constants together Signed-off-by: xichengliudui go/mysql/flavor.go commit eea2ebe899de3ced67045680766a25215c3aaa1a Merge: 8799db916 0912fbe1a Author: Daniel Kozlowski Date: Wed Apr 10 10:30:48 2019 -0700 Merge pull request #4794 from planetscale/dk-update-lite-docker-builds Update lite images to retry pulling GPG keys commit c0e1b8d05f5c32aab64611d1066fccf290a44ef4 Author: deepthi Date: Tue Apr 9 17:54:39 2019 -0700 add dbName to new binlogplayer func to fix test after rebase Signed-off-by: deepthi go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/vplayer_copy_test.go commit bfdaee71e614e78abc87f5e081fe92387b56bbec Author: deepthi Date: Tue Apr 9 16:19:05 2019 -0700 testcase with multiple keyspaces on same mysql Signed-off-by: deepthi go/vt/worker/split_diff.go test/base_sharding.py test/config.json test/initial_sharding_multi.py test/tablet.py commit baeb4f233dcfed3d96391b6529f4cd14d65ce08b Author: deepthi Date: Thu Mar 28 22:49:11 2019 -0700 migration for vreplication, local_metadata and shard_metadata tables Signed-off-by: deepthi go/vt/binlog/binlogplayer/binlog_player.go go/vt/mysqlctl/metadata_tables.go go/vt/vttablet/tabletmanager/init_tablet_test.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/wrangler/testlib/backup_test.go commit 0985ddd80f1e02fd64b1f7344fcb8dbe56d502aa Author: deepthi Date: Mon Mar 25 08:22:28 2019 -0700 add db_name to _vt.local_metadata and _vt.shard_metadata Signed-off-by: deepthi config/init_db.sql go/vt/mysqlctl/backup.go go/vt/mysqlctl/metadata_tables.go go/vt/schemamanager/schemaswap/schema_swap.go go/vt/vttablet/tabletmanager/init_tablet.go go/vt/wrangler/schema.go go/vt/wrangler/testlib/copy_schema_shard_test.go commit 26b641667b85f0a2fb0f240a8ac16cd5f37b5d88 Author: deepthi Date: Sun Mar 24 08:37:41 2019 -0700 fix unit test for _vt.vreplication changes Signed-off-by: deepthi go/vt/wrangler/testlib/migrate_served_types_test.go commit 7d28af4ea1b17cb654efd70d05d92d3dcdabd8dc Author: deepthi Date: Fri Mar 22 21:20:52 2019 -0700 set dbName correctly on vreplication engine Signed-off-by: deepthi go/vt/vttablet/tabletmanager/action_agent.go test/resharding.py commit ba9eecc60853d86c8841998e5282f47fac457714 Author: deepthi Date: Mon Mar 18 20:37:38 2019 -0700 add db_name to _vt.vreplication table Signed-off-by: deepthi go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/binlogplayer/binlog_player_test.go go/vt/vttablet/tabletmanager/action_agent.go go/vt/vttablet/tabletmanager/init_tablet_test.go go/vt/vttablet/tabletmanager/vreplication/engine.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/worker/legacy_split_clone.go go/vt/worker/split_clone.go go/vt/wrangler/keyspace.go go/vt/wrangler/testlib/migrate_served_from_test.go go/vt/wrangler/testlib/migrate_served_types_test.go commit 8799db9169eaffddfc043196a07bb246d4411bb0 Merge: 6df9ebeb8 d409c44b1 Author: Derek Perkins Date: Tue Apr 9 13:31:17 2019 -0600 Merge pull request #4725 from planetscale/ds-mysql80-docker MySQL 8.0 should be started with mysqlx=0 commit 3fed76017056bb84d2a18289306016af1ff40565 Author: Michael Demmer Date: Tue Apr 9 07:20:47 2019 -0700 add support for explicit transactions Signed-off-by: Michael Demmer go/vt/vtexplain/testdata/multi-output/updatesharded-output.txt go/vt/vtexplain/testdata/updatesharded-queries.sql go/vt/vtexplain/vtexplain.go go/vt/vtexplain/vtexplain_vttablet.go commit f0fc5c2b67bc1bb8a0b7f84e2488c48cedee6a53 Author: Michael Demmer Date: Tue Apr 9 07:20:14 2019 -0700 add support to set -queryserver-passthrough-dmls and other tablet params Signed-off-by: Michael Demmer go/cmd/vtexplain/vtexplain.go go/vt/vtexplain/vtexplain_vttablet.go commit 595448a530d3cae1a93432eadc804b00ae89f8c0 Author: deepthi Date: Fri Mar 15 12:16:22 2019 -0700 add auth config, add MySQL80 flavor handling in mysqld Signed-off-by: deepthi config/mycnf/master_mysql80.cnf go/vt/mysqlctl/mysqld.go commit 1cd2ad129dc261e8fa13a62e913348647adbc530 Author: deepthi Date: Mon Apr 8 15:09:08 2019 -0700 use xtrabackup exit status to determine success/failure, address other review comments Signed-off-by: deepthi docker/bootstrap/Dockerfile.mariadb docker/bootstrap/Dockerfile.mysql56 docker/bootstrap/Dockerfile.mysql80 go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/replication.go go/vt/mysqlctl/xtrabackupengine.go go/vt/vttablet/tabletmanager/rpc_backup.go test/backup.py commit e918b5c0d31737ba847d94085c4f8b2e7debcfa2 Author: deepthi Date: Fri Mar 29 15:07:36 2019 -0700 detect MySQL_FLAVOR from a db connection instead of env variable Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go commit 39c859b1c8493eeea9e86958e38b3921902c7801 Author: deepthi Date: Thu Mar 28 14:33:30 2019 -0700 better option documentation, make xtrabackupUser a required param for using xtrabackup, loop through existing backups to find the most recent good backup Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go test/xtrabackup_xtra.py commit d6e446fad2063b30580fa4df2fdf797fac384192 Author: deepthi Date: Wed Mar 27 15:09:09 2019 -0700 handle gtid correctly during restore, add logging for testing Signed-off-by: deepthi go/vt/mysqlctl/replication.go go/vt/mysqlctl/xtrabackupengine.go commit 359fbe2f9b8188e8f41a1bc8d0ea3c8c218a5fc7 Author: deepthi Date: Fri Mar 22 22:37:14 2019 -0700 pass --target-dir to xtrabackup Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go commit 3b96754d35282992c7082b75d5f2e6e2c6dda1b7 Author: deepthi Date: Fri Mar 22 22:09:59 2019 -0700 make MySQL56 default flavor for parsing replication position while restoring xtrabackup Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go test/xtrabackup_xtra.py commit b8112ed68b18df8b0c2172d47fa437a765f792cf Author: deepthi Date: Wed Mar 20 18:46:55 2019 -0700 add xtrabackup_user command line option, use vterrors, fix staticcheck warnings Signed-off-by: deepthi go/vt/mysqlctl/backup.go go/vt/mysqlctl/xtrabackupengine.go test/backup.py commit 706807f6e9de14dfa340cf8303a21cfcbad4b684 Author: deepthi Date: Wed Mar 20 18:15:56 2019 -0700 fix scoping bug that causes backup to hang Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go commit 3d8442af415b863c58038e1bc035cd4f8768809b Author: deepthi Date: Wed Mar 13 18:38:40 2019 -0700 add position and cmd line params to manifest Signed-off-by: deepthi go/vt/mysqlctl/xtrabackupengine.go commit 9a647b97cc9b6213d8f9ccf7f3c6497f8ae0c9e8 Author: deepthi Date: Tue Mar 12 20:19:38 2019 -0700 create MANIFEST, use vterrors Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go go/vt/mysqlctl/builtinbackupengine.go go/vt/mysqlctl/xtrabackupengine.go commit 9c3cd814842fe1c5e89ae93fbd53eef95fedd759 Author: deepthi Date: Wed Mar 6 16:10:10 2019 -0800 implement vttablet staying in SERVING state during backup Signed-off-by: deepthi go/vt/mysqlctl/backupengine.go go/vt/vttablet/tabletmanager/rpc_backup.go commit a43472057651b3a5ffdf198e31306f2325bc21b7 Author: deepthi Date: Fri Mar 1 17:42:12 2019 -0800 xtrabackup implementation with testcases Signed-off-by: deepthi config/mycnf/default-fast.cnf go/vt/mysqlctl/xtrabackupengine.go test/backup.py test/config.json test/xtrabackup.py test/xtrabackup_xbstream.py commit eec48b9792ad8e6e104e814b5c802b43ecff0ef0 Author: Sugu Sougoumarane Date: Sun Apr 7 11:04:21 2019 -0700 vreplication: address review comments Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go commit ac0a347dad6a24d42b6126bee98e23c27c5318c8 Author: Sugu Sougoumarane Date: Fri Mar 1 19:34:43 2019 -0800 vplayer: table initialization phase Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/binlog/binlogplayer/binlog_player_test.go go/vt/vttablet/tabletmanager/vreplication/controller_test.go go/vt/vttablet/tabletmanager/vreplication/engine_test.go go/vt/vttablet/tabletmanager/vreplication/framework_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go go/vt/vttablet/tabletmanager/vreplication/vplayer_copy_test.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/wrangler/keyspace.go commit 4244cece2f4ed96fe50a13b0865dbc67961d8dbd Author: Sugu Sougoumarane Date: Sun Feb 24 20:52:56 2019 -0800 vreplication: convert to always use select vplayer used to previously pass through the regular expressions. With this change, regular expressions are only used to identify target tables. And then, the request sent to vstreamer requests specific table names and the filter is converted to use select statememnts. Signed-off-by: Sugu Sougoumarane go/vt/vttablet/tabletmanager/vreplication/player_plan_test.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer_test.go go/vt/vttablet/tabletserver/vstreamer/planbuilder.go go/vt/vttablet/tabletserver/vstreamer/planbuilder_test.go commit 0694a075dac8712d9c5d457a54bb75be47c4f343 Author: Sugu Sougoumarane Date: Sun Feb 24 11:22:44 2019 -0800 vplayer: filter based on target Signed-off-by: Sugu Sougoumarane go/vt/binlog/binlogplayer/binlog_player.go go/vt/vttablet/tabletmanager/vreplication/player_plan.go go/vt/vttablet/tabletmanager/vreplication/table_plan_builder.go go/vt/vttablet/tabletmanager/vreplication/vplayer.go commit 0604d560b84fb2423cf40d69ed3393c9b06432b4 Author: Anthony Yeh Date: Thu Apr 4 16:24:55 2019 -0700 orchestrator: Add more detail to error messages. Signed-off-by: Anthony Yeh go/vt/vttablet/tabletmanager/orchestrator.go commit 17f6a20790bb21896e53e25ac6fcfe1df17c4757 Author: Rafael Chacon Date: Thu Apr 4 15:24:20 2019 -0700 Fix documentation for command Signed-off-by: Rafael Chacon go/vt/vtctl/vtctl.go commit dd8115739492bc2397e28aaab0a97400e6126e7d Author: Rafael Chacon Date: Thu Apr 4 15:01:39 2019 -0700 Refactor SetShardServingTypes into SetShardIsMasterServing Signed-off-by: Rafael Chacon doc/vtctlReference.md go/vt/topo/locks.go go/vt/vtctl/vtctl.go go/vt/wrangler/shard.go commit f81ef4abbb0ee1c36f358e17894fa573a558c32a Author: Rafael Chacon Date: Wed Apr 3 08:27:37 2019 -0700 Update documentation for CellsAlias commands Signed-off-by: Rafael Chacon go/vt/vtctl/cells_aliases.go commit 3e62b1b95fe98dfa97db1f0b880c0e750edda930 Author: Michael Pawliszyn Date: Tue Apr 2 11:40:15 2019 +1100 Limit the connection retry delay to no longer than the healthcheck timeout. Signed-off-by: Michael Pawliszyn go/vt/discovery/healthcheck.go commit 19b7a38c35ad21f16b443eed5f4033b51a8f9945 Author: tpetr Date: Tue Apr 2 12:15:22 2019 -0400 forgot some stuff Signed-off-by: tpetr go/cmd/vtgate/plugin_auth_clientcert.go go/mysql/auth_server_clientcert.go commit 2d19dccae147c5c038139358454ad3d61ae9b015 Author: tpetr Date: Tue Apr 2 11:03:32 2019 -0400 PR feedback + add tests + light refactoring Signed-off-by: tpetr go/mysql/auth_server_clientcert.go go/mysql/auth_server_clientcert_test.go commit 6dcdcb46077b80f641a80cb5928db29ce07da71c Author: Andres Taylor Date: Tue Apr 2 11:58:22 2019 +0200 Change how SQL queries are added to trace spans Signed-off-by: Andres Taylor go/trace/trace.go go/trace/trace_test.go go/trace/utils.go go/vt/vtgate/executor.go go/vt/vttablet/tabletserver/connpool/dbconn.go go/vt/vttablet/tabletserver/query_executor.go go/vt/vttablet/tabletserver/tabletserver.go commit 5f8dc86bda52f3e4a0d14426d1de10f2d7201ef6 Author: Rafael Chacon Date: Mon Apr 1 17:04:08 2019 -0700 Adds tests and fixes typo in vtctl command Signed-off-by: Rafael Chacon go/vt/topo/cells_aliases.go go/vt/vtctl/cells_aliases.go test/cell_aliases.py test/cell_no_aliases.py test/config.json test/utils.py commit 20c3f4b160778ed155568bf37f205b21fb1c0387 Author: dleibovic Date: Mon Apr 1 13:06:08 2019 -0400 Add support for json output in vtctl TopoCat command Signed-off-by: dleibovic go/cmd/zk/zkcmd.go go/vt/vtctl/topo.go go/vt/vtctld/explorer.go commit 2c63167f11b88d9dbd786f4249b35bc9298628a5 Author: Rafael Chacon Date: Thu Mar 28 08:58:37 2019 -0700 Refactor region to aliases * Deprecate the concept of regions. * Favor aliases instead Signed-off-by: Rafael Chacon go/vt/discovery/tablet_stats_cache.go go/vt/discovery/tablet_stats_cache_test.go go/vt/proto/topodata/topodata.pb.go go/vt/topo/cells_aliases.go go/vt/topo/server.go go/vt/topo/topotests/cells_aliases_test.go go/vt/vtctl/cell_info.go go/vt/vtctl/cells_aliases.go go/vt/vtgate/gateway/discoverygateway_test.go proto/topodata.proto py/vtproto/topodata_pb2.py commit cdea8585f9cbcbc2f3d97838893bfab049e39699 Author: Andres Taylor Date: Fri Mar 29 08:35:24 2019 +0100 Move out start of tracing to plugin files Signed-off-by: Andres Taylor go/cmd/vtclient/plugin_opentracing.go go/cmd/vtclient/vtclient.go go/cmd/vtcombo/main.go go/cmd/vtcombo/plugin_opentracing.go go/cmd/vtctl/plugin_opentracing.go go/cmd/vtctl/vtctl.go go/cmd/vtctlclient/main.go go/cmd/vtctlclient/plugin_opentracing.go go/cmd/vtctld/main.go go/cmd/vtctld/plugin_opentracing.go go/cmd/vtgate/plugin_opentracing.go go/cmd/vtgate/vtgate.go go/cmd/vtqueryserver/plugin_opentracing.go go/cmd/vtqueryserver/vtqueryserver.go go/cmd/vttablet/plugin_opentracing.go go/cmd/vttablet/vttablet.go go/cmd/vtworker/plugin_opentracing.go go/cmd/vtworker/vtworker.go go/trace/utils.go commit 96a1e3109fe375533229097e7214cacb8ba389c9 Author: Andres Taylor Date: Thu Mar 28 13:54:12 2019 +0100 Hide OpenTracing better Signed-off-by: Andres Taylor go/trace/fake.go go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go go/vt/servenv/grpc_server.go commit b65c791035d9619538bd3747ef299b2e0317493b Author: Alec Thomas Date: Mon Mar 11 13:18:55 2019 +1100 Move pool trace stats up a level. Signed-off-by: Andres Taylor Signed-off-by: Alec Thomas go/vt/vttablet/tabletserver/connpool/pool.go commit 50e1eb912a5b4226d84c1a010327519daf6b7aae Author: Alec Thomas Date: Fri Mar 8 08:50:12 2019 +1100 Instrument more of vttab with tracing spans. Signed-off-by: Andres Taylor Signed-off-by: Alec Thomas go/pools/resource_pool.go go/vt/vttablet/tabletserver/connpool/pool.go go/vt/vttablet/tabletserver/tx_engine.go go/vt/vttablet/tabletserver/tx_pool.go commit ec483e45d3c87869f3cebfc6a005f554fd4ee7aa Author: Andres Taylor Date: Wed Mar 20 10:55:24 2019 -0700 Move tracing grpc code to the trace package Signed-off-by: Andres Taylor go/trace/trace.go go/vt/grpcclient/client.go go/vt/schemamanager/schemaswap/schema_swap.go go/vt/servenv/grpc_server.go commit f0934d0e719fe0c6d8eb68fe213f2c03e51b863e Author: Andres Taylor Date: Wed Mar 20 10:38:02 2019 -0700 Remove span type since it was not being used much Signed-off-by: Andres Taylor go/trace/fake.go go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go go/vt/topo/locks.go go/vt/topo/replication.go go/vt/topo/shard.go go/vt/topo/tablet.go go/vt/vtctld/workflow.go go/vt/vttablet/tabletmanager/state_change.go go/vt/vttablet/tabletserver/query_engine.go go/vt/vttablet/tabletserver/query_executor.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/worker/instance.go commit 487135e5f818a01720cae0db414f5d204a960ae0 Author: Andres Taylor Date: Wed Mar 20 10:21:42 2019 -0700 Document an interface Signed-off-by: Andres Taylor go/trace/trace.go commit 2b5246411281d3db7bad5fcede149f85636a0805 Author: Andres Taylor Date: Wed Mar 20 10:19:13 2019 -0700 gofmt code Signed-off-by: Andres Taylor go/trace/fake.go go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go go/trace/utils.go commit c9dcd5a65be9236a2e62ce12a56184a009a725c2 Author: Andres Taylor Date: Wed Mar 13 08:09:49 2019 +0100 Improved how to register new tracing backends Signed-off-by: Andres Taylor go/trace/fake.go go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go commit c7d1856ddac8573dc66aabc62f5b349e4920e64c Author: Andres Taylor Date: Mon Mar 11 13:20:09 2019 +0100 Make sure to pass on contexts between calls Span information is passed between function calls inside of the context object. To make sure that down-stream calls in the call graph have the correct information, it's necessary to send the context in a lot of places. Signed-off-by: Andres Taylor go/vt/discovery/topology_watcher.go go/vt/discovery/topology_watcher_test.go go/vt/schemamanager/schemaswap/schema_swap.go go/vt/vtctld/realtime_status.go go/vt/vtctld/workflow.go go/vt/vtexplain/vtexplain_vtgate.go go/vt/vtgate/gateway/discoverygateway.go go/vt/vtgate/gateway/discoverygateway_test.go go/vt/vtgate/gateway/gateway.go go/vt/vtgate/gatewaytest/grpc_discovery_test.go go/vt/vtgate/scatter_conn_test.go go/vt/vtgate/vtgate.go go/vt/vttablet/tabletmanager/state_change.go go/vt/vttablet/tabletmanager/vreplication/controller.go go/vt/vttablet/tabletmanager/vreplication/tablet_picker.go go/vt/vttablet/tabletmanager/vreplication/tablet_picker_test.go go/vt/vttablet/tabletserver/connpool/dbconn.go go/vt/vttablet/tabletserver/query_executor.go go/vt/vttablet/tabletserver/tabletserver.go go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go go/vt/worker/instance.go go/vt/worker/legacy_split_clone.go go/vt/worker/split_clone.go go/vt/worker/topo_utils.go go/vt/wrangler/keyspace.go commit 2b4fc22d2efaf64822aad0c90e1c75b0b5491fd1 Author: Andres Taylor Date: Mon Mar 11 15:30:15 2019 +0100 Mark client calls to servers as such Signed-off-by: Andres Taylor go/trace/fake.go go/trace/trace.go go/trace/utils.go go/vt/vtgate/executor.go go/vt/vttablet/tabletserver/connpool/dbconn.go commit 4c4bf8d8846ff8987ee3d7c81dfcd01e79103e3f Author: Andres Taylor Date: Mon Mar 11 15:13:20 2019 +0100 Start tracing when starting processes Signed-off-by: Andres Taylor go/cmd/vtclient/vtclient.go go/cmd/vtcombo/main.go go/cmd/vtctl/vtctl.go go/cmd/vtctlclient/main.go go/cmd/vtctld/main.go go/cmd/vtgate/vtgate.go go/cmd/vtqueryserver/vtqueryserver.go go/cmd/vttablet/vttablet.go go/cmd/vtworker/vtworker.go go/trace/trace.go commit dd0b5ba9173eef3616aca9287f6d3f57bde5488d Author: Andres Taylor Date: Mon Mar 11 14:26:13 2019 +0100 Add tracing to GRPC end points Make sure to send span information when doing grpc call, and retrieving span information when running a grpc server. Signed-off-by: Andres Taylor go/vt/grpcclient/client.go go/vt/servenv/grpc_server.go commit 4392122102d12407412aff26cae205653262e1a5 Author: Andres Taylor Date: Mon Mar 11 13:45:44 2019 +0100 Change the internal tracing API The old API had an issue with contexts not being passed around correctly. This new API should make it easier to remember to do it correctly. Signed-off-by: Andres Taylor go/trace/jaeger.go go/trace/trace.go go/trace/trace_test.go go/vt/topo/locks.go go/vt/topo/replication.go go/vt/topo/shard.go go/vt/topo/tablet.go go/vt/vttablet/tabletmanager/state_change.go go/vt/vttablet/tabletserver/connpool/dbconn.go go/vt/vttablet/tabletserver/query_engine.go go/vt/vttablet/tabletserver/query_executor.go commit 28d85424465844069a2df4829130abb84b44e316 Author: tpetr Date: Mon Feb 4 14:23:04 2019 -0500 ensure that -mysql_server_ssl_ca is set when using the cliencert auth plugin Signed-off-by: tpetr go/mysql/clientcert/auth_server_clientcert.go commit a5304daa02e9ddfd6cd107f7dd3fe94736887072 Author: tpetr Date: Mon Jan 7 12:54:49 2019 -0500 add support for client cert auth for mysql protocol connections Signed-off-by: tpetr go/cmd/vtgate/plugin_auth_clientcert.go go/mysql/clientcert/auth_server_clientcert.go go/mysql/conn.go