Support for GitLab API 4 - Use docker for testing #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to Maven in travis because releases are built with Maven anyway * Introduce Maven-Wrapper to fixate the used Maven version. * Reuse existing GitlabAPITest as integration test which will be run always when docker is available. * Use docker-maven-plugin for starting/stopping GitLab. * For use with Maven run `mvn -Pdocker-gitlab clean verify`. Starting GitLab takes a long time (>100 seconds on my Macbook Pro). * For use in the IDE run: ``` mvn -Pdocker-gitlab,docker-ide docker:start mvn -Pdocker-gitlab,docker-ide docker:stop ```
* username/password sessions per time unit are limited
AssertionError in Tests is only available for >= JDK7
Need to throw AssumptionViolatedException in BeforeClass because otherwise the class is not initialized correctly.
|
@mfriedenhagen this is fantastic. Great work. How do you feel about adding the travisci widget for the README? I'll get travisci added for this repo as well. Do you think this is ready to merge? |
* block/unblock uses POST instead of PUT. * Add ability to refine permissions for branch protection. * Add ability to add deploy key with push permission.
|
When we can expect the new java-Gitlab_api version which is supported Gitlab API V4 |
|
@timols, I just tried to check all changes as outlined in https://gitlab.com/help/api/v3_to_v4.md, but there are loads.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup based on #206 (Java-API changes are all from this PR) for implementing #201.
Tests are already running successfully using gitlab-ce in Docker on Travis. As I am much more familiar with Maven than Gradle and because releases seem to be done with Maven anyway, I switched the build constructions in Travis to use Maven as well.