Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API v4 #201

Closed
tomasbjerre opened this issue Mar 27, 2017 · 8 comments
Closed

Support API v4 #201

tomasbjerre opened this issue Mar 27, 2017 · 8 comments

Comments

@tomasbjerre
Copy link
Contributor

V3 is deprecated; https://about.gitlab.com/2017/03/22/gitlab-9-0-released/

@jsorah
Copy link
Contributor

jsorah commented Apr 3, 2017

Linking to GitLab CE API v3 to v4 Changes for more context.

@timols
Copy link
Owner

timols commented Apr 16, 2017

Thanks @tomasbjerre. Would you be willing to submit a PR to upgrade to v4?

Should be a relatively easy change based on the link from @jsorah

@tomasbjerre
Copy link
Contributor Author

Perhaps. I cannot promise anything. But yes, if I find the time.

iwarapter added a commit to iwarapter/java-gitlab-api that referenced this issue Apr 23, 2017
@mfriedenhagen
Copy link
Contributor

mfriedenhagen commented Apr 23, 2017

As I wrote in #206, I suggest to bump the major of java-gitlab-api to 4, so it corresponds to the API level.

shinusuresh added a commit to shinusuresh/java-gitlab-api that referenced this issue Apr 25, 2017
timols#201 initial support for v3 -> v4 api changes.
@timols
Copy link
Owner

timols commented Apr 25, 2017

@mfriedenhagen 👏 👏 great work!

More than happy for you to bump the version to v4.

timols pushed a commit that referenced this issue Apr 28, 2017
* #201 initial support for v3 -> v4 api changes.

* Introduce Docker for testing

* Switch to Maven in travis because releases are built with Maven anyway
* Introduce Maven-Wrapper to fixate the used Maven version.
* Reuse existing GitlabAPITest as integration test which will be run
  always when docker is available.
* Use docker-maven-plugin for starting/stopping GitLab.
* For use with Maven run `mvn -Pdocker-gitlab clean verify`. Starting
  GitLab takes a long time (>100 seconds on my Macbook Pro).
* For use in the IDE run:

```
mvn -Pdocker-gitlab,docker-ide docker:start
mvn -Pdocker-gitlab,docker-ide docker:stop
```

* Extract APIForIntegrationTestingHolder

* username/password sessions per time unit are limited

* Need at least source and target 1.7

AssertionError in Tests is only available for >= JDK7

* Use GitlabUploadIT as another integration test

* Don't choke when dockerized SUT is not available

Need to throw AssumptionViolatedException in BeforeClass because
otherwise the class is not initialized correctly.

* Add CONTRIBUTING.md and travis badge.

* Fix API calls for user block/unblock, add some calls

* block/unblock uses POST instead of PUT.
* Add ability to refine permissions for branch protection.
* Add ability to add deploy key with push permission.

* Fix getRawFileContent and getRepositoryTree
@timols
Copy link
Owner

timols commented Apr 28, 2017

This is now in master. Once we've worked out any issues I'll create a release.

@timols timols closed this as completed Apr 28, 2017
@tomasbjerre
Copy link
Contributor Author

Thanks! :)

@tomasbjerre
Copy link
Contributor Author

Will you also release 4.0 soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants