-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API v4 #201
Comments
Linking to GitLab CE API v3 to v4 Changes for more context. |
Thanks @tomasbjerre. Would you be willing to submit a PR to upgrade to v4? Should be a relatively easy change based on the link from @jsorah |
Perhaps. I cannot promise anything. But yes, if I find the time. |
As I wrote in #206, I suggest to bump the major of java-gitlab-api to 4, so it corresponds to the API level. |
timols#201 initial support for v3 -> v4 api changes.
@mfriedenhagen 👏 👏 great work! More than happy for you to bump the version to v4. |
* #201 initial support for v3 -> v4 api changes. * Introduce Docker for testing * Switch to Maven in travis because releases are built with Maven anyway * Introduce Maven-Wrapper to fixate the used Maven version. * Reuse existing GitlabAPITest as integration test which will be run always when docker is available. * Use docker-maven-plugin for starting/stopping GitLab. * For use with Maven run `mvn -Pdocker-gitlab clean verify`. Starting GitLab takes a long time (>100 seconds on my Macbook Pro). * For use in the IDE run: ``` mvn -Pdocker-gitlab,docker-ide docker:start mvn -Pdocker-gitlab,docker-ide docker:stop ``` * Extract APIForIntegrationTestingHolder * username/password sessions per time unit are limited * Need at least source and target 1.7 AssertionError in Tests is only available for >= JDK7 * Use GitlabUploadIT as another integration test * Don't choke when dockerized SUT is not available Need to throw AssumptionViolatedException in BeforeClass because otherwise the class is not initialized correctly. * Add CONTRIBUTING.md and travis badge. * Fix API calls for user block/unblock, add some calls * block/unblock uses POST instead of PUT. * Add ability to refine permissions for branch protection. * Add ability to add deploy key with push permission. * Fix getRawFileContent and getRepositoryTree
This is now in master. Once we've worked out any issues I'll create a release. |
Thanks! :) |
Will you also release 4.0 soon? |
V3 is deprecated; https://about.gitlab.com/2017/03/22/gitlab-9-0-released/
The text was updated successfully, but these errors were encountered: