Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#201 initial support for v3 -> v4 api changes. #206

Closed
wants to merge 1 commit into from

Conversation

iwarapter
Copy link
Contributor

@timols this isnt quite ready yet, however im just putting a docker/travis test harness for this together to get some good functional tests.

@mfriedenhagen
Copy link
Contributor

Probably the major version of java-gitlab-api should be increased because this is not backwards compatible. For easier consumption I would suggest to bump the major to 4 to correspond to the gitlab API version.

@mfriedenhagen
Copy link
Contributor

Based on this branch in #207 I provided at least execution of existing tests in travis

@timols
Copy link
Owner

timols commented Apr 25, 2017

@mfriedenhagen In terms of order, should I merge this PR before #207?

@mfriedenhagen
Copy link
Contributor

Hello, PR #207 contains the commit from this one, I am not sure whether I would need to rebase afterwards. Anyway, let's just try:-)

@timols
Copy link
Owner

timols commented Apr 28, 2017

Going to close this PR since I've merged #207. Thank you very much @iwarapter for this work.

@timols timols closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants