Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multinode tests #6402

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Remove multinode tests #6402

merged 1 commit into from
Dec 11, 2023

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Dec 11, 2023

This tests removes all the multinode test files to remove the burden to keep them update with PRs. The actual code will be removed in followup PRs.

Disable-check: force-changelog-file

Copy link

@fabriziomello, @konskov: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested a review from konskov December 11, 2023 12:01
@svenklemm svenklemm requested a review from antekresic December 11, 2023 12:01
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3151b00) 86.99% compared to head (51f8cbb) 65.46%.

❗ Current head 51f8cbb differs from pull request most recent head c60de16. Consider uploading reports for the commit c60de16 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6402       +/-   ##
===========================================
- Coverage   86.99%   65.46%   -21.54%     
===========================================
  Files         251      251               
  Lines       57921    58053      +132     
  Branches    12906    12936       +30     
===========================================
- Hits        50388    38003    -12385     
- Misses       5116    18183    +13067     
+ Partials     2417     1867      -550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenklemm svenklemm requested a review from akuzm December 11, 2023 12:14
Copy link
Contributor

@jnidzwetzki jnidzwetzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenklemm

There are a few references to dist_ tests in tsl/test/sql/CMakeLists.txt. Could you remove them as well?

diff --git a/tsl/test/sql/CMakeLists.txt b/tsl/test/sql/CMakeLists.txt
index ab4627f71..d6bc010a8 100644
--- a/tsl/test/sql/CMakeLists.txt
+++ b/tsl/test/sql/CMakeLists.txt
@@ -99,8 +99,6 @@ if((${PG_VERSION_MAJOR} GREATER_EQUAL "15"))
 endif()
 
 set(SOLO_TESTS
-    # dist_hypertable needs a lot of memory when the Sanitizer is active
-    dist_hypertable-${PG_VERSION_MAJOR}
     # This interferes with other tests since it reloads the config to increase
     # log level.
     bgw_scheduler_control
@@ -115,7 +113,6 @@ set(SOLO_TESTS
     cagg_bgw
     cagg_ddl-${PG_VERSION_MAJOR}
     cagg_dump
-    dist_util-${PG_VERSION_MAJOR}
     move
     remote_connection_cache
     remote_copy
@@ -159,11 +156,6 @@ if(CMAKE_BUILD_TYPE MATCHES Debug)
   endif()
 endif(CMAKE_BUILD_TYPE MATCHES Debug)
 
-if(ENABLE_MULTINODE_TESTS AND ${PG_VERSION_MAJOR} LESS "16")
-  list(APPEND TEST_TEMPLATES dist_views.sql.in)
-endif()

Rest looks good to me.

@svenklemm svenklemm force-pushed the multinode_test branch 2 times, most recently from 311dd7d to a466d8f Compare December 11, 2023 14:45
This tests removes all the multinode test files to remove the
burden to keep them update with PRs. The actual code will be removed
in followup PRs.
@svenklemm svenklemm enabled auto-merge (rebase) December 11, 2023 15:07
@svenklemm svenklemm merged commit c5bed53 into timescale:main Dec 11, 2023
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants