-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multinode tests #6402
Remove multinode tests #6402
Conversation
@fabriziomello, @konskov: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6402 +/- ##
===========================================
- Coverage 86.99% 65.46% -21.54%
===========================================
Files 251 251
Lines 57921 58053 +132
Branches 12906 12936 +30
===========================================
- Hits 50388 38003 -12385
- Misses 5116 18183 +13067
+ Partials 2417 1867 -550 ☔ View full report in Codecov by Sentry. |
51f8cbb
to
7ebe1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few references to dist_ tests in tsl/test/sql/CMakeLists.txt
. Could you remove them as well?
diff --git a/tsl/test/sql/CMakeLists.txt b/tsl/test/sql/CMakeLists.txt
index ab4627f71..d6bc010a8 100644
--- a/tsl/test/sql/CMakeLists.txt
+++ b/tsl/test/sql/CMakeLists.txt
@@ -99,8 +99,6 @@ if((${PG_VERSION_MAJOR} GREATER_EQUAL "15"))
endif()
set(SOLO_TESTS
- # dist_hypertable needs a lot of memory when the Sanitizer is active
- dist_hypertable-${PG_VERSION_MAJOR}
# This interferes with other tests since it reloads the config to increase
# log level.
bgw_scheduler_control
@@ -115,7 +113,6 @@ set(SOLO_TESTS
cagg_bgw
cagg_ddl-${PG_VERSION_MAJOR}
cagg_dump
- dist_util-${PG_VERSION_MAJOR}
move
remote_connection_cache
remote_copy
@@ -159,11 +156,6 @@ if(CMAKE_BUILD_TYPE MATCHES Debug)
endif()
endif(CMAKE_BUILD_TYPE MATCHES Debug)
-if(ENABLE_MULTINODE_TESTS AND ${PG_VERSION_MAJOR} LESS "16")
- list(APPEND TEST_TEMPLATES dist_views.sql.in)
-endif()
Rest looks good to me.
311dd7d
to
a466d8f
Compare
This tests removes all the multinode test files to remove the burden to keep them update with PRs. The actual code will be removed in followup PRs.
a466d8f
to
c60de16
Compare
This tests removes all the multinode test files to remove the burden to keep them update with PRs. The actual code will be removed in followup PRs.
Disable-check: force-changelog-file