Skip to content

Commit

Permalink
Remove multinode tests
Browse files Browse the repository at this point in the history
This tests removes all the multinode test files to remove the
burden to keep them update with PRs. The actual code will be removed
in followup PRs.
  • Loading branch information
svenklemm committed Dec 11, 2023
1 parent 3ae2dbc commit 51f8cbb
Show file tree
Hide file tree
Showing 135 changed files with 4 additions and 113,956 deletions.
9 changes: 1 addition & 8 deletions .github/gh_matrix_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ def build_debug_config(overrides):
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
}
)
# We use .get() here to be able to handle also configurations without PG versions
if not pull_request or overrides.get("pg") == PG15_LATEST:
base_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
base_config.update(overrides)
return base_config

Expand All @@ -100,8 +97,6 @@ def build_release_config(overrides):
"coverage": False,
}
)
if not pull_request:
release_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
base_config.update(release_config)
base_config.update(overrides)
return base_config
Expand Down Expand Up @@ -157,8 +152,6 @@ def macos_config(overrides):
"tsdb_build_args": "-DASSERTIONS=ON -DREQUIRE_ALL_TESTS=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl",
}
)
if not pull_request:
base_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
base_config.update(overrides)
return base_config

Expand Down Expand Up @@ -228,7 +221,7 @@ def macos_config(overrides):
"dist_gapfill_pushdown-13",
"transparent_decompress_chunk-13",
},
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF -DENABLE_MULTINODE_TESTS=ON",
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF",
}
m["include"].append(build_debug_config(pg13_debug_earliest))

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/abi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
apk add openssl1.1-compat-dev || apk add openssl-dev
git config --global --add safe.directory /mnt
cd /mnt
BUILD_DIR=build_abi BUILD_FORCE_REMOVE=true ./bootstrap -DENABLE_MULTINODE_TESTS=ON
BUILD_DIR=build_abi BUILD_FORCE_REMOVE=true ./bootstrap
make -C build_abi install
mkdir -p build_abi/install_ext build_abi/install_lib
cp `pg_config --sharedir`/extension/timescaledb*.{control,sql} build_abi/install_ext
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sanitizer-build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
- name: Build TimescaleDB
run: |
./bootstrap -DCMAKE_BUILD_TYPE=Debug -DPG_SOURCE_DIR=~/$PG_SRC_DIR -DENABLE_MULTINODE_TESTS=ON \
./bootstrap -DCMAKE_BUILD_TYPE=Debug -DPG_SOURCE_DIR=~/$PG_SRC_DIR \
-DPG_PATH=~/$PG_INSTALL_DIR -DCODECOVERAGE=OFF -DREQUIRE_ALL_TESTS=ON -DTEST_GROUP_SIZE=5
make -j$(nproc) -C build
make -C build install
Expand Down
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ option(
"Enable OPTIMIZER_DEBUG when building. Requires Postgres server to be built with OPTIMIZER_DEBUG."
OFF)
option(ENABLE_DEBUG_UTILS "Enable debug utilities for the extension." ON)
option(ENABLE_MULTINODE_TESTS "Enable multinode-specific tests" OFF)

# Option to enable assertions. Note that if we include headers from a PostgreSQL
# build that has assertions enabled, we might inherit that setting without
Expand Down
744 changes: 0 additions & 744 deletions tsl/test/expected/cagg_bgw_dist_ht.out

This file was deleted.

Loading

0 comments on commit 51f8cbb

Please sign in to comment.