Remove multinode tests

This tests removes all the multinode test files to remove the
burden to keep them update with PRs. The actual code will be removed
in followup PRs.

.github/gh_matrix_builder.py

@@ -79,9 +79,6 @@ def build_debug_config(overrides):
             "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
         }
     )
-    # We use .get() here to be able to handle also configurations without PG versions
-    if not pull_request or overrides.get("pg") == PG15_LATEST:
-        base_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
     base_config.update(overrides)
     return base_config
 
@@ -100,8 +97,6 @@ def build_release_config(overrides):
             "coverage": False,
         }
     )
-    if not pull_request:
-        release_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
     base_config.update(release_config)
     base_config.update(overrides)
     return base_config
@@ -157,8 +152,6 @@ def macos_config(overrides):
             "tsdb_build_args": "-DASSERTIONS=ON -DREQUIRE_ALL_TESTS=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl",
         }
     )
-    if not pull_request:
-        base_config["tsdb_build_args"] += " -DENABLE_MULTINODE_TESTS=ON"
     base_config.update(overrides)
     return base_config
 
@@ -167,7 +160,6 @@ def macos_config(overrides):
 ignored_tests = {}
 
 # common ignored tests for all non-scheduled pg15 tests (e.g. PRs)
-# dist_move_chunk, dist_param, dist_insert, and remote_txn ignored due to flakiness
 if pull_request:
     ignored_tests = {
         "telemetry",
@@ -225,10 +217,9 @@ def macos_config(overrides):
         "pg_extra_args": "--enable-debug --enable-cassert --without-llvm",
         "skipped_tests": {"001_extension"},
         "ignored_tests": {
-            "dist_gapfill_pushdown-13",
             "transparent_decompress_chunk-13",
         },
-        "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF -DENABLE_MULTINODE_TESTS=ON",
+        "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF",
     }
     m["include"].append(build_debug_config(pg13_debug_earliest))
 
@@ -239,7 +230,7 @@ def macos_config(overrides):
                 "pg": PG14_EARLIEST,
                 # The early releases don't build with llvm 14.
                 "pg_extra_args": "--enable-debug --enable-cassert --without-llvm",
-                "ignored_tests": {"dist_gapfill_pushdown-14 memoize"},
+                "ignored_tests": {"memoize"},
             }
         )
     )
@@ -287,7 +278,7 @@ def macos_config(overrides):
     m["include"].append(
         build_debug_config(
             {
-                "ignored_tests": {"dist_gapfill_pushdown-14 memoize"},
+                "ignored_tests": {"memoize"},
                 "pg": 14,
                 "snapshot": "snapshot",
             }

.github/workflows/linux-32bit-build-and-test.yaml

@@ -41,9 +41,7 @@ jobs:
         CC: clang-14
         CXX: clang++-14
         DEBIAN_FRONTEND: noninteractive
-        IGNORES: "append-* debug_notice transparent_decompression-*
-          transparent_decompress_chunk-* pg_dump
-          dist_move_chunk dist_param dist_insert remote_txn telemetry"
+        IGNORES: "append-* transparent_decompression-* transparent_decompress_chunk-* pg_dump telemetry"
         SKIPS: chunk_adaptive histogram_test-*
     strategy:
       fail-fast: false

.github/workflows/sanitizer-build-and-test.yaml

@@ -143,7 +143,7 @@ jobs:
 
     - name: Build TimescaleDB
       run: |
-        ./bootstrap -DCMAKE_BUILD_TYPE=Debug -DPG_SOURCE_DIR=~/$PG_SRC_DIR -DENABLE_MULTINODE_TESTS=ON \
+        ./bootstrap -DCMAKE_BUILD_TYPE=Debug -DPG_SOURCE_DIR=~/$PG_SRC_DIR \
           -DPG_PATH=~/$PG_INSTALL_DIR -DCODECOVERAGE=OFF -DREQUIRE_ALL_TESTS=ON -DTEST_GROUP_SIZE=5
         make -j$(nproc) -C build
         make -C build install

.github/workflows/windows-build-and-test.yaml

@@ -53,19 +53,18 @@ jobs:
         os: [ windows-2022 ]
         build_type: ${{ fromJson(needs.config.outputs.build_type) }}
         ignores: ["chunk_adaptive metadata telemetry"]
-        tsl_ignores: ["compression_algos remote_connection dist_move_chunk dist_param dist_insert dist_backup dist_cagg"]
-        tsl_skips: ["bgw_db_scheduler bgw_db_scheduler_fixed cagg_ddl_dist_ht
-          data_fetcher dist_compression dist_remote_error remote_txn"]
+        tsl_ignores: ["compression_algos"]
+        tsl_skips: ["bgw_db_scheduler bgw_db_scheduler_fixed"]
         pg_config: ["-cfsync=off -cstatement_timeout=60s"]
         include:
           - pg: 13
-            tsl_skips_version: dist_grant-13 dist_partial_agg-13 telemetry_stats-13
+            tsl_skips_version: telemetry_stats-13
           - pg: 14
-            tsl_skips_version: dist_partial_agg-14 dist_grant-14 telemetry_stats-14
+            tsl_skips_version: telemetry_stats-14
           - pg: 15
-            tsl_skips_version: dist_partial_agg-15 dist_grant-15 telemetry_stats-15
+            tsl_skips_version: telemetry_stats-15
           - pg: 16
-            tsl_skips_version: dist_partial_agg-16 dist_grant-16 telemetry_stats-16
+            tsl_skips_version: telemetry_stats-16
     env:
       # PostgreSQL configuration
       PGPORT: 55432

CMakeLists.txt

@@ -26,7 +26,6 @@ option(
   "Enable OPTIMIZER_DEBUG when building. Requires Postgres server to be built with OPTIMIZER_DEBUG."
   OFF)
 option(ENABLE_DEBUG_UTILS "Enable debug utilities for the extension." ON)
-option(ENABLE_MULTINODE_TESTS "Enable multinode-specific tests" OFF)
 
 # Option to enable assertions. Note that if we include headers from a PostgreSQL
 # build that has assertions enabled, we might inherit that setting without