Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix wrong boltdb dependency #4530

Merged
merged 3 commits into from
Dec 31, 2021
Merged

ci: fix wrong boltdb dependency #4530

merged 3 commits into from
Dec 31, 2021

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 31, 2021

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

close #4528
fix wrong boltdb dependency

What is changed and how it works?

fix the go.mod

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 31, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 31, 2021
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4dae784

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Dec 31, 2021
@nolouch nolouch force-pushed the fix-bolt branch 2 times, most recently from b8c8d42 to 23c558d Compare December 31, 2021 08:48
@HunDunDM
Copy link
Member

ref #4502

Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Contributor Author

nolouch commented Dec 31, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d3a84eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Dec 31, 2021

test removed because useless, ref #4532.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #4530 (d3a84eb) into master (632742f) will decrease coverage by 0.28%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4530      +/-   ##
==========================================
- Coverage   75.00%   74.71%   -0.29%     
==========================================
  Files         264      265       +1     
  Lines       27933    27945      +12     
==========================================
- Hits        20950    20878      -72     
- Misses       5123     5195      +72     
- Partials     1860     1872      +12     
Flag Coverage Δ
unittests 74.71% <60.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/config.go 62.50% <ø> (-2.21%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 85.71% <0.00%> (ø)
pkg/dashboard/distroutil/distro.go 54.54% <54.54%> (ø)
pkg/dashboard/dashboard.go 90.00% <100.00%> (+0.25%) ⬆️
pkg/dashboard/uiserver/embedded_assets_rewriter.go 100.00% <100.00%> (ø)
server/schedule/hbstream/heartbeat_streams.go 72.72% <100.00%> (ø)
pkg/logutil/log.go 49.61% <0.00%> (-34.36%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/region_syncer/client.go 75.00% <0.00%> (-8.60%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97596b1...d3a84eb. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 27d7f63 into tikv:master Dec 31, 2021
@nolouch nolouch deleted the fix-bolt branch December 31, 2021 09:59
@nolouch nolouch added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Dec 31, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Dec 31, 2021

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4533.

ti-chi-bot added a commit that referenced this pull request Dec 31, 2021
* ci: fix wrong boltdb dependency

Signed-off-by: nolouch <[email protected]>

* fix test

Signed-off-by: nolouch <[email protected]>

* remove useless log test

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkptr: converted pointer straddles multiple allocations
4 participants