Update dashboard to v2021.12.31.1 #4502

baurine · 2021-12-24T14:57:09Z

Signed-off-by: baurine [email protected]

What problem does this PR solve?

Update TiDB Dashboard to v2021.11.08.1.

Upstream commit: pingcap/tidb-dashboard@b2c4a04 .

Related tidb-dashboard PRs:

Release note

1. Refine manual profiling and continuous profiling UI
2. Use speedscope to show flamegraph
3. Support multiple profiling types for manual profiling
4. Support dynamic distro res
5. New feature: Top SQL

ti-chi-bot · 2021-12-24T14:57:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HunDunDM
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2021-12-24T14:57:11Z

[FORMAT CHECKER NOTIFICATION]

Please provide the associated issue number in the commit messages, for example: close #12345, or ref #12345.

pkg/dashboard/adapter/config.go

pkg/dashboard/uiserver/embedded_assets_rewriter.go

pkg/dashboard/distro/distro.go

breezewish · 2021-12-30T07:57:35Z

CI is failed. Please fix the CI~

breezewish · 2021-12-30T12:54:33Z

@baurine CI is not working. Please fix the CI, then find some one to approve it in tomorrow morning. Otherwise it won't catch up the code freeze.

breezewish

There are also some lint failures.

go.mod

baurine · 2021-12-30T17:03:47Z

.github/workflows/check-dashboard.yaml

-          unzip source.zip
-      - name: Check diff
-        run: |
-          diff -qr ${DASHBOARD_DIR}/ui/ /tmp/dashboard/tidb-dashboard-${DASHBOARD_RELEASE_VERSION}/ui/


${DASHBOARD_DIR} doesn't download ui folder anymore, so we remove this check.

breezewish · 2021-12-30T17:16:51Z

I'm manually verifying these cases, will update the state after finished:

Use a release version - working
Use a master version - working
Specify distro for the compiled binary - working

ti-chi-bot · 2021-12-30T18:05:33Z

@breeswish: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

baurine · 2021-12-31T01:03:00Z

Wait for a new release: pingcap/tidb-dashboard#1120 - v2021.12.31.1

breezewish

Manually tested.

ti-chi-bot · 2021-12-31T03:01:14Z

@breeswish: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Manually tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ref tikv#4257 support dynamic distro res make `DASHBOARD=COMPILE make pd-server` works Signed-off-by: baurine <[email protected]>

ti-chi-bot added do-not-merge/invalid-commit-message release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 24, 2021

baurine marked this pull request as draft December 24, 2021 14:57

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2021

ti-chi-bot requested review from HunDunDM and lhy1024 December 24, 2021 14:57

baurine mentioned this pull request Dec 27, 2021

support dynamic distro config pingcap/tidb-dashboard#1094

Merged

breezewish reviewed Dec 27, 2021

View reviewed changes

pkg/dashboard/adapter/config.go Show resolved Hide resolved

breezewish reviewed Dec 28, 2021

View reviewed changes

pkg/dashboard/uiserver/embedded_assets_rewriter.go Outdated Show resolved Hide resolved

baurine commented Dec 30, 2021

View reviewed changes

pkg/dashboard/distro/distro.go Outdated Show resolved Hide resolved

baurine force-pushed the support-dynamic-distro branch from 9f50963 to 9e9ce3e Compare December 30, 2021 07:45

baurine changed the title ~~support dynamic distro res~~ Update dashboard to v2021.03.30.1 to support dynamic distro res Dec 30, 2021

baurine changed the title ~~Update dashboard to v2021.03.30.1 to support dynamic distro res~~ Update dashboard to v2021.12.30.1 to support dynamic distro res Dec 30, 2021

baurine force-pushed the support-dynamic-distro branch 2 times, most recently from 6254c89 to 9823122 Compare December 30, 2021 08:07

breezewish reviewed Dec 30, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

baurine commented Dec 30, 2021

View reviewed changes

baurine force-pushed the support-dynamic-distro branch from cfea91c to d8bb297 Compare December 30, 2021 17:10

baurine mentioned this pull request Dec 30, 2021

update scripts mod name pingcap/tidb-dashboard#1117

Closed

breezewish approved these changes Dec 30, 2021

View reviewed changes

baurine force-pushed the support-dynamic-distro branch from aca73fd to 81e5af6 Compare December 30, 2021 23:26

baurine marked this pull request as ready for review December 30, 2021 23:28

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2021

baurine marked this pull request as draft December 30, 2021 23:43

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2021

baurine marked this pull request as ready for review December 31, 2021 02:31

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2021

baurine marked this pull request as draft December 31, 2021 02:42

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2021

baurine marked this pull request as ready for review December 31, 2021 02:55

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2021

baurine changed the title ~~Update dashboard to v2021.12.30.1 to support dynamic distro res~~ Update dashboard to v2021.12.31.1 Dec 31, 2021

breezewish approved these changes Dec 31, 2021

View reviewed changes

baurine force-pushed the support-dynamic-distro branch from 726fbf9 to e32c814 Compare December 31, 2021 05:23

HunDunDM approved these changes Dec 31, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021

baurine force-pushed the support-dynamic-distro branch from 9a9193a to cf279f9 Compare December 31, 2021 06:00

update tidb-dashboard to 2021.12.31.1

5ea443d

ref tikv#4257 support dynamic distro res make `DASHBOARD=COMPILE make pd-server` works Signed-off-by: baurine <[email protected]>

baurine force-pushed the support-dynamic-distro branch from cf279f9 to 5ea443d Compare December 31, 2021 06:08

lhy1024 approved these changes Dec 31, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 31, 2021

nolouch force-pushed the support-dynamic-distro branch from a4df33f to 5ea443d Compare December 31, 2021 06:26

zhouqiang-cl merged commit 97596b1 into tikv:master Dec 31, 2021

baurine deleted the support-dynamic-distro branch December 31, 2021 06:28

HunDunDM mentioned this pull request Dec 31, 2021

ci: fix wrong boltdb dependency #4530

Merged

nolouch mentioned this pull request Jan 14, 2022

releases: add TiDB 5.4.0 release notes pingcap/docs-cn#8061

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dashboard to v2021.12.31.1 #4502

Update dashboard to v2021.12.31.1 #4502

baurine commented Dec 24, 2021 •

edited by HunDunDM

Loading

ti-chi-bot commented Dec 24, 2021 •

edited

Loading

ti-chi-bot commented Dec 24, 2021

breezewish commented Dec 30, 2021

breezewish commented Dec 30, 2021

breezewish left a comment

baurine Dec 30, 2021

breezewish commented Dec 30, 2021 •

edited

Loading

ti-chi-bot commented Dec 30, 2021

baurine commented Dec 31, 2021 •

edited

Loading

breezewish left a comment

ti-chi-bot commented Dec 31, 2021

Update dashboard to v2021.12.31.1 #4502

Update dashboard to v2021.12.31.1 #4502

Conversation

baurine commented Dec 24, 2021 • edited by HunDunDM Loading

What problem does this PR solve?

Release note

ti-chi-bot commented Dec 24, 2021 • edited Loading

ti-chi-bot commented Dec 24, 2021

breezewish commented Dec 30, 2021

breezewish commented Dec 30, 2021

breezewish left a comment

Choose a reason for hiding this comment

baurine Dec 30, 2021

Choose a reason for hiding this comment

breezewish commented Dec 30, 2021 • edited Loading

ti-chi-bot commented Dec 30, 2021

baurine commented Dec 31, 2021 • edited Loading

breezewish left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Dec 31, 2021

baurine commented Dec 24, 2021 •

edited by HunDunDM

Loading

ti-chi-bot commented Dec 24, 2021 •

edited

Loading

breezewish commented Dec 30, 2021 •

edited

Loading

baurine commented Dec 31, 2021 •

edited

Loading