Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: remove useless log #4532

Merged
merged 2 commits into from
Jan 1, 2022
Merged

log: remove useless log #4532

merged 2 commits into from
Jan 1, 2022

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 31, 2021

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

close #4531.
There are some logger exist in PD: capnslog, logrus,zap and so on.

after #1452. etcd supports customize the logger, so we can remove the redundant loggers that remaining for compatibility purpose.

What is changed and how it works?

remove useless code

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 31, 2021
@ti-chi-bot ti-chi-bot requested review from rleungx and Yisaer December 31, 2021 09:33
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 31, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Dec 31, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 319778d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021
@HunDunDM
Copy link
Member

/run-unit-test

1 similar comment
@HunDunDM
Copy link
Member

HunDunDM commented Jan 1, 2022

/run-unit-test

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #4532 (319778d) into master (27d7f63) will increase coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4532      +/-   ##
==========================================
+ Coverage   74.75%   74.96%   +0.20%     
==========================================
  Files         265      265              
  Lines       27945    27844     -101     
==========================================
- Hits        20891    20873      -18     
+ Misses       5191     5111      -80     
+ Partials     1863     1860       -3     
Flag Coverage Δ
unittests 74.96% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/logutil/log.go 83.33% <0.00%> (+33.71%) ⬆️
server/api/region.go 67.86% <ø> (ø)
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/region_syncer/server.go 81.41% <0.00%> (-5.13%) ⬇️
server/id/id.go 80.95% <0.00%> (-4.77%) ⬇️
server/member/member.go 63.10% <0.00%> (-3.75%) ⬇️
server/schedule/checker/rule_checker.go 78.97% <0.00%> (-1.03%) ⬇️
server/schedule/operator_controller.go 83.91% <0.00%> (-0.82%) ⬇️
server/encryptionkm/key_manager.go 72.90% <0.00%> (-0.80%) ⬇️
server/schedule/operator/step.go 74.02% <0.00%> (-0.72%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d7f63...319778d. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 24bf11d into tikv:master Jan 1, 2022
@nolouch nolouch deleted the remove-useless-log branch January 4, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove useless logger
5 participants