Update grpc c core to 1.44.0 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Now bindgen is download and compiled only when neccessary. Signed-off-by: Jay Lee <[email protected]>
It becomes more clear that boringssl is used. And now only enabling openssl will not download boringssl anymore. Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
update-grpc-c-core
branch
from
9be4de2 to
08ea77f
Compare
Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
update-grpc-c-core
branch
from
08ea77f to
4625473
Compare
hunterlxt
reviewed
Feb 28, 2022
grpc-sys/build.rs
Outdated
| "absl_graphcycles_internal", "absl_hash", "absl_hashtablez_sampler", "absl_int128", "absl_log_severity", | ||
| "absl_malloc_internal", "absl_raw_hash_set", "absl_raw_logging_internal", "absl_spinlock_wait", | ||
| "absl_stacktrace", "absl_status", "absl_statusor", "absl_str_format_internal", "absl_strings", | ||
| "absl_cord", "absl_cord_internal", "absl_cordz_functions", "absl_cordz_handle", "absl_cordz_info", |
There was a problem hiding this comment.
can you post the command to run pkg-config manually into the comment above
Comment on lines
+399
to
+402
| "x86_64-unknown-linux-gnu" | ||
| | "aarch64-unknown-linux-gnu" | ||
| | "x86_64-apple-darwin" | ||
| | "aarch64-apple-darwin" => { |
There was a problem hiding this comment.
Why are the bindings the same across this platforms?
There was a problem hiding this comment.
I guess because they are both unix-like system and share many common designs. The windows bindings is different from linux though. For example, windows use i32 for enum while unix use u32. More to see rust-lang/rust-bindgen#1907
There was a problem hiding this comment.
I mean, did you found it unconsciously, or did you get the result via bindgen config.
There was a problem hiding this comment.
I found it when I'm working on BusyJay/tirocks#1.
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
hunterlxt
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also uses the same bindings for both (x86_64|aarch64)_(macos|linux). CI will check if it's OK to do so. This should make maintenance easier.
Changes from #539 is also included in this PR.
Features
use-bindgenis removed as it can be detected during compile time now.This PR also rename the secure features to boringssl for better understanding. And now only enabling openssl features will not download boringssl anymore. Close #557.