Openssl feature pulls in boringssl

[Ten0]

Describe the bug
Enabling the openssl feature pulls in 10MB of boringssl-src.
This is due to:

grpc-rs/grpc-sys/Cargo.toml

Lines 57 to 58 in 472ae8a

	secure = ["boringssl-src"]
	openssl = ["secure"]

Expected behavior
IIUC BoringSSL is not required since we're using openssl instead, so that should not be added as a dependency.

[BusyJay]

Agree. How about adding a private feature name "secure_openssl" which acts the same as secure except depending on boringssl-src.

[Ten0]

wouldn't that already be the openssl feature? Does this mean we should just remove the dependency on secure in openssl and just update the cfg flags?

[BusyJay]

Using openssl is OK too, but when checking whether secure features are enabled, it has to be written as cfg!(features = "openssl") || cfg!(features = "secure"). If using a private features, then it can be defined as:

secure = ["boringssl-src", "_secure_enabled"]
openssl = ["_secure_enabled"]

So the check can be written as cfg!(features = "_secure_enabled").

[Ten0]

With regards to always writing an or on these cfg clauses or factoring them as a private feature I have no particular opinion 🙂

Naming seems good.

[BusyJay]

Do you want to contribute this improvement?

[Ten0]

Do you want to contribute this improvement?

I'm afraid I don't have time for this at the moment 😞