Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump grpc-rs to 0.10 #339

Merged
merged 3 commits into from
Mar 20, 2022
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 20, 2022

Signed-off-by: Alex Chi [email protected]

The secure and use-bindgen features are removed in tikv/grpc-rs#558

Also fixes #340

@skyzh skyzh marked this pull request as draft March 20, 2022 04:40
@skyzh
Copy link
Member Author

skyzh commented Mar 20, 2022

@BusyJay @andylokandy @pingyu PTAL, thanks!

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh force-pushed the skyzh/bump-grpc-0.10 branch from 7fe6ba2 to 79dd392 Compare March 20, 2022 05:21
Signed-off-by: Alex Chi <[email protected]>
@TennyZhuang
Copy link

LGTM!

@skyzh
Copy link
Member Author

skyzh commented Mar 20, 2022

Let hold this PR until another approval from active maintainer...

@TennyZhuang TennyZhuang requested a review from BusyJay March 20, 2022 07:04
Copy link
Collaborator

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sticnarf sticnarf merged commit 68b7f1e into tikv:master Mar 20, 2022
@skyzh skyzh deleted the skyzh/bump-grpc-0.10 branch March 20, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request::set_context recurs infinitely
3 participants