Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce time of rebuilding across workspace #1081

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 20, 2022

What's changed and what's your intention?

As title. Also:

  • ./risedev check, ./risedev test, ./risedev test-cov are drop-in replacement for the original make commands.
  • Updates on docs and CI workflows.
  • Note that hakari includes prost 0.7 instead of 0.9 in workspace-hack. For example, as we are using tikv-client, which requires prost 0.7; while we are using prost 0.9 across all other places, hakari is using prost 0.7 in its lock file. I've sent a PR chore: bump grpc-rs to 0.10 tikv/client-rust#339 to upgrade tikv client's prost version.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from TennyZhuang March 20, 2022 04:44
@skyzh skyzh enabled auto-merge (squash) March 20, 2022 04:45
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #1081 (4511d10) into main (9f426a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4511d10 differs from pull request most recent head 59e6b2a. Consider uploading reports for the commit 59e6b2a to get more accurate results

@@            Coverage Diff            @@
##               main    #1081   +/-   ##
=========================================
  Coverage     70.28%   70.29%           
  Complexity     2766     2766           
=========================================
  Files           997      999    +2     
  Lines         83966    83968    +2     
  Branches       1790     1790           
=========================================
+ Hits          59018    59022    +4     
+ Misses        24057    24055    -2     
  Partials        891      891           
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/workspace-hack/build.rs 100.00% <100.00%> (ø)
rust/workspace-hack/src/lib.rs 100.00% <100.00%> (ø)
rust/common/src/types/ordered_float.rs 22.50% <0.00%> (+0.19%) ⬆️
rust/connector/src/filesystem/file_common.rs 81.16% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh requested a review from BugenZhao March 20, 2022 07:34
skyzh added 3 commits March 20, 2022 15:48
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L📖TM

@skyzh skyzh merged commit ff6d994 into main Mar 21, 2022
@skyzh skyzh deleted the skyzh/add-cargo-hakari branch March 21, 2022 05:07
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants