-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce time of rebuilding across workspace #1081
Conversation
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
=========================================
Coverage 70.28% 70.29%
Complexity 2766 2766
=========================================
Files 997 999 +2
Lines 83966 83968 +2
Branches 1790 1790
=========================================
+ Hits 59018 59022 +4
+ Misses 24057 24055 -2
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L📖TM
Signed-off-by: Alex Chi <[email protected]>
What's changed and what's your intention?
As title. Also:
./risedev check
,./risedev test
,./risedev test-cov
are drop-in replacement for the original make commands.hakari
includes prost 0.7 instead of 0.9 in workspace-hack. For example, as we are usingtikv-client
, which requires prost 0.7; while we are using prost 0.9 across all other places, hakari is using prost 0.7 in its lock file. I've sent a PR chore: bump grpc-rs to 0.10 tikv/client-rust#339 to upgrade tikv client's prost version.Checklist
Refer to a related PR or issue link (optional)