-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol v2 / iOS Support [Beta] #475
Conversation
May I ask what are the protocol changes? :-) |
This is a FLOSS project, so I'd say always ask (or, "review" the PR) if you have good reasons to do so. Just maybe have a (detailed) look at the whitepaper and stuff before. 😉 It's always good to make Threema aware of the advantages of FLOSS. 😜 |
Well, perhaps I've asked the wrong question. 😄 Of course, I can find some information from the PR. What I wanted to know is what those protocol changes (beside iOS support) will change/improve. Or are those changes just small things like changing the date format without further effect on stability/performance etc.? Sorry. |
Ah, so you wanted to ask about the PR and not ask for things by yourself. Sorry, misunderstood your question. |
Nothing fancy, just a lot of cleanup to a historically grown protocol (e.g. moving success flags from data to args, sending dates as timestamp, etc). |
public/i18n/de.json
Outdated
"invalidDistributionList": "Ungültige Verteilerliste", | ||
"notAllowed": "Bearbeitung nicht erlaubt", | ||
"notAllowedLinked": "Systemkontakt kann nicht verändert werden", | ||
"notAllowedBusiness": "Avatar eines Threema Work Kontaktes kann nicht geändert werden", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A business contact is a "gateway contact" not a "work contact"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch :)
How about adding support for #198 in Protocol v2 ? |
Why has the compatibility footer been removed? |
@joelfischerr It's a bit more complicated than that, since for example Safari will only support iOS, but not Android in the beginning. So we'll show browser-specific hints instead. Also, Windows Phone is dying at a slow but steady pace, so most people using Threema on that platform will probably be aware that not all features are implemented :) |
Apparently in newer versions of ng-material or angularjs, the "ng-click" attribute may not be an empty string.
This commit also introduces support for TypeScript async/await syntax 🎉
- Upgrade Angular.js to 1.7 - Upgrade many other dependencies - Introduce support for async/await
Fix missing double quote and redundant slash in test
Because of a change in croppie (Foliotek/Croppie@e158771), the recent update broke initialization of the `Croppie` class. Changing the class name helps.
The stop() call above may result in a redirect, which will in turn hide all open dialog boxes. Therefore, to avoid immediately hiding the alert box, enqueue dialog at end of event loop. Fixes #529.
We need higher specificity than the existing material design rules (or `!important`) in order for the override to take effect.
Let the user know that an app upgrade is necessary. Only show this dialog once (unless the user clears local storage on browser exit, in which case we can't do much about it).
This reverts commit 616eb60.
Note: This is now merged into master (since Android now also uses the protocol version 2), but iOS will stay in beta for the time being. |
Tracking issue, work in progress.
Will fix #58 / fix #221 / fix #154 / fix #476 / fix #393 / fix #32 / fix #97 / fix #445 / fix #507 / fix #4 / fix #517 / fix #519 / fix #480.