Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still get browser notifications for "do not disturb" chats #507

Closed
rugk opened this issue Jun 2, 2018 · 1 comment · Fixed by #475
Closed

Still get browser notifications for "do not disturb" chats #507

rugk opened this issue Jun 2, 2018 · 1 comment · Fixed by #475

Comments

@rugk
Copy link
Contributor

rugk commented Jun 2, 2018 •
edited
Loading

Expected Behavior

No browser notifications. (as it also is done correctly in the app, where I get no notification)

Current Behavior

I still get browser notifications, just without a sound. (as if they were just "muted")

Possible Solution

Steps to Reproduce (for bugs)

  1. Mark a (group) chat in Threema as "do not disturb (unless you are @mentioned). And I don't mean the "mute" setting by it – this can stay the default.
  2. Get a message in that chat while connected to Threema Web.

Your Environment

  • Threema Web version: 1.8.2-gh
  • Threema App version: 3.41
  • Browser name and version: Firefox 60
  • Computer operating system and version: Fedora 28 (GNOME)
  • Smartphone operating system and version: Android
dbrgn pushed a commit that referenced this issue Jun 4, 2018
@threema-danilo
Update app icon for various platforms
da7fac1 
The icons and config were generated with the help of
https://realfavicongenerator.net/.

Fixes #507
dbrgn pushed a commit that referenced this issue Jun 4, 2018
@threema-danilo
Update app icon for various platforms
bffbeb4 
The icons and config were generated with the help of
https://realfavicongenerator.net/.

Fixes #507
@dbrgn
Copy link
Contributor

dbrgn commented Jun 4, 2018

This is already implemented in the 2.0.0 beta.

@dbrgn dbrgn mentioned this issue Jun 4, 2018
Merged
@dbrgn dbrgn closed this as completed in #475 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protocol v2 / iOS Support [Beta] threema-ch/threema-web
2 participants
@dbrgn @rugk