Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flashing battery icon is CPU intensive #519

Closed
lgrahl opened this issue Jun 17, 2018 · 6 comments · Fixed by #475
Closed

Flashing battery icon is CPU intensive #519

lgrahl opened this issue Jun 17, 2018 · 6 comments · Fixed by #475
Labels
bug It's a bug! performance Impacts performance

Comments

@lgrahl
Copy link
Contributor

lgrahl commented Jun 17, 2018 •
edited
Loading

Turns out the pulsating battery icon is very CPU intensive, at least in Firefox. Weirdly...
@dbrgn
Copy link
Contributor

dbrgn commented Jun 17, 2018

It's just this 🙄 https://github.com/threema-ch/threema-web/blob/master/src/sass/components/_battery.scss#L6-L8

How did you measure the CPU load? Can you try this? https://jsfiddle.net/Ly1sgt89/3/

@lgrahl
Copy link
Contributor Author

lgrahl commented Jun 17, 2018

How did you measure the CPU load?

System Monitor.

Your fiddle creates ~3% of load (which is still too much) but in the web client it was around 25%.

@dbrgn
Copy link
Contributor

dbrgn commented Jun 17, 2018

which is still too much

I'm not sure. If you think so, you should probably file a Firefox bug, together with a performance trace.

25% is very high though. I'll have to take a look at that later.

@lgrahl
Copy link
Contributor Author

lgrahl commented Jun 17, 2018

Yes, my notebook fan didn't like it. 😸

@dbrgn dbrgn added bug It's a bug! performance Impacts performance labels Jun 17, 2018
dbrgn pushed a commit that referenced this issue Jul 2, 2018
@threema-danilo
Disable low battery CSS animation
d0f749b 
Fixes #519.
@dbrgn dbrgn mentioned this issue Jul 2, 2018
Merged
@dbrgn
Copy link
Contributor

dbrgn commented Jul 2, 2018

Replaced with a non-flashing red icon in the ios branch.

@dbrgn dbrgn closed this as completed Jul 2, 2018
@dbrgn
Copy link
Contributor

dbrgn commented Aug 23, 2018 •
edited
Loading

Yes, my notebook fan didn't like it.

commitstrip comic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug! performance Impacts performance
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protocol v2 / iOS Support [Beta] threema-ch/threema-web
2 participants
@dbrgn @lgrahl