[tr064] Merge duplicate phone book entries (openhab#9739)

* [tr064] Merge duplicate phone book entries Fixes openhab#9738 Signed-off-by: Stefan Triller <[email protected]>
thinkingstone · Nov 7, 2021 · 7aba980 · 7aba980
1 parent 710dcbf
commit 7aba980
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/....tr064/src/main/java/org/openhab/binding/tr064/internal/phonebook/Tr064PhonebookImpl.java b/....tr064/src/main/java/org/openhab/binding/tr064/internal/phonebook/Tr064PhonebookImpl.java
@@ -72,14 +72,25 @@ private void getPhonebook() {
             phonebook = phonebooksType.getPhonebook().getContact().stream().map(contact -> {
                 String contactName = contact.getPerson().getRealName();
                 return contact.getTelephony().getNumber().stream()
-                        .collect(Collectors.toMap(number -> normalizeNumber(number.getValue()), number -> contactName));
+                        .collect(Collectors.toMap(number -> normalizeNumber(number.getValue()), number -> contactName,
+                                this::mergeSameContactNames));
             }).collect(HashMap::new, HashMap::putAll, HashMap::putAll);
             logger.debug("Downloaded phonebook {}: {}", phonebookName, phonebook);
         } catch (JAXBException | InterruptedException | ExecutionException | TimeoutException e) {
             logger.warn("Failed to get phonebook with URL {}:", phonebookUrl, e);
         }
     }
 
+    // in case there are multiple phone entries with same number -> name mapping, i.e. in phonebooks exported from
+    // mobiles containing multiple accounts like: local, cloudprovider1, messenger1, messenger2,...
+    private String mergeSameContactNames(String nameA, String nameB) {
+        if (nameA != null && nameA.equals(nameB)) {
+            return nameA;
+        }
+        throw new IllegalStateException(
+                "Found different names for the same number: '" + nameA + "' and '" + nameB + "'");
+    }
+
     @Override
     public String getName() {
         return phonebookName;