-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr064] Duplicate phonebook entries lead to exception #9738
Labels
bug
An unexpected problem or unintended behavior of an add-on
Comments
t2000
added a commit
to t2000/openhab2-addons
that referenced
this issue
Jan 7, 2021
Fixes openhab#9738 Signed-off-by: Stefan Triller <[email protected]>
cweitkamp
pushed a commit
that referenced
this issue
Jan 9, 2021
* [tr064] Merge duplicate phone book entries Fixes #9738 Signed-off-by: Stefan Triller <[email protected]>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this issue
May 10, 2021
* [tr064] Merge duplicate phone book entries Fixes openhab#9738 Signed-off-by: Stefan Triller <[email protected]> Signed-off-by: John Marshall <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this issue
Nov 7, 2021
* [tr064] Merge duplicate phone book entries Fixes openhab#9738 Signed-off-by: Stefan Triller <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this issue
May 5, 2022
* [tr064] Merge duplicate phone book entries Fixes openhab#9738 Signed-off-by: Stefan Triller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have encountered this exception with my fritzbox phone book:
Apparently the problem is that the phonebook is an export from my mobile phone.
My mobile phone has multiple accounts where it creates the full phone book from. There is the phone internal phone book, one from a carddav server, one from telegram, one from signal, etc.
If there people that I have added in the carddav phonebook, apps like telegram will create a copy of this contact in a "telegram phone book". The mobile phone correctly merges these 2 contacts from the 2 accounts back into one for a list for the user to scroll through without seeing duplicates.
However, If I export such a phonebook that contains these multiple accounts I get. And here the part in "()" refers to the type of the entry, so its not part of the name string!:
The fritzbox understands the fact that one number belongs to "mobile" and one belongs to "other". So this is a valid phonebook for the fritzbox as well.
The problem is the mapping function in
Tr064PhonebookImpl.lambda$0(Tr064PhonebookImpl.java:76
, it throws the aforementioned exception. And I think it is right when throwing such an exception IFF there are two or more DIFFERENT names for the same number. But it should NOT throw an exception if there are multiple entries for one number, all pointing to the the very same name.The text was updated successfully, but these errors were encountered: