Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr064] Merge duplicate phone book entries #9739

Merged
merged 2 commits into from
Jan 9, 2021

Conversation

t2000
Copy link
Contributor

@t2000 t2000 commented Jan 7, 2021

Fixes #9738

Signed-off-by: Stefan Triller [email protected]

@t2000 t2000 requested a review from J-N-K as a code owner January 7, 2021 20:47
Signed-off-by: Stefan Triller <[email protected]>
@t2000
Copy link
Contributor Author

t2000 commented Jan 8, 2021

Thanks, I have integrated your suggestion. (Though I used my git client instead of clicking on your suggestion on github, because I never know if the commit from github satisfies the DCO signature check...).

@t2000 t2000 requested a review from cpmeister January 9, 2021 09:37
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 43a0439 into openhab:main Jan 9, 2021
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label Jan 9, 2021
@cweitkamp cweitkamp added this to the 3.1 milestone Jan 9, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/missing-call-monitor-for-fritzbox-after-oh3-upgrade/111561/15

@t2000 t2000 deleted the fixTr064DuplicateContacts branch January 31, 2021 16:21
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* [tr064] Merge duplicate phone book entries

Fixes openhab#9738

Signed-off-by: Stefan Triller <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [tr064] Merge duplicate phone book entries

Fixes openhab#9738

Signed-off-by: Stefan Triller <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [tr064] Merge duplicate phone book entries

Fixes openhab#9738

Signed-off-by: Stefan Triller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tr064] Duplicate phonebook entries lead to exception
4 participants