chore: Enable Save and Return by default #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jul 28, 2022
Comment on lines
+87
to
+88
| if (isSingleSession) { | ||
| // Use local storage for simple, non-Save&Return flows |
There was a problem hiding this comment.
This diff in this file is weird because I've swapped the order of the if/else blocks to rely on a positive condition.
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
This is a very neat solution! 🎉
On the pizza, I confirmed that:
- Save & return was enabled by default for expected flows
- I could toggle the feature flag to disable save & return for those flows
- I had local storage (could leave tab & return to same place) when feature flag was toggled
gunar
added a commit
that referenced
this pull request
Jul 28, 2022
…mains # By Jessica McInchak (11) and Dafydd Llŷr Pearson (10) # Via GitHub * origin/main: (21 commits) chore: Upgrade Editor dependencies (Part 1) (#1047) chore: upgrade metabase (#1050) fix: Drop sslPolicy for HTTP (#1051) chore(infra): Update HTTP/HTTPS listener SSL policy (#1049) chore: Enable Save and Return by default (#1048) fix: add single line address as separate CSV row (#1046) feat: Enable emailReplyToID (#1044) fix: Display ContentPage on Save and Return path (#1045) chore: upgrade scripts/seed-database dependencies (#1043) chore: upgrade e2e test dependencies (#1042) fix: adjust HASURA_GRAPHQL_CORS_DOMAIN in pulumi (#1041) fix: preserve breadcrumb order when reconciling changed content (#1034) fix: restrict a user from drawing a site boundary and uploading a location plan (#1040) feat: Apply basic rate limiting to API (#1038) fix: use HASURA_GRAPHQL_CORS_DOMAIN env variable to whitelist domains (#1039) fix: Downgrade passport back to 0.5.3 (#1037) chore: Update Hasura (#1035) build: Upgrade API dependencies (#1033) chore: remove Uniform feature flag (#1027) fix: Review page shows all DrawBoundary data (map and/or plan) and file gets correct BOPS tag (#1030) ... # Conflicts: # editor.planx.uk/package.json # editor.planx.uk/pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2! 🎬
This PR...
"DISABLE_SAVE_AND_RETURN"for a better developer experience