Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust HASURA_GRAPHQL_CORS_DOMAIN in pulumi #1041

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 27, 2022

Now, this will whitelist:

  • http://*.${DOMAIN} - covers Hasura to API requests within Docker (eg http://api.planx.dev, which is http://api:7002 locally)
  • https://*.${DOMAIN} - covers public domains (eg https://api.planx.dev)
  • https://${DOMAIN} - covers custom subdomains (eg https://planningservices.southwark.gov.uk, but not https://api.planningservices.southwark.gov.uk)

Continues #1039

@jessicamcinchak
Copy link
Member Author

@github-actions
Copy link

github-actions bot commented Jul 27, 2022

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit b07ec6d into main Jul 27, 2022
@jessicamcinchak jessicamcinchak deleted the jess/cors-domains-pulumi branch July 27, 2022 15:00
gunar added a commit that referenced this pull request Jul 28, 2022
…mains

# By Jessica McInchak (11) and Dafydd Llŷr Pearson (10)
# Via GitHub
* origin/main: (21 commits)
  chore: Upgrade Editor dependencies (Part 1) (#1047)
  chore: upgrade metabase (#1050)
  fix: Drop sslPolicy for HTTP (#1051)
  chore(infra): Update HTTP/HTTPS listener SSL policy (#1049)
  chore: Enable Save and Return by default (#1048)
  fix: add single line address as separate CSV row (#1046)
  feat: Enable emailReplyToID (#1044)
  fix: Display ContentPage on Save and Return path (#1045)
  chore: upgrade scripts/seed-database dependencies (#1043)
  chore: upgrade e2e test dependencies (#1042)
  fix: adjust HASURA_GRAPHQL_CORS_DOMAIN in pulumi (#1041)
  fix: preserve breadcrumb order when reconciling changed content (#1034)
  fix: restrict a user from drawing a site boundary and uploading a location plan (#1040)
  feat: Apply basic rate limiting to API (#1038)
  fix: use HASURA_GRAPHQL_CORS_DOMAIN env variable to whitelist domains (#1039)
  fix: Downgrade passport back to 0.5.3 (#1037)
  chore: Update Hasura (#1035)
  build: Upgrade API dependencies (#1033)
  chore: remove Uniform feature flag (#1027)
  fix: Review page shows all DrawBoundary data (map and/or plan) and file gets correct BOPS tag (#1030)
  ...

# Conflicts:
#	editor.planx.uk/package.json
#	editor.planx.uk/pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants