fix: adjust HASURA_GRAPHQL_CORS_DOMAIN in pulumi #1041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, this will whitelist:
http://*.${DOMAIN}
- covers Hasura to API requests within Docker (eghttp://api.planx.dev
, which ishttp://api:7002
locally)https://*.${DOMAIN}
- covers public domains (eghttps://api.planx.dev
)https://${DOMAIN}
- covers custom subdomains (eghttps://planningservices.southwark.gov.uk
, but nothttps://api.planningservices.southwark.gov.uk
)Continues #1039